New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redox: Fix Condvar.wait(); do not lock mutex twice #43071

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@ids1024
Contributor

ids1024 commented Jul 5, 2017

No description provided.

@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Jul 5, 2017

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@sfackler

This comment has been minimized.

Member

sfackler commented Jul 5, 2017

I'm not familiar with Redox's convar implementation but just deleting that loop entirely seems pretty suspicious.

@ids1024 ids1024 closed this Jul 5, 2017

@ids1024

This comment has been minimized.

Contributor

ids1024 commented Jul 5, 2017

The loop was more or less duplicating the call to mutex_lock(); but actually I think it may be correct to remove that call rather than this loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment