Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upSplit old and experimental wasm builders #43175
Conversation
rust-highfive
assigned
brson
Jul 12, 2017
This comment has been minimized.
This comment has been minimized.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
assigned
alexcrichton
and unassigned
brson
Jul 12, 2017
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors: r+ |
This comment has been minimized.
This comment has been minimized.
|
|
aidanhs
added
the
S-waiting-on-bors
label
Jul 13, 2017
This comment has been minimized.
This comment has been minimized.
|
|
alexcrichton
added
S-waiting-on-author
and removed
S-waiting-on-bors
labels
Jul 13, 2017
tlively
force-pushed the
tlively:wasm-split-bots
branch
from
373e958
to
3bf8116
Jul 13, 2017
This comment has been minimized.
This comment has been minimized.
|
@alexcrichton updated |
This comment has been minimized.
This comment has been minimized.
|
@bors: r+ |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Jul 14, 2017
This comment has been minimized.
This comment has been minimized.
|
|
tlively commentedJul 12, 2017
#42784 introduced configuration errors in the wasm builder by mixing different versions of the tools. This PR separates the wasm32-unknown-emscripten and wasm32-experimental-emscripten builders to resolve these errors.