Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] Remove rls from the workspace and extended builds #43199

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@cuviper
Copy link
Member

cuviper commented Jul 13, 2017

Its git dependencies don't work when building with vendored crates,
so for now it will just be removed from the workspace and disabled in
the rustbuild rules.

cc #42719

[beta] Remove rls from the workspace and extended builds
Its git dependencies don't work when building with vendored crates,
so for now it will just be removed from the workspace and disabled in
the rustbuild rules.

cc #42719
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jul 13, 2017

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jul 13, 2017

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!
@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Jul 13, 2017

@bors: r+ p=100

Thanks @cuviper!

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jul 13, 2017

📌 Commit 6d6fccb has been approved by alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jul 13, 2017

⌛️ Testing commit 6d6fccb with merge 4f9ee81...

bors added a commit that referenced this pull request Jul 13, 2017

Auto merge of #43199 - cuviper:beta-sans-rls, r=alexcrichton
[beta] Remove rls from the workspace and extended builds

Its git dependencies don't work when building with vendored crates,
so for now it will just be removed from the workspace and disabled in
the rustbuild rules.

cc #42719
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jul 13, 2017

💔 Test failed - status-travis

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Jul 13, 2017

@bors: r+ p=25

  • should be fixed so long as this lands after #43114
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jul 13, 2017

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: #43114
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jul 13, 2017

📌 Commit 6d6fccb has been approved by alexcrichton

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Jul 13, 2017

I'm going to manually roll this into #43208 to get the new beta out sooner, so closing.

@cuviper cuviper deleted the cuviper:beta-sans-rls branch Oct 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.