Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upfloat_bits_conv made it into 1.20 #43315
Conversation
rust-highfive
assigned
BurntSushi
Jul 18, 2017
This comment has been minimized.
This comment has been minimized.
|
r? @BurntSushi (rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
|
@bors: r+ |
This comment has been minimized.
This comment has been minimized.
|
|
Mark-Simulacrum
added
the
beta-nominated
label
Jul 18, 2017
This comment has been minimized.
This comment has been minimized.
|
@bors rollup |
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Jul 18, 2017
bors
added a commit
that referenced
this pull request
Jul 18, 2017
bors
added a commit
that referenced
this pull request
Jul 18, 2017
arielb1
added
S-waiting-on-bors
T-libs
labels
Jul 18, 2017
bors
merged commit ffefc9a
into
rust-lang:master
Jul 19, 2017
1 check failed
continuous-integration/travis-ci/pr
The Travis CI build could not complete due to an error
Details
alexcrichton
added
the
beta-accepted
label
Aug 1, 2017
alexcrichton
referenced this pull request
Aug 12, 2017
Merged
Backporting accepted PRs to beta #43831
alexcrichton
removed
the
beta-nominated
label
Aug 12, 2017
bors
added a commit
that referenced
this pull request
Aug 13, 2017
bors
added a commit
that referenced
this pull request
Aug 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
est31 commentedJul 18, 2017
It seems that my PR to stabilize the
float_bits_convfeature got merged before beta branched, which means I'm lucky, and the stabilization makes it into Rust 1.20. As it was against my expectations, the version number has to be corrected from 1.21 to 1.20.Please also apply this PR to the beta branch.