Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upWIP implement a machine readable print-type-info API #43761
Conversation
rust-highfive
assigned
arielb1
Aug 9, 2017
This comment has been minimized.
This comment has been minimized.
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
aidanhs
added
the
S-waiting-on-review
label
Aug 10, 2017
Gankro
force-pushed the
Gankro:print-types
branch
from
a411eff
to
a0e19fd
Aug 11, 2017
This comment has been minimized.
This comment has been minimized.
|
|
arielb1
added
S-waiting-on-author
T-compiler
and removed
S-waiting-on-review
labels
Aug 15, 2017
This comment has been minimized.
This comment has been minimized.
|
What's the status of this PR? Do you need any help (I won't be available until this Monday)? |
This comment has been minimized.
This comment has been minimized.
|
Hey @arielb1 sorry I pivoted off this a bit and then went on vacation. Tomorrow I get back to work and, unless I get some information stating otherwise, this should be my top priority. |
This comment has been minimized.
This comment has been minimized.
|
Hi @Gankro are you still working on this? Just a ping to make sure it isn't getting lost. |
This comment has been minimized.
This comment has been minimized.
|
Hiii Ganksy, triage procedure says a PR with >14 days of no author activity gets closed as inactive. Feel free to reopen when you have a chance to get back to this! |
carols10cents
closed this
Sep 11, 2017
carols10cents
added
S-inactive-closed
and removed
S-waiting-on-author
labels
Sep 11, 2017
This comment has been minimized.
This comment has been minimized.
|
Yeah I'll get back to this once I've got all the fires in webrender put out! |
This comment has been minimized.
This comment has been minimized.
|
I have a branch in progress which if I get out soon would provide a much better baseline for this. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
(continuing this work is blocked on that PR) |
This comment has been minimized.
This comment has been minimized.
|
@Gankro Given that the referenced PR was merged couple of months ago, are there any other blockers for this one left? (apart from free time, of course |
This comment has been minimized.
This comment has been minimized.
|
My enum RFC combined with cbindgen relieves a lot of pressure on this, and i'm recovering on indeterminate-length leave right now, so if you're interested I suggest taking this over. |
Gankro commentedAug 9, 2017
•
edited
This is very messy, with some commented out stuff and some TODOs. I'm posting this now to get feedback on the approach, and so someone can tell me where stuff should go or if I'm doing some things fundamentally wrong. Note that I'm currently clobbering
-Zprint-type-sizesto avoid doing driver plumbing atm.Background Proposal (doesn't completely match impl, see below)
Draft Documentation
Sample output on gecko/gfx/webrender_bindings
Differences from background proposal:
TODO
-Zprint-type-sizes