Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stabilize mem::discriminant (closes #24263) #44263

Merged
merged 1 commit into from Sep 4, 2017
+8 −15

Conversation

Reviewers
No reviews
Assignees

@dtolnay dtolnay

Labels
T-libs beta-accepted relnotes
Projects
None yet
Milestone
No milestone
6 participants
@durka @rust-highfive @dtolnay @bors @est31 @alexcrichton
@durka
Copy link
Contributor

durka commented Sep 2, 2017

No description provided.

@rust-highfive rust-highfive assigned dtolnay Sep 2, 2017

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Sep 2, 2017

r? @dtolnay

(rust_highfive has picked a reviewer for you, use r? to override)

@dtolnay dtolnay added beta-nominated T-libs labels Sep 2, 2017

@dtolnay

This comment has been minimized.

Sign in to view
Copy link
Member

dtolnay commented Sep 2, 2017

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Sep 2, 2017

📌 Commit d516434 has been approved by dtolnay
@est31

This comment has been minimized.

Sign in to view
Copy link
Contributor

est31 commented Sep 2, 2017

@dtolnay if this is to be merged on beta, #44262 has to be as well.
@durka

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

durka commented Sep 2, 2017

If it's going to beta, the "since" field should be changed as well.
@durka

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

durka commented Sep 2, 2017

I don't think this depends on #44262. That splits out #[repr(i128)] from the i128_type feature gate but doesn't stabilize either one.
@est31

This comment has been minimized.

Sign in to view
Copy link
Contributor

est31 commented Sep 2, 2017

ahh right its still unstable.
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Sep 3, 2017

⌛️ Testing commit d516434 with merge 0006d3e...

bors added a commit that referenced this pull request Sep 3, 2017

@bors
Auto merge of #44263 - durka:stabilize-discriminant, r=dtolnay 
stabilize mem::discriminant (closes #24263)
Loading status checks…
0006d3e
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Sep 4, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: dtolnay
Pushing 0006d3e to master...

@bors bors merged commit d516434 into rust-lang:master Sep 4, 2017
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@alexcrichton alexcrichton added the beta-accepted label Sep 13, 2017

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Sep 13, 2017

Accepting for backport according to the last libs triage
@durka

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

durka commented Sep 13, 2017

@alexcrichton should I do that, or will you? including fixing up the since fields?
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Sep 13, 2017

Ah it's ok, I'll do it at some point with other backports. Want to send a PR to master to update the fields?

@durka durka referenced this pull request Sep 13, 2017

Merged

update "since" for discriminant_value #44552

@durka

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

durka commented Sep 13, 2017

#44552
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Sep 13, 2017

Thanks!

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Sep 14, 2017

@frewsxcv
Rollup merge of rust-lang#44552 - durka:patch-42, r=alexcrichton 
update "since" for discriminant_value

It's [going](rust-lang#44263 (comment)) to be backported to beta.

r? @alexcrichton
24c4e26

@alexcrichton alexcrichton referenced this pull request Sep 14, 2017

Merged

[beta] Attempt to fix the component manifest problem for rls-preview #44357

@alexcrichton alexcrichton removed the beta-nominated label Sep 14, 2017

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Sep 15, 2017

@frewsxcv
Rollup merge of rust-lang#44552 - durka:patch-42, r=alexcrichton 
update "since" for discriminant_value

It's [going](rust-lang#44263 (comment)) to be backported to beta.

r? @alexcrichton
ffd286b

@dtolnay dtolnay added the relnotes label Sep 21, 2017

@dtolnay dtolnay referenced this pull request Sep 21, 2017

Merged

Updated RELEASES.md for 1.21.0 #44481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.