Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert clamp #44438

Merged
merged 6 commits into from Sep 9, 2017

Conversation

Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@Xaeroxe @rust-highfive @Mark-Simulacrum @bors @nikomatsakis
@Xaeroxe
Copy link
Contributor

Xaeroxe commented Sep 8, 2017 •
edited

Revert clamp per #44095 (comment) while we take time to assess the potential backwards compatibility damage done by it.

@rust-highfive rust-highfive assigned nikomatsakis Sep 8, 2017

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Sep 8, 2017

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Xaeroxe added some commits Sep 8, 2017

@Xaeroxe
Revert "Add panic unit tests" 
This reverts commit b762283.
67283fa
@Xaeroxe
Revert "Fix documentation and formatting." 
This reverts commit 2e34ff7.
8b96167
@Xaeroxe
Revert "Fix f64 examples" 
This reverts commit 576426a.
15d3eea
@Xaeroxe
Revert "Fix f32 examples." 
This reverts commit 61f20f8.
eafdad5
@Xaeroxe
Revert "Add NAN examples" 
This reverts commit f74c5d2.
63f4dab
@Xaeroxe
Revert "Add clamp functions" 
This reverts commit c589f86.
Loading status checks…
db5b5f9

@Xaeroxe Xaeroxe referenced this pull request Sep 8, 2017

Open

Tracking issue for clamp RFC #44095

2 of 2 tasks complete
@Mark-Simulacrum

This comment has been minimized.

Sign in to view
Copy link
Member

Mark-Simulacrum commented Sep 8, 2017

@bors r+ p=1 (undoing a regression)
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Sep 8, 2017

📌 Commit db5b5f9 has been approved by Mark-Simulacrum
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Sep 9, 2017

⌛️ Testing commit db5b5f9 with merge 929b878...

bors added a commit that referenced this pull request Sep 9, 2017

@bors
Auto merge of #44438 - Xaeroxe:clamp, r=Mark-Simulacrum 
Revert clamp

Revert clamp per #44095 (comment) while we take time to assess the potential backwards compatibility damage done by it.
Loading status checks…
929b878
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Sep 9, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing 929b878 to master...

@bors bors merged commit db5b5f9 into rust-lang:master Sep 9, 2017
1 of 2 checks passed

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
homu Test successful
Details

@Xaeroxe Xaeroxe deleted the Xaeroxe:clamp branch Sep 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.