Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdated RELEASES.md for 1.21.0 #44481
Conversation
rust-highfive
assigned
alexcrichton
Sep 10, 2017
This comment has been minimized.
This comment has been minimized.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
petrochenkov
reviewed
Sep 10, 2017
|
|
||
| Libraries | ||
| --------- | ||
| - [Generate builtin impls for `Clone` for `[T: N]` where `N` is between 0 |
This comment has been minimized.
This comment has been minimized.
petrochenkov
reviewed
Sep 10, 2017
| Language | ||
| -------- | ||
| - [Relaxed path syntax. You can now add type parameters to values][43540] | ||
| Example: `struct Foo<T>(T); let bar = Foo::<u8>(0);`. |
This comment has been minimized.
This comment has been minimized.
petrochenkov
Sep 10, 2017
Contributor
Foo::<u8>(0) was always possible, what #43540 does is permitting (sometimes unnecessary) :: before < in all paths, including paths passed to macros.
Previously:
my_macro!(Vec<i32>::new); // OK
my_macro!(Vec::<i32>::new); // ERRORNow:
my_macro!(Vec<i32>::new); // OK
my_macro!(Vec::<i32>::new); // OK too
zackmdavis
reviewed
Sep 11, 2017
| - [Remove the trait selection impl in method::probe][43880] This may cause | ||
| breakage in subtyping corner cases. | ||
| - [make JSON error's byte position start at top of file.][42973] Was previously | ||
| relative to the `CodeMap` which required unstable code. |
This comment has been minimized.
This comment has been minimized.
zackmdavis
Sep 11, 2017
Member
Release note readers shouldn't need to think about named internal implementation details like CodeMap, and I'm not sure where "which required unstable code" is coming from.
Maybe something like "was previously relative to a concatenation of files in a crate"?? (I don't actually know how the compiler determines which files go in a CodeMap—and neither does typical consumer of error-message JSON, which is why we fixed this).
This comment has been minimized.
This comment has been minimized.
|
There should also be a compatibility bullet point for the |
kennytm
reviewed
Sep 11, 2017
| Compatibility Notes | ||
| ------------------- | ||
| - [Remove the trait selection impl in method::probe][43880] This may cause | ||
| breakage in subtyping corner cases. |
This comment has been minimized.
This comment has been minimized.
kennytm
Sep 11, 2017
Member
Is there any breakage examples?
BTW "trait selection impl in method::probe" sounds too technical for readers.
This comment has been minimized.
This comment has been minimized.
XAMPPRocky
Sep 11, 2017
Author
Contributor
It definitely is I just couldn't think of anything better. @arielb1 would you know a better explanation and example?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@zackmdavis Could you provide a PR link? I can't seem to find the PR that makes the lint stronger. |
carols10cents
added
the
S-waiting-on-review
label
Sep 11, 2017
alexcrichton
reviewed
Sep 11, 2017
| Misc | ||
| ---- | ||
| - [Cargo docs are moving][43916] | ||
| to [doc.rust-lang.org/cargo](https://doc.rust-lang.org/cargo) |
This comment has been minimized.
This comment has been minimized.
alexcrichton
Sep 11, 2017
Member
We may not want to highlight this just yet as they're still a redirect to doc.crates.io, but soon though!
This comment has been minimized.
This comment has been minimized.
XAMPPRocky
Sep 11, 2017
•
Author
Contributor
I didn't think so either, it was marked as relnotes so I included it.
This comment has been minimized.
This comment has been minimized.
|
Another Cargo change that may be worth mentioning is rust-lang/cargo#4270, a change to the ignore/exclude syntax |
This comment has been minimized.
This comment has been minimized.
|
Also rust-lang/cargo#4400, the addition of the |
This comment has been minimized.
This comment has been minimized.
|
Also rust-lang/cargo#4364, a new compatibility note |
This comment has been minimized.
This comment has been minimized.
|
Speaking of lint changes, I believe |
This comment has been minimized.
This comment has been minimized.
|
@Aaronepower
The change was, somewhat embarrassingly, unintentional in #43728 (removed a |
ollie27
reviewed
Sep 11, 2017
| Libraries | ||
| --------- | ||
| - [Generate builtin impls for `Clone` for `[T; N]` where `N` is between 0 | ||
| and 32][43690] |
This comment has been minimized.
This comment has been minimized.
ollie27
Sep 11, 2017
Contributor
It's more than this. Clone is now implemented for all arrays with T: Clone, all tuples with every member being Clone and all function pointers.
| like patterns][cargo/4270] | ||
| - [Added the `--all-targets` option][cargo/4400] | ||
| - [Using required dependencies as a feature is now deprecated and emits | ||
| a warning][cargo/] |
This comment has been minimized.
This comment has been minimized.
alexcrichton
added
S-waiting-on-author
and removed
S-waiting-on-review
labels
Sep 14, 2017
added some commits
Sep 18, 2017
This comment has been minimized.
This comment has been minimized.
|
gah sorry for letting this sit @Aaronepower! slipped off my radar :( In any case looks great, thanks so much again for tackling this! Let's get this in and we can continue to iterate in-tree @bors: r+ |
This comment has been minimized.
This comment has been minimized.
|
|
arielb1
added
S-waiting-on-bors
and removed
S-waiting-on-author
labels
Sep 19, 2017
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Sep 20, 2017
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
@bors retry Wat. Spurious network error, can't resolve crates.io. |
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Sep 20, 2017
This comment has been minimized.
This comment has been minimized.
|
Adds the RLS! |
added some commits
Sep 20, 2017
This comment has been minimized.
This comment has been minimized.
|
@nrc I've added that, let know if the PR I picked is the wrong one to link. |
kennytm
requested changes
Sep 21, 2017
| Example: | ||
| ```rust | ||
| fn main() { | ||
| let x: &'static u32 = 0; |
This comment has been minimized.
This comment has been minimized.
alexcrichton
added
S-waiting-on-review
and removed
S-waiting-on-bors
labels
Sep 21, 2017
This comment has been minimized.
This comment has been minimized.
|
The docs got a few notable quality-of-life additions. Not sure whether they're all "release notes" worthy, but i'll note them here all the same: |
This comment has been minimized.
This comment has been minimized.
|
I think the "async-llvm" changes from #43506 will be in the next release (right, @alexcrichton?). This feature is pretty neat and it solves a fundamental problem we started running into with incremental compilation: Before, the amount of memory consumed by the LLVM part of compilation was determined by the total size of your crate. After, it is determined by the size of the largest N codegen-units, where N is the number of parallel threads you tell rustc to use. Note that this is something especially important for incr. comp. but the feature helps with any setup that uses Together with @alexcrichton's jobserver changes, this makes using something like |
arielb1
reviewed
Sep 26, 2017
| -------- | ||
| - [Upgraded jemalloc to 4.5.0][43911] | ||
| - [Enabled unwinding panics on Redox][43917] | ||
| - [Now emits a warning when you have an unused `extern crate`][42588] |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Alright the release is just around the corner, so let's merge! @bors: r+ |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Oct 5, 2017
This comment has been minimized.
This comment has been minimized.
|
|
XAMPPRocky commentedSep 10, 2017
•
edited
Rendered