Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated RELEASES.md for 1.21.0 #44481

Merged
merged 8 commits into from Oct 5, 2017

Conversation

@XAMPPRocky
Copy link
Contributor

XAMPPRocky commented Sep 10, 2017

Rendered

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Sep 10, 2017

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

RELEASES.md Outdated

Libraries
---------
- [Generate builtin impls for `Clone` for `[T: N]` where `N` is between 0

This comment has been minimized.

@petrochenkov

petrochenkov Sep 10, 2017

Contributor

typo [T; N]

RELEASES.md Outdated
Language
--------
- [Relaxed path syntax. You can now add type parameters to values][43540]
Example: `struct Foo<T>(T); let bar = Foo::<u8>(0);`.

This comment has been minimized.

@petrochenkov

petrochenkov Sep 10, 2017

Contributor

Foo::<u8>(0) was always possible, what #43540 does is permitting (sometimes unnecessary) :: before < in all paths, including paths passed to macros.
Previously:

my_macro!(Vec<i32>::new); // OK
my_macro!(Vec::<i32>::new); // ERROR

Now:

my_macro!(Vec<i32>::new); // OK
my_macro!(Vec::<i32>::new); // OK too
RELEASES.md Outdated
- [Remove the trait selection impl in method::probe][43880] This may cause
breakage in subtyping corner cases.
- [make JSON error's byte position start at top of file.][42973] Was previously
relative to the `CodeMap` which required unstable code.

This comment has been minimized.

@zackmdavis

zackmdavis Sep 11, 2017

Member

Release note readers shouldn't need to think about named internal implementation details like CodeMap, and I'm not sure where "which required unstable code" is coming from.

Maybe something like "was previously relative to a concatenation of files in a crate"?? (I don't actually know how the compiler determines which files go in a CodeMap—and neither does typical consumer of error-message JSON, which is why we fixed this).

@zackmdavis

This comment has been minimized.

Copy link
Member

zackmdavis commented Sep 11, 2017

There should also be a compatibility bullet point for the unused_results lint getting stronger. "unused_results lint no longer ignores booleans"?

RELEASES.md Outdated
Compatibility Notes
-------------------
- [Remove the trait selection impl in method::probe][43880] This may cause
breakage in subtyping corner cases.

This comment has been minimized.

@kennytm

kennytm Sep 11, 2017

Member

Is there any breakage examples?

BTW "trait selection impl in method::probe" sounds too technical for readers.

This comment has been minimized.

@XAMPPRocky

XAMPPRocky Sep 11, 2017

Author Contributor

It definitely is I just couldn't think of anything better. @arielb1 would you know a better explanation and example?

This comment has been minimized.

@kennytm

kennytm Sep 18, 2017

Member

@Aaronepower: Maybe summarize or just link to #44224 (comment) ?

Aaron Power
@XAMPPRocky

This comment has been minimized.

Copy link
Contributor Author

XAMPPRocky commented Sep 11, 2017

@zackmdavis Could you provide a PR link? I can't seem to find the PR that makes the lint stronger.

@alexcrichton
Copy link
Member

alexcrichton left a comment

Thanks @Aaronepower!

I think this may also want to mention [patch] in Cargo (detailed in RFC 1969)

Misc
----
- [Cargo docs are moving][43916]
to [doc.rust-lang.org/cargo](https://doc.rust-lang.org/cargo)

This comment has been minimized.

@alexcrichton

alexcrichton Sep 11, 2017

Member

We may not want to highlight this just yet as they're still a redirect to doc.crates.io, but soon though!

This comment has been minimized.

@XAMPPRocky

XAMPPRocky Sep 11, 2017

Author Contributor

I didn't think so either, it was marked as relnotes so I included it.

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Sep 11, 2017

Another Cargo change that may be worth mentioning is rust-lang/cargo#4270, a change to the ignore/exclude syntax

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Sep 11, 2017

Also rust-lang/cargo#4400, the addition of the --all-targets flag

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Sep 11, 2017

Also rust-lang/cargo#4364, a new compatibility note

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Sep 11, 2017

Speaking of lint changes, I believe unused_extern_crate was turned on by default in #42588

Aaron Power
@zackmdavis

This comment has been minimized.

Copy link
Member

zackmdavis commented Sep 11, 2017

@Aaronepower

Could you provide a PR link? I can't seem to find the PR that makes the lint stronger.

The change was, somewhat embarrassingly, unintentional in #43728 (removed a TyBool => return match arm without realizing that this would let us "fall through" to the part of the lint-pass that sets unused_results), but then the discussion and final-comment-period in #44119 retroactively ruled it a bugfix rather than a regression.

@ollie27
Copy link
Contributor

ollie27 left a comment

Looks like #43838 is missing.

RELEASES.md Outdated
Libraries
---------
- [Generate builtin impls for `Clone` for `[T; N]` where `N` is between 0
and 32][43690]

This comment has been minimized.

@ollie27

ollie27 Sep 11, 2017

Contributor

It's more than this. Clone is now implemented for all arrays with T: Clone, all tuples with every member being Clone and all function pointers.

RELEASES.md Outdated
like patterns][cargo/4270]
- [Added the `--all-targets` option][cargo/4400]
- [Using required dependencies as a feature is now deprecated and emits
a warning][cargo/]

This comment has been minimized.

@ollie27

ollie27 Sep 11, 2017

Contributor

missing link

Aaron Power added some commits Sep 18, 2017

Aaron Power
Aaron Power
@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Sep 19, 2017

gah sorry for letting this sit @Aaronepower! slipped off my radar :(

In any case looks great, thanks so much again for tackling this! Let's get this in and we can continue to iterate in-tree

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Sep 19, 2017

📌 Commit f3c316d has been approved by alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Sep 20, 2017

⌛️ Testing commit f3c316d with merge 547d8a3...

bors added a commit that referenced this pull request Sep 20, 2017

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Sep 20, 2017

💔 Test failed - status-appveyor

@kennytm

This comment has been minimized.

Copy link
Member

kennytm commented Sep 20, 2017

@bors retry Wat.

Spurious network error, can't resolve crates.io.

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Sep 20, 2017

⌛️ Testing commit f3c316d with merge 65e8d5a...

bors added a commit that referenced this pull request Sep 20, 2017

@nrc

This comment has been minimized.

Copy link
Member

nrc commented Sep 20, 2017

Adds the RLS! rustup component add rls-preview

Aaron Power added some commits Sep 20, 2017

Aaron Power
Aaron Power
@XAMPPRocky

This comment has been minimized.

Copy link
Contributor Author

XAMPPRocky commented Sep 20, 2017

@nrc I've added that, let know if the PR I picked is the wrong one to link.

RELEASES.md Outdated
Example:
```rust
fn main() {
let x: &'static u32 = 0;

This comment has been minimized.

@kennytm

kennytm Sep 21, 2017

Member

This should be &0, not 0.

@dtolnay

This comment has been minimized.

Copy link
Member

dtolnay commented Sep 21, 2017

We are stabilizing std::mem::discriminant in 1.21. #44263, #44552

We could backport any of the following library stabilizations -- I'm not clear how we decide whether to do that.

@QuietMisdreavus

This comment has been minimized.

Copy link
Member

QuietMisdreavus commented Sep 21, 2017

The docs got a few notable quality-of-life additions. Not sure whether they're all "release notes" worthy, but i'll note them here all the same:

@michaelwoerister

This comment has been minimized.

Copy link
Contributor

michaelwoerister commented Sep 23, 2017

I think the "async-llvm" changes from #43506 will be in the next release (right, @alexcrichton?). This feature is pretty neat and it solves a fundamental problem we started running into with incremental compilation: Before, the amount of memory consumed by the LLVM part of compilation was determined by the total size of your crate. After, it is determined by the size of the largest N codegen-units, where N is the number of parallel threads you tell rustc to use. Note that this is something especially important for incr. comp. but the feature helps with any setup that uses codegen-units=N.

Together with @alexcrichton's jobserver changes, this makes using something like codegen-units= 2 * cpu-core-count much more viable, if runtime performance is not the highest priority (e.g. most kinds of development builds).

RELEASES.md Outdated
--------
- [Upgraded jemalloc to 4.5.0][43911]
- [Enabled unwinding panics on Redox][43917]
- [Now emits a warning when you have an unused `extern crate`][42588]

This comment has been minimized.

@arielb1

arielb1 Sep 26, 2017

Contributor

This is being backed out (#44825)

Aaron Power
@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Oct 5, 2017

Alright the release is just around the corner, so let's merge!

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 5, 2017

📌 Commit 7ed23f1 has been approved by alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 5, 2017

⌛️ Testing commit 7ed23f1 with merge bd36dcf...

bors added a commit that referenced this pull request Oct 5, 2017

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 5, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing bd36dcf to master...

@bors bors merged commit 7ed23f1 into rust-lang:master Oct 5, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.