Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stabilize tcpstream_connect_timeout (closes #43079) #44563

Merged
merged 1 commit into from Sep 15, 2017

Conversation

Reviewers
No reviews
Assignees

@BurntSushi BurntSushi

Labels
beta-accepted relnotes
Projects
None yet
Milestone
No milestone
6 participants
@budziq @rust-highfive @alexcrichton @bors @BurntSushi @dtolnay
@budziq
Copy link
Contributor

budziq commented Sep 14, 2017

No description provided.

@rust-highfive rust-highfive assigned BurntSushi Sep 14, 2017

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Sep 14, 2017

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BurntSushi (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@budziq budziq force-pushed the budziq:stablilize_tcpstream_connect_timeout branch from 92bd686 to 199cb82 Sep 14, 2017

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Sep 14, 2017

@bors: r+ rollup

Thanks @budziq!
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Sep 14, 2017

📌 Commit 199cb82 has been approved by alexcrichton

@alexcrichton alexcrichton added the S-waiting-on-bors label Sep 14, 2017

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Sep 15, 2017

@frewsxcv
Rollup merge of rust-lang#44563 - budziq:stablilize_tcpstream_connect… 
…_timeout, r=alexcrichton

stabilize tcpstream_connect_timeout (closes rust-lang#43079)
4af8acd

@frewsxcv frewsxcv referenced this pull request Sep 15, 2017

Merged

Rollup of 23 pull requests #44585

bors added a commit that referenced this pull request Sep 15, 2017

@bors
Auto merge of #44585 - frewsxcv:rollup, r=frewsxcv 
Rollup of 23 pull requests

- Successful merges: #44131, #44254, #44368, #44374, #44378, #44388, #44430, #44450, #44453, #44472, #44476, #44477, #44485, #44497, #44521, #44534, #44536, #44541, #44552, #44559, #44563, #44569, #44572
- Failed merges:
Loading status checks…
d86a7f7

@bors bors merged commit 199cb82 into rust-lang:master Sep 15, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alexcrichton alexcrichton added the relnotes label Sep 15, 2017

@budziq budziq deleted the budziq:stablilize_tcpstream_connect_timeout branch Sep 17, 2017

@dtolnay dtolnay referenced this pull request Sep 21, 2017

Merged

Updated RELEASES.md for 1.21.0 #44481

@dtolnay dtolnay added beta-accepted and removed S-waiting-on-bors labels Sep 21, 2017

dtolnay added a commit to dtolnay/rust that referenced this pull request Sep 25, 2017

@dtolnay
Backport libs stabilizations to 1.21 beta 
This includes the following stabilizations:

- tcpstream_connect_timeout rust-lang#44563
- iterator_for_each rust-lang#44567
- ord_max_min rust-lang#44593
- compiler_fences rust-lang#44595
- needs_drop rust-lang#44639
- vec_splice rust-lang#44640
Verified
This commit was signed with a verified signature.
@dtolnay dtolnay David Tolnay
GPG key ID: F9BA143B95FF6D82 Learn about signing commits
5f502de

dtolnay added a commit to dtolnay/rust that referenced this pull request Sep 25, 2017

@dtolnay
Backport libs stabilizations to 1.21 beta 
This includes the following stabilizations:

- tcpstream_connect_timeout rust-lang#44563
- iterator_for_each rust-lang#44567
- ord_max_min rust-lang#44593
- compiler_fences rust-lang#44595
- needs_drop rust-lang#44639
- vec_splice rust-lang#44640
Verified
This commit was signed with a verified signature.
@dtolnay dtolnay David Tolnay
GPG key ID: F9BA143B95FF6D82 Learn about signing commits
874124b

This was referenced Sep 25, 2017

Merged
Closed

dtolnay added a commit to dtolnay/rust that referenced this pull request Sep 26, 2017

@dtolnay
Backport libs stabilizations to 1.21 beta 
This includes the following stabilizations:

- tcpstream_connect_timeout rust-lang#44563
- iterator_for_each rust-lang#44567
- ord_max_min rust-lang#44593
- compiler_fences rust-lang#44595
- needs_drop rust-lang#44639
- vec_splice rust-lang#44640
Verified
This commit was signed with a verified signature.
@dtolnay dtolnay David Tolnay
GPG key ID: F9BA143B95FF6D82 Learn about signing commits
a8117df

bors added a commit that referenced this pull request Sep 26, 2017

@bors
Auto merge of #44823 - dtolnay:backport21, r=alexcrichton 
[beta] Backport accepted PRs to 1.21

Backport of:

- ~don't suggest placing `use` statements into expanded code #44215
- stabilize tcpstream_connect_timeout #44563
- stabilized iterator_for_each #44567
- travis: Move sccache to the us-west-1 region #44574
- stabilized ord_max_min #44593
- stabilized compiler_fences #44595
- ci: Upload/download from a new S3 bucket #44617
- stabilized needs_drop #44639
- Stabilized vec_splice and modified splice tracking issue #44640
- Backport libs stabilizations to 1.21 beta #44824
Loading status checks…
3c3cd3f

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 29, 2017

@Mark-Simulacrum
Rollup merge of rust-lang#44824 - dtolnay:22really21, r=alexcrichton 
Backport libs stabilizations to 1.21 beta

Includes the following stabilizations:

- tcpstream_connect_timeout rust-lang#44563
- iterator_for_each rust-lang#44567
- ord_max_min rust-lang#44593
- compiler_fences rust-lang#44595
- needs_drop rust-lang#44639
- vec_splice rust-lang#44640

These have been backported in rust-lang#44823.
570f1ce

@dtolnay dtolnay referenced this pull request Oct 10, 2017

Merged

1.21 announcement #203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.