Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stabilized iterator_for_each (closes #42986) #44567

Merged
merged 1 commit into from Sep 17, 2017

Conversation

Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
beta-accepted relnotes
Projects
None yet
Milestone
No milestone
7 participants
@budziq @kennytm @cuviper @alexcrichton @oli-obk @bors @dtolnay
@budziq
Copy link
Contributor

budziq commented Sep 14, 2017

Also updated clippy and rls as these use the iterator_for_each

I've made my first PR's today so most likely I've done something wrong. Sorry about that!

@budziq budziq force-pushed the budziq:stabilize_iterator_for_each branch from 61b8dff to d94dab7 Sep 14, 2017

@kennytm

This comment has been minimized.

Sign in to view
Copy link
Member

kennytm commented Sep 14, 2017

Failed to start the CI. Please update src/Cargo.lock.

[00:00:49] error: the lock file needs to be updated but --frozen was passed to prevent this
@cuviper

This comment has been minimized.

Sign in to view
Copy link
Member

cuviper commented Sep 14, 2017

This needs to wait for completed FCP, right?
@kennytm

This comment has been minimized.

Sign in to view
Copy link
Member

kennytm commented Sep 14, 2017

@cuviper according to https://internals.rust-lang.org/t/stabilizing-apis-in-the-standard-library/5906, it is ready once all team member checked their boxes, there's no need to wait for the FCP to end.

once all libs members have checked their checkboxes the issue is tagged with final-comment-period meaning it’s ready for stabilization.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Sep 14, 2017

Looks great to me, thanks @budziq! Looks like some stray submodule updates were included though?

@cuviper yeah for APIs we don't wait for the FCP to end, we just go ahead and throw them in once the team has signed off.

@alexcrichton alexcrichton self-assigned this Sep 14, 2017

@alexcrichton alexcrichton added the S-waiting-on-author label Sep 14, 2017

@budziq budziq referenced this pull request Sep 15, 2017

Closed

stabilizing feature iterator_for_each for rust 1.22.0 #2051

@budziq budziq force-pushed the budziq:stabilize_iterator_for_each branch from d94dab7 to b0655b1 Sep 15, 2017

@budziq

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

budziq commented Sep 15, 2017

Failed to start the CI. Please update src/Cargo.lock.

@kennytm Updated with Cargo.lock. Sorry about that!

Looks like some stray submodule updates were included though?

@alexcrichton The submodule updates were intentional due to rls and clipy depending on iterator_for_each. I've made PR's to their respective repos (rls, clippy) and updated the submodules to the PR commits according to this section in CONTRIBUTING.md

I might have misunderstood the instructions so I will be glad to fix any problems!
@oli-obk

This comment has been minimized.

Sign in to view
Copy link
Contributor

oli-obk commented Sep 15, 2017 •
edited

I might have misunderstood the instructions so I will be glad to fix any problems!

You're the first person to follow said instructions. Thanks!

If any problems show up with the process it's with the instructions and not you ;) Travis seems to like it so far.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Sep 15, 2017

@bors: r+

Ah ok, thanks!
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Sep 15, 2017

📌 Commit b0655b1 has been approved by alexcrichton
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Sep 15, 2017

@bors: r-

Er actually, we prefer that our submodules are attached to long-lived commits which are at least somewhat relatively guaranteed to stick around into the future. In that sense the section of the contributing docs is wrong I believe in that we don't want to pin our submodules to PRs.

Does stabilization here cause build failures? If not can the submodule updates happen later on the master branch?
@budziq

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

budziq commented Sep 15, 2017

Does stabilization here cause build failures?

The stabilization will cause build failure for rls and test failure in clippy. I believe that we have a chicken and egg problem here and the stabilization and submodule PR's should proceed in lockstep (submodules first to generate a long lived commit and shortly then the lang repo). But this is is actually a question to the maintainers 😄.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Sep 15, 2017

You can ignore clippy for now as we're not building it anyway, but for the rls we'll need to make a long-lived branch, which you can coordinate with @nrc for that

@budziq budziq force-pushed the budziq:stabilize_iterator_for_each branch from b0655b1 to 8772227 Sep 15, 2017

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Sep 15, 2017

@nrc can you make a branch of the RLS for this?
@budziq

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

budziq commented Sep 15, 2017

@alexcrichton The PR is already on a branch
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Sep 15, 2017

@bors: r+

Aha, great!
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Sep 15, 2017

📌 Commit 8772227 has been approved by alexcrichton
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Sep 16, 2017

@bors: rollup

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Sep 16, 2017

@alexcrichton
Rollup merge of rust-lang#44567 - budziq:stabilize_iterator_for_each,… 
… r=alexcrichton

stabilized iterator_for_each (closes rust-lang#42986)

Also updated clippy and rls as these use the iterator_for_each

I've made my first PR's today so most likely I've done something wrong. Sorry about that!
Loading status checks…
9da941f

@alexcrichton alexcrichton referenced this pull request Sep 16, 2017

Closed

Rollup of 27 pull requests #44621

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Sep 16, 2017

@frewsxcv
Rollup merge of rust-lang#44567 - budziq:stabilize_iterator_for_each,… 
… r=alexcrichton

stabilized iterator_for_each (closes rust-lang#42986)

Also updated clippy and rls as these use the iterator_for_each

I've made my first PR's today so most likely I've done something wrong. Sorry about that!
20ae064

@frewsxcv frewsxcv referenced this pull request Sep 16, 2017

Closed

Rollup of 25 pull requests #44623

bors added a commit that referenced this pull request Sep 16, 2017

@bors
Auto merge of #44621 - alexcrichton:rollup, r=alexcrichton 
Rollup of 27 pull requests

- Successful merges: #43964, #43989, #44273, #44356, #44395, #44397, #44515, #44531, #44542, #44549, #44560, #44562, #44567, #44574, #44577, #44586, #44589, #44590, #44593, #44598, #44603, #44604, #44605, #44606, #44609, #44610, #44616
- Failed merges: #44537
Loading status checks…
1f3526e

bors added a commit that referenced this pull request Sep 16, 2017

@bors
Auto merge of #44621 - alexcrichton:rollup, r=alexcrichton 
Rollup of 27 pull requests

- Successful merges: #43964, #43989, #44273, #44356, #44395, #44397, #44515, #44531, #44542, #44549, #44560, #44562, #44567, #44574, #44577, #44586, #44589, #44590, #44593, #44598, #44603, #44604, #44605, #44606, #44609, #44610, #44616
- Failed merges: #44537
Loading status checks…
fd30475

bors added a commit that referenced this pull request Sep 16, 2017

@bors
Auto merge of #44621 - alexcrichton:rollup, r=alexcrichton 
Rollup of 27 pull requests

- Successful merges: #43964, #43989, #44273, #44356, #44395, #44397, #44515, #44531, #44542, #44549, #44560, #44562, #44567, #44574, #44577, #44586, #44589, #44590, #44593, #44598, #44603, #44604, #44605, #44606, #44609, #44610, #44616
- Failed merges: #44537
Loading status checks…
5cd8902

bors added a commit that referenced this pull request Sep 16, 2017

@bors
Auto merge of #44623 - frewsxcv:rollup, r=frewsxcv 
Rollup of 25 pull requests

- Successful merges: #44273, #44356, #44395, #44397, #44515, #44531, #44537, #44542, #44549, #44560, #44562, #44567, #44574, #44577, #44586, #44589, #44590, #44593, #44598, #44603, #44604, #44606, #44609, #44616, #44622
- Failed merges:
Loading status checks…
d4dfec1

@budziq budziq force-pushed the budziq:stabilize_iterator_for_each branch from 8772227 to b715290 Sep 16, 2017

@budziq

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

budziq commented Sep 16, 2017

Rebased!
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Sep 16, 2017

@bors: r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Sep 16, 2017

📌 Commit b715290 has been approved by alexcrichton

bors added a commit that referenced this pull request Sep 17, 2017

@bors
Auto merge of #44634 - alexcrichton:rollup, r=alexcrichton 
Rollup of 19 pull requests

- Successful merges: #44273, #44356, #44395, #44531, #44537, #44542, #44560, #44567, #44574, #44577, #44586, #44589, #44590, #44593, #44598, #44606, #44609, #44616, #44631
- Failed merges:
Loading status checks…
71e3767

TimNN added a commit to TimNN/rust that referenced this pull request Sep 17, 2017

@TimNN
Rollup merge of rust-lang#44567 - budziq:stabilize_iterator_for_each,… 
… r=alexcrichton

stabilized iterator_for_each (closes rust-lang#42986)

Also updated clippy and rls as these use the iterator_for_each

I've made my first PR's today so most likely I've done something wrong. Sorry about that!
a0920b8

@TimNN TimNN referenced this pull request Sep 17, 2017

Closed

Rollup of 19 pull requests #44649

bors added a commit that referenced this pull request Sep 17, 2017

@bors
Auto merge of #44649 - TimNN:rollup, r=TimNN 
Rollup of 19 pull requests

- Successful merges: #44073, #44088, #44381, #44397, #44509, #44515, #44533, #44549, #44553, #44562, #44567, #44573, #44595, #44604, #44617, #44622, #44630, #44639, #44647
- Failed merges:
Loading status checks…
d8e81f8

TimNN added a commit to TimNN/rust that referenced this pull request Sep 17, 2017

@TimNN
Rollup merge of rust-lang#44567 - budziq:stabilize_iterator_for_each,… 
… r=alexcrichton

stabilized iterator_for_each (closes rust-lang#42986)

Also updated clippy and rls as these use the iterator_for_each

I've made my first PR's today so most likely I've done something wrong. Sorry about that!
640dcef

@TimNN TimNN referenced this pull request Sep 17, 2017

Closed

Rollup of 18 pull requests #44652

bors added a commit that referenced this pull request Sep 17, 2017

@bors
Auto merge of #44652 - TimNN:rollup, r=TimNN 
Rollup of 18 pull requests

- Successful merges: #44073, #44088, #44381, #44397, #44509, #44515, #44533, #44549, #44553, #44562, #44567, #44595, #44604, #44617, #44622, #44630, #44639, #44647
- Failed merges:
Loading status checks…
7647759

TimNN added a commit to TimNN/rust that referenced this pull request Sep 17, 2017

@TimNN
Rollup merge of rust-lang#44567 - budziq:stabilize_iterator_for_each,… 
… r=alexcrichton

stabilized iterator_for_each (closes rust-lang#42986)

Also updated clippy and rls as these use the iterator_for_each

I've made my first PR's today so most likely I've done something wrong. Sorry about that!
1437e53

@TimNN TimNN referenced this pull request Sep 17, 2017

Merged

Rollup of 17 pull requests #44654

bors added a commit that referenced this pull request Sep 17, 2017

@bors
Auto merge of #44654 - TimNN:rollup, r=TimNN 
Rollup of 17 pull requests

- Successful merges: #44073, #44088, #44381, #44397, #44509, #44533, #44549, #44553, #44562, #44567, #44595, #44604, #44617, #44622, #44630, #44639, #44647
- Failed merges:
Loading status checks…
1cdd689

@bors bors merged commit b715290 into rust-lang:master Sep 17, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@budziq budziq deleted the budziq:stabilize_iterator_for_each branch Sep 17, 2017

@budziq budziq referenced this pull request Sep 17, 2017

Merged

Corrected the CONTRIBUTING.md "External Dependencies" section #44664

@dtolnay dtolnay added relnotes and removed S-waiting-on-author labels Sep 21, 2017

@dtolnay dtolnay referenced this pull request Sep 21, 2017

Merged

Updated RELEASES.md for 1.21.0 #44481

@dtolnay dtolnay added the beta-accepted label Sep 21, 2017

dtolnay added a commit to dtolnay/rust that referenced this pull request Sep 25, 2017

@dtolnay
Backport libs stabilizations to 1.21 beta 
This includes the following stabilizations:

- tcpstream_connect_timeout rust-lang#44563
- iterator_for_each rust-lang#44567
- ord_max_min rust-lang#44593
- compiler_fences rust-lang#44595
- needs_drop rust-lang#44639
- vec_splice rust-lang#44640
Verified
This commit was signed with a verified signature.
@dtolnay dtolnay David Tolnay
GPG key ID: F9BA143B95FF6D82 Learn about signing commits
5f502de

dtolnay added a commit to dtolnay/rust that referenced this pull request Sep 25, 2017

@dtolnay
Backport libs stabilizations to 1.21 beta 
This includes the following stabilizations:

- tcpstream_connect_timeout rust-lang#44563
- iterator_for_each rust-lang#44567
- ord_max_min rust-lang#44593
- compiler_fences rust-lang#44595
- needs_drop rust-lang#44639
- vec_splice rust-lang#44640
Verified
This commit was signed with a verified signature.
@dtolnay dtolnay David Tolnay
GPG key ID: F9BA143B95FF6D82 Learn about signing commits
874124b

This was referenced Sep 25, 2017

Merged
Closed

dtolnay added a commit to dtolnay/rust that referenced this pull request Sep 26, 2017

@dtolnay
Backport libs stabilizations to 1.21 beta 
This includes the following stabilizations:

- tcpstream_connect_timeout rust-lang#44563
- iterator_for_each rust-lang#44567
- ord_max_min rust-lang#44593
- compiler_fences rust-lang#44595
- needs_drop rust-lang#44639
- vec_splice rust-lang#44640
Verified
This commit was signed with a verified signature.
@dtolnay dtolnay David Tolnay
GPG key ID: F9BA143B95FF6D82 Learn about signing commits
a8117df

bors added a commit that referenced this pull request Sep 26, 2017

@bors
Auto merge of #44823 - dtolnay:backport21, r=alexcrichton 
[beta] Backport accepted PRs to 1.21

Backport of:

- ~don't suggest placing `use` statements into expanded code #44215
- stabilize tcpstream_connect_timeout #44563
- stabilized iterator_for_each #44567
- travis: Move sccache to the us-west-1 region #44574
- stabilized ord_max_min #44593
- stabilized compiler_fences #44595
- ci: Upload/download from a new S3 bucket #44617
- stabilized needs_drop #44639
- Stabilized vec_splice and modified splice tracking issue #44640
- Backport libs stabilizations to 1.21 beta #44824
Loading status checks…
3c3cd3f

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 29, 2017

@Mark-Simulacrum
Rollup merge of rust-lang#44824 - dtolnay:22really21, r=alexcrichton 
Backport libs stabilizations to 1.21 beta

Includes the following stabilizations:

- tcpstream_connect_timeout rust-lang#44563
- iterator_for_each rust-lang#44567
- ord_max_min rust-lang#44593
- compiler_fences rust-lang#44595
- needs_drop rust-lang#44639
- vec_splice rust-lang#44640

These have been backported in rust-lang#44823.
570f1ce

kennytm added a commit to kennytm/rust that referenced this pull request Oct 5, 2017

@kennytm
Rollup merge of rust-lang#44664 - budziq:contributing_external, r=ste… 
…veklabnik

Corrected the CONTRIBUTING.md "External Dependencies" section

The "External Dependencies" section is a little outdated.
Please see following comments rust-lang#44567 (comment) rust-lang#44567 (comment) for rationale.
b34ade0

@dtolnay dtolnay referenced this pull request Oct 10, 2017

Merged

1.21 announcement #203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.