Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upMake use of Travis's conditional jobs. #44631
Conversation
This comment has been minimized.
This comment has been minimized.
|
@bors try Let me verify if the try build works before merging. |
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Sep 16, 2017
kennytm
changed the title
[DO NOT MERGE] Make use of Travis's conditional jobs.
Make use of Travis's conditional jobs.
Sep 16, 2017
This comment has been minimized.
This comment has been minimized.
|
OK try build works (?). The remaining thing is to ensure all 41 jobs are running during the actual test. EDIT: Not sure if relevant, but the try build failed to download the cache archive, causing 45 minutes spent on building docker. Maybe just due to removing the
|
This comment has been minimized.
This comment has been minimized.
|
r=me, but I want to run this past you as well. cc @rust-lang/infra as well. |
Mark-Simulacrum
assigned
alexcrichton
Sep 16, 2017
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
That seems to be the case, see https://docs.travis-ci.com/user/caching/#Caches-and-build-matrices |
This comment has been minimized.
This comment has been minimized.
|
@bors: r+ Nice find! |
This comment has been minimized.
This comment has been minimized.
|
|
kennytm commentedSep 16, 2017
Conditional jobs: https://docs.travis-ci.com/user/conditional-builds-stages-jobs/#Conditional-Jobs.
Jobs not matching the condition will not be scheduled at all. This allows us to get rid of
$ALLOW_PR/$ALLOW_TRY/$SKIP_BUILDin.travis.yml, and perfectly prevent spurious PR failures due to flaky macOS machines.