Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stabilized needs_drop (fixes #41890) #44639

Merged
merged 1 commit into from Sep 17, 2017

Conversation

Reviewers

@oherrala oherrala

@kennytm kennytm

Assignees

@dtolnay dtolnay

Labels
beta-accepted relnotes
Projects
None yet
Milestone
No milestone
7 participants
@budziq @rust-highfive @dtolnay @bors @oherrala @kennytm @BurntSushi
@budziq
Copy link
Contributor

budziq commented Sep 16, 2017 •
edited

fixes #41890

@rust-highfive rust-highfive assigned BurntSushi Sep 16, 2017

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Sep 16, 2017

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BurntSushi (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.
@dtolnay

This comment has been minimized.

Sign in to view
Copy link
Member

dtolnay commented Sep 17, 2017

@bors r+ rollup
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Sep 17, 2017

📌 Commit 0485595 has been approved by dtolnay

@dtolnay dtolnay assigned dtolnay and unassigned BurntSushi Sep 17, 2017

TimNN added a commit to TimNN/rust that referenced this pull request Sep 17, 2017

@TimNN
Rollup merge of rust-lang#44639 - budziq:stabilize_needs_drop, r=dtolnay 
stabilized needs_drop (fixes rust-lang#41890)

fixes rust-lang#41890
dfbf8e3

@TimNN TimNN referenced this pull request Sep 17, 2017

Closed

Rollup of 19 pull requests #44649

bors added a commit that referenced this pull request Sep 17, 2017

@bors
Auto merge of #44649 - TimNN:rollup, r=TimNN 
Rollup of 19 pull requests

- Successful merges: #44073, #44088, #44381, #44397, #44509, #44515, #44533, #44549, #44553, #44562, #44567, #44573, #44595, #44604, #44617, #44622, #44630, #44639, #44647
- Failed merges:
Loading status checks…
d8e81f8

TimNN added a commit to TimNN/rust that referenced this pull request Sep 17, 2017

@TimNN
Rollup merge of rust-lang#44639 - budziq:stabilize_needs_drop, r=dtolnay 
stabilized needs_drop (fixes rust-lang#41890)

fixes rust-lang#41890
7019666

@TimNN TimNN referenced this pull request Sep 17, 2017

Closed

Rollup of 18 pull requests #44652

bors added a commit that referenced this pull request Sep 17, 2017

@bors
Auto merge of #44652 - TimNN:rollup, r=TimNN 
Rollup of 18 pull requests

- Successful merges: #44073, #44088, #44381, #44397, #44509, #44515, #44533, #44549, #44553, #44562, #44567, #44595, #44604, #44617, #44622, #44630, #44639, #44647
- Failed merges:
Loading status checks…
7647759

TimNN added a commit to TimNN/rust that referenced this pull request Sep 17, 2017

@TimNN
Rollup merge of rust-lang#44639 - budziq:stabilize_needs_drop, r=dtolnay 
stabilized needs_drop (fixes rust-lang#41890)

fixes rust-lang#41890
d046421

@TimNN TimNN referenced this pull request Sep 17, 2017

Merged

Rollup of 17 pull requests #44654

bors added a commit that referenced this pull request Sep 17, 2017

@bors
Auto merge of #44654 - TimNN:rollup, r=TimNN 
Rollup of 17 pull requests

- Successful merges: #44073, #44088, #44381, #44397, #44509, #44533, #44549, #44553, #44562, #44567, #44595, #44604, #44617, #44622, #44630, #44639, #44647
- Failed merges:
Loading status checks…
1cdd689

@bors bors merged commit 0485595 into rust-lang:master Sep 17, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@budziq budziq deleted the budziq:stabilize_needs_drop branch Sep 17, 2017

@dtolnay dtolnay added the relnotes label Sep 21, 2017

@dtolnay dtolnay referenced this pull request Sep 21, 2017

Merged

Updated RELEASES.md for 1.21.0 #44481

@dtolnay dtolnay added the beta-accepted label Sep 21, 2017

dtolnay added a commit to dtolnay/rust that referenced this pull request Sep 25, 2017

@dtolnay
Backport libs stabilizations to 1.21 beta 
This includes the following stabilizations:

- tcpstream_connect_timeout rust-lang#44563
- iterator_for_each rust-lang#44567
- ord_max_min rust-lang#44593
- compiler_fences rust-lang#44595
- needs_drop rust-lang#44639
- vec_splice rust-lang#44640
Verified
This commit was signed with a verified signature.
@dtolnay dtolnay David Tolnay
GPG key ID: F9BA143B95FF6D82 Learn about signing commits
5f502de

dtolnay added a commit to dtolnay/rust that referenced this pull request Sep 25, 2017

@dtolnay
Backport libs stabilizations to 1.21 beta 
This includes the following stabilizations:

- tcpstream_connect_timeout rust-lang#44563
- iterator_for_each rust-lang#44567
- ord_max_min rust-lang#44593
- compiler_fences rust-lang#44595
- needs_drop rust-lang#44639
- vec_splice rust-lang#44640
Verified
This commit was signed with a verified signature.
@dtolnay dtolnay David Tolnay
GPG key ID: F9BA143B95FF6D82 Learn about signing commits
874124b

This was referenced Sep 25, 2017

Merged
Closed

dtolnay added a commit to dtolnay/rust that referenced this pull request Sep 26, 2017

@dtolnay
Backport libs stabilizations to 1.21 beta 
This includes the following stabilizations:

- tcpstream_connect_timeout rust-lang#44563
- iterator_for_each rust-lang#44567
- ord_max_min rust-lang#44593
- compiler_fences rust-lang#44595
- needs_drop rust-lang#44639
- vec_splice rust-lang#44640
Verified
This commit was signed with a verified signature.
@dtolnay dtolnay David Tolnay
GPG key ID: F9BA143B95FF6D82 Learn about signing commits
a8117df

bors added a commit that referenced this pull request Sep 26, 2017

@bors
Auto merge of #44823 - dtolnay:backport21, r=alexcrichton 
[beta] Backport accepted PRs to 1.21

Backport of:

- ~don't suggest placing `use` statements into expanded code #44215
- stabilize tcpstream_connect_timeout #44563
- stabilized iterator_for_each #44567
- travis: Move sccache to the us-west-1 region #44574
- stabilized ord_max_min #44593
- stabilized compiler_fences #44595
- ci: Upload/download from a new S3 bucket #44617
- stabilized needs_drop #44639
- Stabilized vec_splice and modified splice tracking issue #44640
- Backport libs stabilizations to 1.21 beta #44824
Loading status checks…
3c3cd3f

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 29, 2017

@Mark-Simulacrum
Rollup merge of rust-lang#44824 - dtolnay:22really21, r=alexcrichton 
Backport libs stabilizations to 1.21 beta

Includes the following stabilizations:

- tcpstream_connect_timeout rust-lang#44563
- iterator_for_each rust-lang#44567
- ord_max_min rust-lang#44593
- compiler_fences rust-lang#44595
- needs_drop rust-lang#44639
- vec_splice rust-lang#44640

These have been backported in rust-lang#44823.
570f1ce

@dtolnay dtolnay referenced this pull request Oct 10, 2017

Merged

1.21 announcement #203

@oherrala

oherrala reviewed Oct 13, 2017
View changes

src/libcore/mem.rs
@@ -359,7 +358,7 @@ pub fn align_of_val<T: ?Sized>(val: &T) -> usize {
/// }
/// ```
#[inline]
#[unstable(feature = "needs_drop", issue = "41890")]
#[stable(feature = "needs_drop", since = "1.22.0")]

This comment has been minimized.

Sign in to view
Copy link
@oherrala

oherrala Oct 13, 2017

If this was released with Rust 1.21, is the since field wrong?

This comment has been minimized.

Sign in to view
Copy link
@kennytm

kennytm Oct 13, 2017 •
edited

Member

@oherrala The versions have been fixed in 874124b 🙂

This comment has been minimized.

Sign in to view
Copy link
@oherrala

oherrala Oct 13, 2017

@kennytm, ah, cool. Sorry about the noise.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.