Stabilized vec_splice and modified splice tracking issue

[budziq]

This stabilizes the vec_splice (Vec part of splice RFC)
Fixes #32310.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BurntSushi (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[dtolnay]

Sorry it isn't clear from the tracking issue -- but when the libs team discussed stabilizing Vec::splice and String::splice, we decided to stabilize Vec::splice but try a new signature for String::splice and keep it unstable. I left a comment on the tracking issue just now to clarify this.

Please keep the unstable attribute on String::splice for now and change its tracking issue number to point to #44643. Since we are stabilizing one but not the other, they will need to have different feature names. We can minimize breakage by changing Vec::splice to be under the now-stable feature vec_splice and keeping String::splice under feature(splice).

#[stable(feature = "vec_splice", since = "1.22.0")]

#[unstable(feature = "splice", reason = "...", issue = "44643")]

Thanks!

[dtolnay]

Sorry it isn't clear from the tracking issue -- but when the libs team discussed stabilizing Vec::splice and String::splice, we decided to stabilize Vec::splice but try a new signature for String::splice and keep it unstable. I left a comment on the tracking issue just now to clarify this.

Please keep the unstable attribute on String::splice for now and change its tracking issue number to point to #44643. Since we are stabilizing one but not the other, they will need to have different feature names. We can minimize breakage by changing Vec::splice to be under the now-stable feature vec_splice and keeping String::splice under feature(splice).

#[stable(feature = "vec_splice", since = "1.22.0")]

#[unstable(feature = "splice", reason = "...", issue = "44643")]

Thanks!

[budziq]

Thanks for the heads-up! I'll do it later today.

[budziq]

@dtolnay Done!

[dtolnay]

@bors r+ rollup

[bors]

📌 Commit 6b167f9 has been approved by dtolnay