Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIR-borrowck: Adding notes to E0503 #44749

Merged
merged 4 commits into from Sep 23, 2017

Conversation

Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
5 participants
@zilbuz @rust-highfive @eddyb @pnkfelix @bors
@zilbuz
Copy link
Contributor

zilbuz commented Sep 21, 2017

This PR adds notes to the MIR borrowck error E0503.

Part of #44596

@rust-highfive rust-highfive assigned eddyb Sep 21, 2017

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Sep 21, 2017

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.
@eddyb

This comment has been minimized.

Sign in to view
Copy link
Member

eddyb commented Sep 21, 2017

r? @pnkfelix

@rust-highfive rust-highfive assigned pnkfelix and unassigned eddyb Sep 21, 2017

@pnkfelix

This comment has been minimized.

Sign in to view
Copy link
Member

pnkfelix commented Sep 22, 2017

@bors r+ rollup
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Sep 22, 2017

📌 Commit 8c1b958 has been approved by pnkfelix

@pnkfelix pnkfelix added the S-waiting-on-bors label Sep 22, 2017

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Sep 23, 2017

@frewsxcv
Rollup merge of rust-lang#44749 - zilbuz:issue-44596/E0503, r=pnkfelix 
MIR-borrowck: Adding notes to E0503

This PR adds notes to the MIR borrowck error E0503.

Part of rust-lang#44596
ec5342b

@frewsxcv frewsxcv referenced this pull request Sep 23, 2017

Merged

Rollup of 14 pull requests #44784

bors added a commit that referenced this pull request Sep 23, 2017

@bors
Auto merge of #44784 - frewsxcv:rollup, r=frewsxcv 
Rollup of 14 pull requests

- Successful merges: #44554, #44648, #44658, #44712, #44717, #44726, #44745, #44746, #44749, #44759, #44770, #44773, #44776, #44778
- Failed merges:
Loading status checks…
85a5d3f

@bors bors merged commit 8c1b958 into rust-lang:master Sep 23, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zilbuz zilbuz deleted the zilbuz:issue-44596/E0503 branch Sep 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.