Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove diagnostics when attempting to match tuple enum variant with struct pattern #44786
Conversation
thombles
added some commits
Sep 23, 2017
rust-highfive
assigned
arielb1
Sep 23, 2017
This comment has been minimized.
This comment has been minimized.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
This comment has been minimized.
This comment has been minimized.
|
|
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 23, 2017
bors
added a commit
that referenced
this pull request
Sep 23, 2017
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Sep 24, 2017
This comment has been minimized.
This comment has been minimized.
|
|
thombles commentedSep 23, 2017
•
edited by petrochenkov
Adds an extra note as below to explain that a tuple pattern was probably intended.
Fixes #41314.