New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for process::abort #44905

Merged
merged 3 commits into from Oct 4, 2017

Conversation

Projects
None yet
6 participants
@Mistodon
Contributor

Mistodon commented Sep 28, 2017

Remove a typo and explain the relationship to panic!.

Part of #29370

r? @steveklabnik

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Sep 28, 2017

Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Collaborator

rust-highfive commented Sep 28, 2017

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Show outdated Hide outdated src/libstd/process.rs Outdated
@Mistodon

This comment has been minimized.

Show comment
Hide comment
@Mistodon

Mistodon Oct 2, 2017

Contributor

I've amended that description to mention the panic hook, I think this is correct now.

Contributor

Mistodon commented Oct 2, 2017

I've amended that description to mention the panic hook, I think this is correct now.

@diwic

This comment has been minimized.

Show comment
Hide comment
@diwic

diwic Oct 2, 2017

Contributor

@Pirh
Looks good to me! (I'm not someone who has any rights to ask bors to do anything, so you'll have to wait for someone else to review/approve as well.)

Contributor

diwic commented Oct 2, 2017

@Pirh
Looks good to me! (I'm not someone who has any rights to ask bors to do anything, so you'll have to wait for someone else to review/approve as well.)

@steveklabnik

Thanks so much!

@steveklabnik

This comment has been minimized.

Show comment
Hide comment
@steveklabnik

steveklabnik Oct 3, 2017

Member

@bors: r+ rollup

Member

steveklabnik commented Oct 3, 2017

@bors: r+ rollup

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 3, 2017

Contributor

📌 Commit 28ef0d1 has been approved by steveklabnik

Contributor

bors commented Oct 3, 2017

📌 Commit 28ef0d1 has been approved by steveklabnik

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 4, 2017

Contributor

⌛️ Testing commit 28ef0d1 with merge eabef06...

Contributor

bors commented Oct 4, 2017

⌛️ Testing commit 28ef0d1 with merge eabef06...

bors added a commit that referenced this pull request Oct 4, 2017

Auto merge of #44905 - Pirh:process_abort_docs, r=steveklabnik
Update docs for process::abort

Remove a typo and explain the relationship to `panic!`.

Part of #29370

r? @steveklabnik
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 4, 2017

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: steveklabnik
Pushing eabef06 to master...

Contributor

bors commented Oct 4, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: steveklabnik
Pushing eabef06 to master...

@bors bors merged commit 28ef0d1 into rust-lang:master Oct 4, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@mgattozzi mgattozzi referenced this pull request Oct 8, 2017

Open

API Docs: process #29370

12 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment