New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let htmldocck.py check for directories #44949

Merged
merged 1 commit into from Oct 3, 2017

Conversation

Projects
None yet
5 participants
@QuietMisdreavus
Member

QuietMisdreavus commented Sep 30, 2017

Since i messed this up during #44613, i wanted to codify this into the rustdoc tests to make sure that doesn't happen again.

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Sep 30, 2017

Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

Collaborator

rust-highfive commented Sep 30, 2017

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@QuietMisdreavus

This comment has been minimized.

Show comment
Hide comment
@QuietMisdreavus

QuietMisdreavus Sep 30, 2017

Member

I checked locally to make sure when i invert a @has-dir that it fails when it's supposed to, but i don't think there's a compile-fail analog for rustdoc tests. >_>

Member

QuietMisdreavus commented Sep 30, 2017

I checked locally to make sure when i invert a @has-dir that it fails when it's supposed to, but i don't think there's a compile-fail analog for rustdoc tests. >_>

@nikomatsakis

This comment has been minimized.

Show comment
Hide comment
@nikomatsakis

nikomatsakis Oct 3, 2017

Contributor

@bors r+

but i don't think there's a compile-fail analog for rustdoc tests

yeah... meta-testing is hard.

Contributor

nikomatsakis commented Oct 3, 2017

@bors r+

but i don't think there's a compile-fail analog for rustdoc tests

yeah... meta-testing is hard.

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 3, 2017

Contributor

📌 Commit 5b59c4d has been approved by nikomatsakis

Contributor

bors commented Oct 3, 2017

📌 Commit 5b59c4d has been approved by nikomatsakis

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 3, 2017

Contributor

⌛️ Testing commit 5b59c4d with merge 4502e2a...

Contributor

bors commented Oct 3, 2017

⌛️ Testing commit 5b59c4d with merge 4502e2a...

bors added a commit that referenced this pull request Oct 3, 2017

Auto merge of #44949 - QuietMisdreavus:rustdoctest-dirs, r=nikomatsakis
let htmldocck.py check for directories

Since i messed this up during #44613, i wanted to codify this into the rustdoc tests to make sure that doesn't happen again.
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 3, 2017

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 4502e2a to master...

Contributor

bors commented Oct 3, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 4502e2a to master...

@bors bors merged commit 5b59c4d into rust-lang:master Oct 3, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@QuietMisdreavus QuietMisdreavus deleted the QuietMisdreavus:rustdoctest-dirs branch Feb 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment