New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #36284 - vec.rs documentation #44960

Merged
merged 1 commit into from Oct 2, 2017

Conversation

Projects
None yet
5 participants
@SeanPrashad
Contributor

SeanPrashad commented Oct 1, 2017

Removed comments associated with [into_vec] being equivalent to [shrink_to_fit] as requested.

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Oct 1, 2017

Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dtolnay (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Collaborator

rust-highfive commented Oct 1, 2017

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dtolnay (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik

This comment has been minimized.

Show comment
Hide comment
@steveklabnik

steveklabnik Oct 1, 2017

Member

@bors: r+ rollup

perfect, thank you so much!

Member

steveklabnik commented Oct 1, 2017

@bors: r+ rollup

perfect, thank you so much!

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 1, 2017

Contributor

📌 Commit 1ebc7bb has been approved by steveklabnik

Contributor

bors commented Oct 1, 2017

📌 Commit 1ebc7bb has been approved by steveklabnik

@dtolnay dtolnay assigned steveklabnik and unassigned dtolnay Oct 1, 2017

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 2, 2017

Contributor

⌛️ Testing commit 1ebc7bb with merge 2146c61...

Contributor

bors commented Oct 2, 2017

⌛️ Testing commit 1ebc7bb with merge 2146c61...

bors added a commit that referenced this pull request Oct 2, 2017

Auto merge of #44960 - SeanPrashad:master, r=steveklabnik
Resolves #36284 - vec.rs documentation

Removed comments associated with `[into_vec]` being equivalent to `[shrink_to_fit]` as requested.
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 2, 2017

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: steveklabnik
Pushing 2146c61 to master...

Contributor

bors commented Oct 2, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: steveklabnik
Pushing 2146c61 to master...

@bors bors merged commit 1ebc7bb into rust-lang:master Oct 2, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment