New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for the PNaCl target (le32-unknown-nacl) #45041

Merged
merged 5 commits into from Oct 9, 2017

Conversation

Projects
None yet
7 participants
@est31
Contributor

est31 commented Oct 5, 2017

This removes support for the le32-unknown-nacl target which is currently supported by rustc on tier 3. Despite the "nacl" in the name, the target doesn't output native code (x86, ARM, MIPS), instead it outputs binaries in the PNaCl format.

There are two reasons for the removal:

  • Google has announced deprecation of the PNaCl format. The suggestion is to migrate to wasm. Happens we already have a wasm backend!
  • Our PNaCl LLVM backend is provided by the fastcomp patch set that the LLVM fork used by rustc contains in addition to vanilla LLVM (src/llvm/lib/Target/JSBackend/NaCl). Upstream LLVM doesn't have PNaCl support. Removing PNaCl support will enable us to move away from fastcomp (#44006) and have a lighter set of patches on top of upstream LLVM inside our LLVM fork. This will help distribution packagers of Rust.

Fixes #42420

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Oct 5, 2017

Collaborator

r? @BurntSushi

(rust_highfive has picked a reviewer for you, use r? to override)

Collaborator

rust-highfive commented Oct 5, 2017

r? @BurntSushi

(rust_highfive has picked a reviewer for you, use r? to override)

@est31

This comment has been minimized.

Show comment
Hide comment
@est31

est31 Oct 5, 2017

Contributor

r? @eddyb

Contributor

est31 commented Oct 5, 2017

r? @eddyb

@rust-highfive rust-highfive assigned eddyb and unassigned BurntSushi Oct 5, 2017

@est31

This comment has been minimized.

Show comment
Hide comment
@est31

est31 Oct 5, 2017

Contributor
Contributor

est31 commented Oct 5, 2017

@eddyb

This comment has been minimized.

Show comment
Hide comment
@eddyb
Member

eddyb commented Oct 5, 2017

@rust-highfive rust-highfive assigned alexcrichton and unassigned eddyb Oct 5, 2017

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton
Member

alexcrichton commented Oct 5, 2017

@bors: r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 5, 2017

Contributor

📌 Commit 327116a has been approved by alexcrichton

Contributor

bors commented Oct 5, 2017

📌 Commit 327116a has been approved by alexcrichton

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 9, 2017

Contributor

⌛️ Testing commit 327116a with merge b2f67c8...

Contributor

bors commented Oct 9, 2017

⌛️ Testing commit 327116a with merge b2f67c8...

bors added a commit that referenced this pull request Oct 9, 2017

Auto merge of #45041 - est31:master, r=alexcrichton
Remove support for the PNaCl target (le32-unknown-nacl)

This removes support for the `le32-unknown-nacl` target which is currently supported by rustc on tier 3. Despite the "nacl" in the name, the target doesn't output native code (x86, ARM, MIPS), instead it outputs binaries in the PNaCl format.

There are two reasons for the removal:

* Google [has announced](https://blog.chromium.org/2017/05/goodbye-pnacl-hello-webassembly.html) deprecation of the PNaCl format. The suggestion is to migrate to wasm. Happens we already have a wasm backend!
* Our PNaCl LLVM backend is provided by the fastcomp patch set that the LLVM fork used by rustc contains in addition to vanilla LLVM (`src/llvm/lib/Target/JSBackend/NaCl`). Upstream LLVM doesn't have PNaCl support. Removing PNaCl support will enable us to move away from fastcomp (#44006) and have a lighter set of patches on top of upstream LLVM inside our LLVM fork. This will help distribution packagers of Rust.

Fixes #42420
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 9, 2017

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing b2f67c8 to master...

Contributor

bors commented Oct 9, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing b2f67c8 to master...

@bors bors merged commit 327116a into rust-lang:master Oct 9, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@pitdicker pitdicker referenced this pull request Oct 22, 2017

Merged

Drop support for PNaCL #19

@kornelski kornelski referenced this pull request Nov 20, 2017

Closed

Rust has obsoleted this #1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment