Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incr.comp.: Add some documentation to force_from_dep_node(). #45139

Merged
merged 1 commit into from Oct 11, 2017
Merged

incr.comp.: Add some documentation to force_from_dep_node(). #45139

merged 1 commit into from Oct 11, 2017

Conversation

michaelwoerister
Copy link
Member

theotherjimmy
theotherjimmy approved these changes Oct 9, 2017
View reviewed changes
Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm now very clear on what this function does and how this fits into adding new queries (or queryifying non-queries).

@michaelwoerister
Copy link
Member Author

@theotherjimmy Excellent. On a related note: if you come across another PR like this where we try to improve documentation but it does not make things clearer for you, don't hesitate to let us know about that too.

@nikomatsakis
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 10, 2017

📌 Commit eb1006f has been approved by nikomatsakis

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Oct 11, 2017
@steveklabnik
Rollup merge of rust-lang#45139 - michaelwoerister:document-force_fro…
0a0bec7 
…m_dep_node, r=nikomatsakis

incr.comp.: Add some documentation to force_from_dep_node().

r? @nikomatsakis
@steveklabnik steveklabnik mentioned this pull request Oct 11, 2017
Merged
bors added a commit that referenced this pull request Oct 11, 2017
@bors
Auto merge of #45192 - steveklabnik:rollup, r=steveklabnik
c0d40a1 
Rollup of 5 pull requests

- Successful merges: #45071, #45139, #45148, #45171, #45180
- Failed merges: #45121
@bors bors merged commit eb1006f into rust-lang:master Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

@theotherjimmy theotherjimmy theotherjimmy approved these changes

Assignees

@nikomatsakis nikomatsakis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@michaelwoerister @nikomatsakis @bors @theotherjimmy