Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upincr.comp.: Add some documentation to force_from_dep_node(). #45139
Conversation
rust-highfive
assigned
nikomatsakis
Oct 9, 2017
theotherjimmy
approved these changes
Oct 9, 2017
|
I'm now very clear on what this function does and how this fits into adding new queries (or queryifying non-queries). |
This comment has been minimized.
This comment has been minimized.
|
@theotherjimmy Excellent. On a related note: if you come across another PR like this where we try to improve documentation but it does not make things clearer for you, don't hesitate to let us know about that too. |
nikomatsakis
approved these changes
Oct 10, 2017
This comment has been minimized.
This comment has been minimized.
|
@bors r+ rollup |
This comment has been minimized.
This comment has been minimized.
|
|
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Oct 11, 2017
bors
added a commit
that referenced
this pull request
Oct 11, 2017
bors
added a commit
that referenced
this pull request
Oct 11, 2017
bors
added a commit
that referenced
this pull request
Oct 11, 2017
bors
added a commit
that referenced
this pull request
Oct 11, 2017
bors
merged commit eb1006f
into
rust-lang:master
Oct 11, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
michaelwoerister commentedOct 9, 2017
r? @nikomatsakis