Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement `dyn Trait` syntax (RFC 2113) #45175
Conversation
rust-highfive
assigned
nikomatsakis
Oct 10, 2017
This was referenced Oct 10, 2017
nikomatsakis
approved these changes
Oct 10, 2017
|
r=me modulo new test |
|
|
||
| fn main() { | ||
| let x: &(dyn 'static + Display) = &BYTE; | ||
| let y: Box<dyn Display + 'static> = Box::new(BYTE); |
This comment has been minimized.
This comment has been minimized.
nikomatsakis
Oct 10, 2017
Contributor
can we get a test like dyn Vec<T> -- i.e., something not a trait?
petrochenkov
force-pushed the
petrochenkov:dyn
branch
from
80067f2
to
f769977
Oct 11, 2017
This comment has been minimized.
This comment has been minimized.
|
@bors r=nikomatsakis |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
@bors r- |
aidanhs
added
the
S-waiting-on-author
label
Oct 12, 2017
petrochenkov
force-pushed the
petrochenkov:dyn
branch
from
f769977
to
f1c6247
Oct 12, 2017
This comment has been minimized.
This comment has been minimized.
|
@bors r=nikomatsakis |
This comment has been minimized.
This comment has been minimized.
|
|
petrochenkov
added some commits
Oct 10, 2017
petrochenkov
force-pushed the
petrochenkov:dyn
branch
from
f1c6247
to
9d37320
Oct 14, 2017
This comment has been minimized.
This comment has been minimized.
|
@bors r=nikomatsakis |
This comment has been minimized.
This comment has been minimized.
|
|
kennytm
added
S-waiting-on-bors
and removed
S-waiting-on-author
labels
Oct 14, 2017
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Oct 14, 2017
This comment has been minimized.
This comment has been minimized.
|
|
bors
merged commit 9d37320
into
rust-lang:master
Oct 14, 2017
This was referenced Oct 14, 2017
petrochenkov
referenced this pull request
Oct 17, 2017
Merged
syntax: Lower priority of `+` in `impl Trait`/`dyn Trait` #45294
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
petrochenkov commentedOct 10, 2017
cc #44662
r? @nikomatsakis