Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uprustc: Update LLVM with a ThinLTO fix #45203
Conversation
This comment has been minimized.
This comment has been minimized.
rust-highfive
assigned
michaelwoerister
Oct 12, 2017
This comment has been minimized.
This comment has been minimized.
|
@bors r+ |
This comment has been minimized.
This comment has been minimized.
|
|
kennytm
added
the
S-waiting-on-bors
label
Oct 13, 2017
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 13, 2017
bors
added a commit
that referenced
this pull request
Oct 13, 2017
bors
merged commit a2aba79
into
rust-lang:master
Oct 13, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
alexcrichton
deleted the
alexcrichton:update-llvm
branch
Oct 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
alexcrichton commentedOct 11, 2017
This commit updates LLVM with a patch that's landed upstream to fix an assertion
that was tripping when ThinLTO was activated. Unfortunately I wasn't able to get
a reduced test case, but I've tested manually on the affected crates and the
assertion is indeed fixed.
Closes #45131