Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: Fix some ThinLTO internalization #45215

Merged
merged 1 commit into from Oct 15, 2017

Conversation

Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
6 participants
@alexcrichton @rust-highfive @michaelwoerister @bors @kennytm @arielb1
@alexcrichton
Copy link
Member

alexcrichton commented Oct 11, 2017

First the addPreservedGUID function forgot to take care of "alias" summaries.
I'm not 100% sure what this is but the current code now matches upstream. Next
the computeDeadSymbols return value wasn't actually being used, but it needed
to be used! Together these should...

Closes #45195

@rust-highfive rust-highfive assigned arielb1 Oct 11, 2017

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Oct 11, 2017

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Oct 11, 2017

r? @michaelwoerister

@rust-highfive rust-highfive assigned michaelwoerister and unassigned arielb1 Oct 11, 2017

@alexcrichton alexcrichton force-pushed the alexcrichton:thin-lto-reference-more branch from 5cd5a78 to e4b1536 Oct 12, 2017

@michaelwoerister

This comment has been minimized.

Sign in to view
Copy link
Contributor

michaelwoerister commented Oct 12, 2017

Thank you, Alex!

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Oct 12, 2017

📌 Commit e4b1536 has been approved by michaelwoerister
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Oct 15, 2017

⌛️ Testing commit e4b1536 with merge 91c1736...

bors added a commit that referenced this pull request Oct 15, 2017

@bors
Auto merge of #45215 - alexcrichton:thin-lto-reference-more, r=michae… 
…lwoerister

rustc: Fix some ThinLTO internalization

First the `addPreservedGUID` function forgot to take care of "alias" summaries.
I'm not 100% sure what this is but the current code now matches upstream. Next
the `computeDeadSymbols` return value wasn't actually being used, but it needed
to be used! Together these should...

Closes #45195
Loading status checks…
91c1736

@kennytm kennytm added the S-waiting-on-bors label Oct 15, 2017

@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Oct 15, 2017

💔 Test failed - status-travis
@kennytm

This comment has been minimized.

Sign in to view
Copy link
Member

kennytm commented Oct 15, 2017

Legit. You forgot to move some auxiliary files 😄

[00:55:13] ---- [run-pass] run-pass/thinlto/thin-lto-inlines2.rs stdout ----
[00:55:13] 	
[00:55:13] error: aux-build `/checkout/src/test/run-pass/thinlto/auxiliary/thin-lto-inlines-aux.rs` source not found
[00:55:13] thread '[run-pass] run-pass/thinlto/thin-lto-inlines2.rs' panicked at 'explicit panic', /checkout/src/tools/compiletest/src/runtest.rs:1599:25
[00:55:13] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:55:13] 
[00:55:13] 
[00:55:13] failures:
[00:55:13]     [run-pass] run-pass/thinlto/thin-lto-inlines2.rs

@kennytm kennytm added S-waiting-on-author and removed S-waiting-on-bors labels Oct 15, 2017

@alexcrichton
rustc: Fix some ThinLTO internalization 
First the `addPreservedGUID` function forgot to take care of "alias" summaries.
I'm not 100% sure what this is but the current code now matches upstream. Next
the `computeDeadSymbols` return value wasn't actually being used, but it needed
to be used! Together these should...

Closes #45195
Loading status checks…
2e1c4cd

@alexcrichton alexcrichton force-pushed the alexcrichton:thin-lto-reference-more branch from e4b1536 to 2e1c4cd Oct 15, 2017

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Oct 15, 2017

@bors: r=michaelwoerister
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Oct 15, 2017

📌 Commit 2e1c4cd has been approved by michaelwoerister

@kennytm kennytm added S-waiting-on-bors and removed S-waiting-on-author labels Oct 15, 2017

@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Oct 15, 2017

⌛️ Testing commit 2e1c4cd with merge 07adde3...

bors added a commit that referenced this pull request Oct 15, 2017

@bors
Auto merge of #45215 - alexcrichton:thin-lto-reference-more, r=michae… 
…lwoerister

rustc: Fix some ThinLTO internalization

First the `addPreservedGUID` function forgot to take care of "alias" summaries.
I'm not 100% sure what this is but the current code now matches upstream. Next
the `computeDeadSymbols` return value wasn't actually being used, but it needed
to be used! Together these should...

Closes #45195
Loading status checks…
07adde3
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Oct 15, 2017

💔 Test failed - status-travis
@kennytm

This comment has been minimized.

Sign in to view
Copy link
Member

kennytm commented Oct 15, 2017

@bors retry

The build got spuriously cancelled?
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Oct 15, 2017

⌛️ Testing commit 2e1c4cd with merge 29ed49f...

bors added a commit that referenced this pull request Oct 15, 2017

@bors
Auto merge of #45215 - alexcrichton:thin-lto-reference-more, r=michae… 
…lwoerister

rustc: Fix some ThinLTO internalization

First the `addPreservedGUID` function forgot to take care of "alias" summaries.
I'm not 100% sure what this is but the current code now matches upstream. Next
the `computeDeadSymbols` return value wasn't actually being used, but it needed
to be used! Together these should...

Closes #45195
Loading status checks…
29ed49f
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Oct 15, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: michaelwoerister
Pushing 29ed49f to master...

@bors bors merged commit 2e1c4cd into rust-lang:master Oct 15, 2017
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@michaelwoerister

This comment has been minimized.

Sign in to view
Copy link
Contributor

michaelwoerister commented Oct 16, 2017

🎉

@petrochenkov petrochenkov referenced this pull request Oct 16, 2017

Closed

Some run-pass tests fail after recent LTO/CGU changes #45103

@alexcrichton alexcrichton deleted the alexcrichton:thin-lto-reference-more branch Oct 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.