Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upEmit crate disambiguators in save-analysis data #45468
Conversation
rust-highfive
assigned
nrc
Oct 23, 2017
This comment has been minimized.
This comment has been minimized.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Xanewok
referenced this pull request
Oct 23, 2017
Merged
Support multiple crate types and versions (and multiple passed directly in-memory) #106
kennytm
added
the
S-waiting-on-author
label
Oct 23, 2017
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
r+ once the rls-data PR lands and using the new rls-data version. |
Xanewok
added some commits
Oct 15, 2017
Xanewok
force-pushed the
Xanewok:crate-source
branch
from
444f8ed
to
45fa7b2
Oct 27, 2017
This comment has been minimized.
This comment has been minimized.
|
Resolved conflict and updated version using rls-data 0.12 |
This comment has been minimized.
This comment has been minimized.
|
@Xanewok Is this PR still [WIP], or is it ready to be merged? |
Xanewok
changed the title
[WIP] Emit crate disambiguators in save-analysis data
Emit crate disambiguators in save-analysis data
Oct 29, 2017
This comment has been minimized.
This comment has been minimized.
kennytm
added
S-waiting-on-review
and removed
S-waiting-on-author
labels
Oct 29, 2017
This comment has been minimized.
This comment has been minimized.
|
@bors: r+ |
This comment has been minimized.
This comment has been minimized.
|
|
nrc
added
S-waiting-on-bors
and removed
S-waiting-on-review
labels
Oct 29, 2017
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Oct 30, 2017
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
@nrc this failed on compiling rls (rls-data mismatch). What should we do here to resolve this? |
kennytm
added
S-waiting-on-author
and removed
S-waiting-on-bors
labels
Oct 30, 2017
Xanewok
added a commit
to Xanewok/rust
that referenced
this pull request
Oct 30, 2017
Xanewok
force-pushed the
Xanewok:crate-source
branch
from
c53b39e
to
930464e
Oct 30, 2017
Xanewok
added a commit
to Xanewok/rust
that referenced
this pull request
Oct 30, 2017
This comment has been minimized.
This comment has been minimized.
|
Updating rls submodule to rust-45468 branch, so it can compile with these changes. |
kennytm
added
S-waiting-on-review
and removed
S-waiting-on-author
labels
Oct 30, 2017
This comment has been minimized.
This comment has been minimized.
|
@bors: r+ |
This comment has been minimized.
This comment has been minimized.
|
|
kennytm
added
S-waiting-on-bors
and removed
S-waiting-on-review
labels
Oct 31, 2017
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Oct 31, 2017
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
single test in rls failed:
|
kennytm
added
S-waiting-on-author
and removed
S-waiting-on-bors
labels
Oct 31, 2017
Xanewok
force-pushed the
Xanewok:crate-source
branch
from
930464e
to
b4ffede
Oct 31, 2017
This comment has been minimized.
This comment has been minimized.
|
@bors: r+ |
This comment has been minimized.
This comment has been minimized.
|
|
kennytm
added
S-waiting-on-bors
and removed
S-waiting-on-author
labels
Nov 1, 2017
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Nov 1, 2017
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Nov 2, 2017
This comment has been minimized.
This comment has been minimized.
|
|
Xanewok commentedOct 23, 2017
Needed for rust-dev-tools/rls-analysis#93.
Blocked by rust-dev-tools/rls-data#11. (For now, this pulls my branch rls-data/crate-source)
This will allow to disambiguate different crates types/versions when indexing resulting save-analysis data (most importantly allow to support bin+lib and different crate versions).
r? @nrc