New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make coercions to `!` in unreachable code a hard error #45880

Merged
merged 1 commit into from Dec 2, 2017

Conversation

Projects
None yet
9 participants
@arielb1
Contributor

arielb1 commented Nov 8, 2017

This was added to cover up a lazy extra semicolon in #35849, but does
not actually make sense. This is removed as a part of the stabilization
of never_type.

@arielb1

This comment has been minimized.

Show comment
Hide comment
@arielb1
Contributor

arielb1 commented Nov 8, 2017

@Mark-Simulacrum

This comment has been minimized.

Show comment
Hide comment
@Mark-Simulacrum
Member

Mark-Simulacrum commented Nov 8, 2017

@bors try

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 8, 2017

Contributor

⌛️ Trying commit 2dd1dbf with merge 371771a...

Contributor

bors commented Nov 8, 2017

⌛️ Trying commit 2dd1dbf with merge 371771a...

bors added a commit that referenced this pull request Nov 8, 2017

Auto merge of #45880 - arielb1:never-coerce, r=<try>
[needs crater] make coercions to `!` in unreachable code a hard error

This was added to cover up a lazy extra semicolon in #35849, but does
not actually make sense. This is removed as a part of the stabilization
of `never_type`.
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 9, 2017

Contributor

☀️ Test successful - status-travis
State: approved= try=True

Contributor

bors commented Nov 9, 2017

☀️ Test successful - status-travis
State: approved= try=True

@Mark-Simulacrum

This comment has been minimized.

Show comment
Hide comment
@Mark-Simulacrum

Mark-Simulacrum Nov 9, 2017

Member

Crater started.

Member

Mark-Simulacrum commented Nov 9, 2017

Crater started.

@nikomatsakis

This comment has been minimized.

Show comment
Hide comment
@nikomatsakis

nikomatsakis Nov 10, 2017

Contributor

Nice.

Contributor

nikomatsakis commented Nov 10, 2017

Nice.

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Nov 12, 2017

Member

r? @eddyb

(just making sure this has an assigned reviewer)

Member

alexcrichton commented Nov 12, 2017

r? @eddyb

(just making sure this has an assigned reviewer)

@eddyb

This comment has been minimized.

Show comment
Hide comment
@eddyb

eddyb Nov 12, 2017

Member

LGTM, if we actually want to do this, I guess.

Member

eddyb commented Nov 12, 2017

LGTM, if we actually want to do this, I guess.

@Mark-Simulacrum

This comment has been minimized.

Show comment
Hide comment
@Mark-Simulacrum

Mark-Simulacrum Nov 13, 2017

Member

Please rebase onto master and run another try build to pick up fixes in Cargo.

Member

Mark-Simulacrum commented Nov 13, 2017

Please rebase onto master and run another try build to pick up fixes in Cargo.

@arielb1

This comment has been minimized.

Show comment
Hide comment
@arielb1

arielb1 Nov 15, 2017

Contributor

@Mark-Simulacrum

Force push done. Waiting for another crater run.

Contributor

arielb1 commented Nov 15, 2017

@Mark-Simulacrum

Force push done. Waiting for another crater run.

@Mark-Simulacrum

This comment has been minimized.

Show comment
Hide comment
@Mark-Simulacrum
Member

Mark-Simulacrum commented Nov 15, 2017

@bors try

bors added a commit that referenced this pull request Nov 15, 2017

Auto merge of #45880 - arielb1:never-coerce, r=<try>
[needs crater] make coercions to `!` in unreachable code a hard error

This was added to cover up a lazy extra semicolon in #35849, but does
not actually make sense. This is removed as a part of the stabilization
of `never_type`.
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 15, 2017

Contributor

⌛️ Trying commit 491d128 with merge b53e6a8...

Contributor

bors commented Nov 15, 2017

⌛️ Trying commit 491d128 with merge b53e6a8...

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 15, 2017

Contributor

☀️ Test successful - status-travis
State: approved= try=True

Contributor

bors commented Nov 15, 2017

☀️ Test successful - status-travis
State: approved= try=True

@aidanhs

This comment has been minimized.

Show comment
Hide comment
@aidanhs

aidanhs Nov 21, 2017

Member

Crater run started

Member

aidanhs commented Nov 21, 2017

Crater run started

@aidanhs

This comment has been minimized.

Show comment
Hide comment
@aidanhs

aidanhs Nov 26, 2017

Member

Hi @arielb1 (crater requester), @eddyb (reviewer)! Crater results are at: http://cargobomb-reports.s3.amazonaws.com/pr-45580/index.html. 'Blacklisted' crates (spurious failures etc) can be found
here. If you see any spurious failures not on the list, please make a PR against that file.

Member

aidanhs commented Nov 26, 2017

Hi @arielb1 (crater requester), @eddyb (reviewer)! Crater results are at: http://cargobomb-reports.s3.amazonaws.com/pr-45580/index.html. 'Blacklisted' crates (spurious failures etc) can be found
here. If you see any spurious failures not on the list, please make a PR against that file.

@arielb1

This comment has been minimized.

Show comment
Hide comment
@arielb1

arielb1 Nov 26, 2017

Contributor

All failures look spurious.

Contributor

arielb1 commented Nov 26, 2017

All failures look spurious.

@arielb1

This comment has been minimized.

Show comment
Hide comment
@arielb1

arielb1 Nov 26, 2017

Contributor

I suppose we'll merge this with deny-by-default, given that there were no failures on crater

r? @nikomatsakis

Contributor

arielb1 commented Nov 26, 2017

I suppose we'll merge this with deny-by-default, given that there were no failures on crater

r? @nikomatsakis

@rust-highfive rust-highfive assigned nikomatsakis and unassigned eddyb Nov 26, 2017

@arielb1 arielb1 changed the title from [needs crater] make coercions to `!` in unreachable code a hard error to make coercions to `!` in unreachable code a hard error Nov 26, 2017

@arielb1

This comment has been minimized.

Show comment
Hide comment
@arielb1

arielb1 Nov 29, 2017

Contributor

@bors r=nikomatsakis rollup

Contributor

arielb1 commented Nov 29, 2017

@bors r=nikomatsakis rollup

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 29, 2017

Contributor

📌 Commit 235de09 has been approved by nikomatsakis

Contributor

bors commented Nov 29, 2017

📌 Commit 235de09 has been approved by nikomatsakis

arielb1 added a commit to arielb1/rust that referenced this pull request Nov 30, 2017

Rollup merge of rust-lang#45880 - arielb1:never-coerce, r=nikomatsakis
make coercions to `!` in unreachable code a hard error

This was added to cover up a lazy extra semicolon in rust-lang#35849, but does
not actually make sense. This is removed as a part of the stabilization
of `never_type`.
make coercions to `!` in unreachable code a hard error
This was added to cover up a lazy extra semicolon in #35849, but does
not actually make sense. This is removed as a part of the stabilization
of `never_type`.
@arielb1

This comment has been minimized.

Show comment
Hide comment
@arielb1

arielb1 Nov 30, 2017

Contributor

@bors r=nikomatsakis rollup

Contributor

arielb1 commented Nov 30, 2017

@bors r=nikomatsakis rollup

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 30, 2017

Contributor

📌 Commit 5a00b7c has been approved by nikomatsakis

Contributor

bors commented Nov 30, 2017

📌 Commit 5a00b7c has been approved by nikomatsakis

arielb1 added a commit to arielb1/rust that referenced this pull request Nov 30, 2017

Rollup merge of rust-lang#45880 - arielb1:never-coerce, r=nikomatsakis
make coercions to `!` in unreachable code a hard error

This was added to cover up a lazy extra semicolon in rust-lang#35849, but does
not actually make sense. This is removed as a part of the stabilization
of `never_type`.

arielb1 added a commit to arielb1/rust that referenced this pull request Nov 30, 2017

Rollup merge of rust-lang#45880 - arielb1:never-coerce, r=nikomatsakis
make coercions to `!` in unreachable code a hard error

This was added to cover up a lazy extra semicolon in rust-lang#35849, but does
not actually make sense. This is removed as a part of the stabilization
of `never_type`.

bors added a commit that referenced this pull request Nov 30, 2017

Auto merge of #46399 - arielb1:rollup, r=arielb1
Rollup of 11 pull requests

- Successful merges: #45880, #46256, #46280, #46290, #46343, #46349, #46368, #46370, #46384, #46385, #46386
- Failed merges:

arielb1 added a commit to arielb1/rust that referenced this pull request Nov 30, 2017

Rollup merge of rust-lang#45880 - arielb1:never-coerce, r=nikomatsakis
make coercions to `!` in unreachable code a hard error

This was added to cover up a lazy extra semicolon in rust-lang#35849, but does
not actually make sense. This is removed as a part of the stabilization
of `never_type`.

arielb1 added a commit to arielb1/rust that referenced this pull request Nov 30, 2017

Rollup merge of rust-lang#45880 - arielb1:never-coerce, r=nikomatsakis
make coercions to `!` in unreachable code a hard error

This was added to cover up a lazy extra semicolon in rust-lang#35849, but does
not actually make sense. This is removed as a part of the stabilization
of `never_type`.

bors added a commit that referenced this pull request Nov 30, 2017

Auto merge of #46404 - arielb1:rollup, r=arielb1
Rollup of 10 pull requests

- Successful merges: #45880, #46280, #46290, #46343, #46349, #46368, #46384, #46385, #46386, #46400
- Failed merges:

arielb1 added a commit to arielb1/rust that referenced this pull request Nov 30, 2017

Rollup merge of rust-lang#45880 - arielb1:never-coerce, r=nikomatsakis
make coercions to `!` in unreachable code a hard error

This was added to cover up a lazy extra semicolon in rust-lang#35849, but does
not actually make sense. This is removed as a part of the stabilization
of `never_type`.

bors added a commit that referenced this pull request Nov 30, 2017

Auto merge of #46410 - arielb1:rollup, r=arielb1
Rollup of 12 pull requests

- Successful merges: #45880, #46280, #46290, #46343, #46349, #46368, #46370, #46384, #46385, #46386, #46392, #46400
- Failed merges:

bors added a commit that referenced this pull request Dec 1, 2017

Auto merge of #46410 - arielb1:rollup, r=arielb1
Rollup of 12 pull requests

- Successful merges: #45880, #46280, #46290, #46343, #46349, #46368, #46370, #46384, #46385, #46386, #46392, #46400
- Failed merges:

kennytm added a commit to kennytm/rust that referenced this pull request Dec 1, 2017

Rollup merge of rust-lang#45880 - arielb1:never-coerce, r=nikomatsakis
make coercions to `!` in unreachable code a hard error

This was added to cover up a lazy extra semicolon in rust-lang#35849, but does
not actually make sense. This is removed as a part of the stabilization
of `never_type`.

bors added a commit that referenced this pull request Dec 1, 2017

Auto merge of #46430 - kennytm:rollup, r=kennytm
Rollup of 13 pull requests

- Successful merges: #45880, #46280, #46373, #46376, #46385, #46386, #46387, #46392, #46400, #46401, #46405, #46412, #46421
- Failed merges:

@bors bors merged commit 5a00b7c into rust-lang:master Dec 2, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment