Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update match-expressions.rs with DepNode labels #45941

Merged
merged 3 commits into from Nov 14, 2017

Conversation

Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
5 participants
@gaurikholkar @michaelwoerister @nikomatsakis @bors @kennytm
@gaurikholkar
Copy link
Contributor

gaurikholkar commented Nov 12, 2017

As a part of #44924, I have updated the match-expressions.rs. The PR has tests verified for the following dependency nodes for let-expressions

  • MirValidated
  • MirOptimized
  • TypeCheckTables
  • TypeOfItem
  • GenericsOfItem
  • PredicatesOfItem
  • FnSignature

cc @michaelwoerister
r? @nikomatsakis
@gaurikholkar
update match-expressions.rs
Loading status checks…
1846add

@kennytm kennytm added the S-waiting-on-review label Nov 12, 2017

@gaurikholkar
tidy fixes
Loading status checks…
f345b3c

@alexcrichton alexcrichton assigned nikomatsakis Nov 12, 2017

@michaelwoerister

This comment has been minimized.

Sign in to view
Copy link
Contributor

michaelwoerister commented Nov 13, 2017

Thanks a lot, @gaurikholkar! Looks good to me. Could you please make the except=s line up with the cfgs in the lines above them? Or, if that conflicts with tidy, indent them by 4 spaces.
@gaurikholkar

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

gaurikholkar commented Nov 13, 2017 •
edited

@michaelwoerister done
@gaurikholkar
fixing indentation
Loading status checks…
39f468e
@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor

nikomatsakis commented Nov 13, 2017

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Nov 13, 2017

📌 Commit 39f468e has been approved by nikomatsakis
@michaelwoerister

This comment has been minimized.

Sign in to view
Copy link
Contributor

michaelwoerister commented Nov 13, 2017

Thanks @gaurikholkar!
@michaelwoerister

This comment has been minimized.

Sign in to view
Copy link
Contributor

michaelwoerister commented Nov 13, 2017

@bors rollup

@kennytm kennytm added S-waiting-on-bors and removed S-waiting-on-review labels Nov 14, 2017

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 14, 2017

@GuillaumeGomez
Rollup merge of rust-lang#45941 - gaurikholkar:master, r=nikomatsakis 
update match-expressions.rs with DepNode labels

As a part of rust-lang#44924, I have updated the match-expressions.rs. The PR has tests verified for the following dependency nodes for let-expressions

- MirValidated
- MirOptimized
- TypeCheckTables
- TypeOfItem
- GenericsOfItem
- PredicatesOfItem
- FnSignature

cc @michaelwoerister
r? @nikomatsakis
189bdfc

@GuillaumeGomez GuillaumeGomez referenced this pull request Nov 14, 2017

Merged

Rollup of 7 pull requests #45981

bors added a commit that referenced this pull request Nov 14, 2017

@bors
Auto merge of #45981 - GuillaumeGomez:rollup, r=GuillaumeGomez 
Rollup of 7 pull requests

- Successful merges: #45815, #45941, #45950, #45951, #45961, #45967, #45970
- Failed merges:
Loading status checks…
2711f21

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 14, 2017

@GuillaumeGomez
Rollup merge of rust-lang#45941 - gaurikholkar:master, r=nikomatsakis 
update match-expressions.rs with DepNode labels

As a part of rust-lang#44924, I have updated the match-expressions.rs. The PR has tests verified for the following dependency nodes for let-expressions

- MirValidated
- MirOptimized
- TypeCheckTables
- TypeOfItem
- GenericsOfItem
- PredicatesOfItem
- FnSignature

cc @michaelwoerister
r? @nikomatsakis
c95ef0d

bors added a commit that referenced this pull request Nov 14, 2017

@bors
Auto merge of #45981 - GuillaumeGomez:rollup, r=GuillaumeGomez 
Rollup of 7 pull requests

- Successful merges: #45815, #45941, #45950, #45961, #45967, #45970, #45977
- Failed merges:
Loading status checks…
dbeb5bf

@bors bors merged commit 39f468e into rust-lang:master Nov 14, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.