Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upupdate let-expressions hash test to use `except` #45987
Conversation
kennytm
added
the
S-waiting-on-review
label
Nov 14, 2017
This comment has been minimized.
This comment has been minimized.
rust-highfive
assigned
nikomatsakis
Nov 18, 2017
This comment has been minimized.
This comment has been minimized.
|
Thanks @gaurikholkar! @bors r+ |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
@bors rollup |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Nov 21, 2017
bors
added a commit
that referenced
this pull request
Nov 21, 2017
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Nov 21, 2017
bors
added a commit
that referenced
this pull request
Nov 21, 2017
bors
merged commit ef275d1
into
rust-lang:master
Nov 21, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
gaurikholkar commentedNov 14, 2017
•
edited
A part of #44924, this PR updated let-expressions test using
except.cc @michaelwoerister
r? @nikomatsakis