/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename C-like enum to Field-less enum #46187

Merged
merged 6 commits into from Dec 7, 2017

Conversation

Reviewers

@QuietMisdreavus QuietMisdreavus

Assignees

@QuietMisdreavus QuietMisdreavus

Labels
Projects
None yet
Milestone
No milestone
9 participants
@notriddle @rust-highfive @kennytm @steveklabnik @QuietMisdreavus @bors @alexcrichton @frewsxcv @nikomatsakis
@notriddle
Contributor

notriddle commented Nov 22, 2017

There is no need to reference the C programming language to explain this concept.
@notriddle
Rename C-like enum to Field-less enum 
There is no need to reference the C programming language to explain this concept.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
cf14b17

@rust-highfive rust-highfive assigned alexcrichton Nov 22, 2017

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Nov 22, 2017

Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)
Collaborator

rust-highfive commented Nov 22, 2017

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

notriddle added some commits Nov 22, 2017

@notriddle
Update issue-17383.rs
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
8c90046
@notriddle
Update diagnostics.rs
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
a0628ef
@notriddle
Update parser.rs
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
06a75e4

@kennytm kennytm added S-waiting-on-review T-doc labels Nov 22, 2017

@kennytm

This comment has been minimized.

Show comment
Hide comment
@kennytm

kennytm Nov 22, 2017

Member

Context: https://internals.rust-lang.org/t/proposal-bikeshed-rename-c-like-enumeration/6209

Randomly reassigning to someone in the docs team… r? @frewsxcv
Member

kennytm commented Nov 22, 2017

Context: https://internals.rust-lang.org/t/proposal-bikeshed-rename-c-like-enumeration/6209

Randomly reassigning to someone in the docs team… r? @frewsxcv

@rust-highfive rust-highfive assigned frewsxcv and unassigned alexcrichton Nov 22, 2017

@steveklabnik

This comment has been minimized.

Show comment
Hide comment
@steveklabnik

steveklabnik Nov 22, 2017

Member

Until the decisions is made, we can't accept this PR.
Member

steveklabnik commented Nov 22, 2017

Until the decisions is made, we can't accept this PR.

@steveklabnik steveklabnik closed this Nov 22, 2017

@QuietMisdreavus QuietMisdreavus referenced this pull request Nov 28, 2017

Closed

Rename C-like Enum to Field-less enum #46348

@QuietMisdreavus

This comment has been minimized.

Show comment
Hide comment
@QuietMisdreavus

QuietMisdreavus Nov 28, 2017

Member

Pending discussion on #46348 from lang team, i'm reopening this PR.
Member

QuietMisdreavus commented Nov 28, 2017

Pending discussion on #46348 from lang team, i'm reopening this PR.

@QuietMisdreavus QuietMisdreavus reopened this Nov 28, 2017

@kennytm kennytm added S-waiting-on-team T-lang and removed S-waiting-on-review T-doc labels Nov 28, 2017

@kennytm

This comment has been minimized.

Show comment
Hide comment
@kennytm

kennytm Dec 6, 2017

Member

Randomly reassigning to member on the lang team… r? @cramertj

GitHub doesn't accept it, reassigning… r? @nikomatsakis
Member

kennytm commented Dec 6, 2017 •
edited

Randomly reassigning to member on the lang team… r? @cramertj

GitHub doesn't accept it, reassigning… r? @nikomatsakis

@kennytm kennytm assigned nikomatsakis and unassigned frewsxcv Dec 6, 2017

@QuietMisdreavus

QuietMisdreavus requested changes Dec 6, 2017
View changes

The lang team (via @withoutboats) has given a quiet assent for this change, so i'll take it over from a docs perspective.

Show outdated Hide outdated src/librustc/diagnostics.rs
Show outdated Hide outdated src/librustc/diagnostics.rs

notriddle added some commits Dec 6, 2017

@notriddle
Fix dangling close paren
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
d6ba2e4
@notriddle
Fix overlong line length
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a126a73
@notriddle

This comment has been minimized.

Show comment
Hide comment
@notriddle

notriddle Dec 6, 2017

Contributor

Fixed both.
Contributor

notriddle commented Dec 6, 2017

Fixed both.

@kennytm kennytm added T-doc S-waiting-on-review and removed T-lang labels Dec 6, 2017

@kennytm kennytm removed the S-waiting-on-team label Dec 6, 2017

@nikomatsakis nikomatsakis assigned QuietMisdreavus and unassigned nikomatsakis Dec 6, 2017

@QuietMisdreavus

This comment has been minimized.

Show comment
Hide comment
@QuietMisdreavus

QuietMisdreavus Dec 6, 2017

Member

Excellent! Thanks so much!

@bors r+ rollup
Member

QuietMisdreavus commented Dec 6, 2017

Excellent! Thanks so much!

@bors r+ rollup
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 6, 2017

Contributor

📌 Commit a126a73 has been approved by QuietMisdreavus
Contributor

bors commented Dec 6, 2017

📌 Commit a126a73 has been approved by QuietMisdreavus
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 7, 2017

Contributor

⌛️ Testing commit a126a73 with merge 7b637b7...
Contributor

bors commented Dec 7, 2017

⌛️ Testing commit a126a73 with merge 7b637b7...

bors added a commit that referenced this pull request Dec 7, 2017

@bors
Auto merge of #46187 - notriddle:patch-1, r=QuietMisdreavus 
Rename C-like enum to Field-less enum

There is no need to reference the C programming language to explain this concept.
Loading status checks…
7b637b7

@kennytm kennytm added S-waiting-on-bors and removed S-waiting-on-review labels Dec 7, 2017

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 7, 2017

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: QuietMisdreavus
Pushing 7b637b7 to master...
Contributor

bors commented Dec 7, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: QuietMisdreavus
Pushing 7b637b7 to master...

@bors bors merged commit a126a73 into rust-lang:master Dec 7, 2017
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment