Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uprustc_trans: don't apply noalias on returned references. #46253
Conversation
eddyb
added
beta-nominated
T-compiler
labels
Nov 25, 2017
rust-highfive
assigned
michaelwoerister
Nov 25, 2017
This comment has been minimized.
This comment has been minimized.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
eddyb
force-pushed the
eddyb:return-aliasing
branch
from
57fe4d3
to
5eed95e
Nov 25, 2017
This comment has been minimized.
This comment has been minimized.
|
@bors r+ |
This comment has been minimized.
This comment has been minimized.
|
|
kennytm
added
the
S-waiting-on-bors
label
Nov 25, 2017
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Nov 26, 2017
kennytm
referenced this pull request
Nov 26, 2017
Closed
Regression in From<([u8; 16], u16)> for SocketAddr #46270
This comment has been minimized.
This comment has been minimized.
|
|
bors
merged commit 5eed95e
into
rust-lang:master
Nov 26, 2017
eddyb
deleted the
eddyb:return-aliasing
branch
Nov 26, 2017
alexcrichton
referenced this pull request
Nov 29, 2017
Closed
Beta regression: References to what's supposed to be static singleton don't pointer compare as equal on 1.23.0-beta.1 #46371
dtolnay
referenced this pull request
Nov 30, 2017
Closed
Test suite fails in test_net_socketaddr_compact #1100
This comment has been minimized.
This comment has been minimized.
|
As per the IRC discussion with @eddyb on Friday, I'll tentatively mark this as beta-accepted. @rust-lang/compiler, please veto within the next 15 hours if you don't think this is a good idea. I'll do the backport tomorrow. |
michaelwoerister
added
beta-accepted
and removed
beta-nominated
labels
Dec 4, 2017
bors
added a commit
that referenced
this pull request
Dec 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
eddyb commentedNov 25, 2017
In #45225 frozen returned
&Twere accidentally makednoalias, unlike&mut T.Return value
noaliasis only sound for functions that return dynamic allocations, e.g.Box, and using it on anything else can lead to miscompilation, as LLVM assumes certain usage patterns.Fixes #46239.