New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use suggestions instead of notes ref mismatches #46256

Merged
merged 1 commit into from Dec 2, 2017

Conversation

Projects
None yet
5 participants
@estebank
Contributor

estebank commented Nov 25, 2017

On type mismatch errors, use a suggestion when encountering minimal
differences in type differences due to refs, instead of a note.

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Nov 25, 2017

Collaborator

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

Collaborator

rust-highfive commented Nov 25, 2017

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@arielb1

This comment has been minimized.

Show comment
Hide comment
@arielb1

arielb1 Nov 25, 2017

Contributor

@bors r+

Contributor

arielb1 commented Nov 25, 2017

@bors r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 25, 2017

Contributor

📌 Commit a55f181 has been approved by arielb1

Contributor

bors commented Nov 25, 2017

📌 Commit a55f181 has been approved by arielb1

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 27, 2017

Contributor

☔️ The latest upstream changes (presumably #46168) made this pull request unmergeable. Please resolve the merge conflicts.

Contributor

bors commented Nov 27, 2017

☔️ The latest upstream changes (presumably #46168) made this pull request unmergeable. Please resolve the merge conflicts.

@estebank

This comment has been minimized.

Show comment
Hide comment
@estebank

estebank Nov 27, 2017

Contributor

@bors r=arielb1

Contributor

estebank commented Nov 27, 2017

@bors r=arielb1

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 27, 2017

Contributor

📌 Commit e457cbd has been approved by arielb1

Contributor

bors commented Nov 27, 2017

📌 Commit e457cbd has been approved by arielb1

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 29, 2017

Contributor

⌛️ Testing commit e457cbd with merge 033288f...

Contributor

bors commented Nov 29, 2017

⌛️ Testing commit e457cbd with merge 033288f...

bors added a commit that referenced this pull request Nov 29, 2017

Auto merge of #46256 - estebank:suggest-deref, r=arielb1
Use suggestions instead of notes ref mismatches

On type mismatch errors, use a suggestion when encountering minimal
differences in type differences due to refs, instead of a note.
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 29, 2017

Contributor

💔 Test failed - status-travis

Contributor

bors commented Nov 29, 2017

💔 Test failed - status-travis

@kennytm

This comment has been minimized.

Show comment
Hide comment
@kennytm
Member

kennytm commented Nov 29, 2017

arielb1 added a commit to arielb1/rust that referenced this pull request Nov 30, 2017

Rollup merge of rust-lang#46256 - estebank:suggest-deref, r=arielb1
Use suggestions instead of notes ref mismatches

On type mismatch errors, use a suggestion when encountering minimal
differences in type differences due to refs, instead of a note.

arielb1 added a commit to arielb1/rust that referenced this pull request Nov 30, 2017

Rollup merge of rust-lang#46256 - estebank:suggest-deref, r=arielb1
Use suggestions instead of notes ref mismatches

On type mismatch errors, use a suggestion when encountering minimal
differences in type differences due to refs, instead of a note.

arielb1 added a commit to arielb1/rust that referenced this pull request Nov 30, 2017

Rollup merge of rust-lang#46256 - estebank:suggest-deref, r=arielb1
Use suggestions instead of notes ref mismatches

On type mismatch errors, use a suggestion when encountering minimal
differences in type differences due to refs, instead of a note.

bors added a commit that referenced this pull request Nov 30, 2017

Auto merge of #46399 - arielb1:rollup, r=arielb1
Rollup of 11 pull requests

- Successful merges: #45880, #46256, #46280, #46290, #46343, #46349, #46368, #46370, #46384, #46385, #46386
- Failed merges:
@arielb1

This comment has been minimized.

Show comment
Hide comment
@arielb1

arielb1 Nov 30, 2017

Contributor

This appears to have a semantic conflict with #46249 (on the src/test/ui/suggestions/str-array-assignment.rs test).

@bors r-

Contributor

arielb1 commented Nov 30, 2017

This appears to have a semantic conflict with #46249 (on the src/test/ui/suggestions/str-array-assignment.rs test).

@bors r-

Use suggestions instead of notes ref mismatches
On type mismatch errors, use a suggestion when encountering minimal
differences in type differences due to refs, instead of a note.
@estebank

This comment has been minimized.

Show comment
Hide comment
@estebank

estebank Dec 1, 2017

Contributor

Rebased against latest master.

@bors r=arielb1

Contributor

estebank commented Dec 1, 2017

Rebased against latest master.

@bors r=arielb1

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 1, 2017

Contributor

📌 Commit 36faafe has been approved by arielb1

Contributor

bors commented Dec 1, 2017

📌 Commit 36faafe has been approved by arielb1

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 2, 2017

Contributor

⌛️ Testing commit 36faafe with merge b15a8ea...

Contributor

bors commented Dec 2, 2017

⌛️ Testing commit 36faafe with merge b15a8ea...

bors added a commit that referenced this pull request Dec 2, 2017

Auto merge of #46256 - estebank:suggest-deref, r=arielb1
Use suggestions instead of notes ref mismatches

On type mismatch errors, use a suggestion when encountering minimal
differences in type differences due to refs, instead of a note.
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 2, 2017

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: arielb1
Pushing b15a8ea to master...

Contributor

bors commented Dec 2, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: arielb1
Pushing b15a8ea to master...

@bors bors merged commit 36faafe into rust-lang:master Dec 2, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment