New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incr.comp.: Remove an unnecessary HIR access which enables hashing spans for type definitions. #46368

Merged
merged 1 commit into from Dec 2, 2017

Conversation

Projects
None yet
6 participants
@michaelwoerister
Contributor

michaelwoerister commented Nov 29, 2017

@eddyb

This comment has been minimized.

Show comment
Hide comment
@eddyb
Member

eddyb commented Nov 30, 2017

@bors r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 30, 2017

Contributor

📌 Commit 89dc8ae has been approved by eddyb

Contributor

bors commented Nov 30, 2017

📌 Commit 89dc8ae has been approved by eddyb

arielb1 added a commit to arielb1/rust that referenced this pull request Nov 30, 2017

Rollup merge of rust-lang#46368 - michaelwoerister:incr-comp-type-deb…
…uginfo-spans, r=eddyb

incr.comp.: Remove an unnecessary HIR access which enables hashing spans for type definitions.

r? @nikomatsakis

arielb1 added a commit to arielb1/rust that referenced this pull request Nov 30, 2017

Rollup merge of rust-lang#46368 - michaelwoerister:incr-comp-type-deb…
…uginfo-spans, r=eddyb

incr.comp.: Remove an unnecessary HIR access which enables hashing spans for type definitions.

r? @nikomatsakis

bors added a commit that referenced this pull request Nov 30, 2017

Auto merge of #46399 - arielb1:rollup, r=arielb1
Rollup of 11 pull requests

- Successful merges: #45880, #46256, #46280, #46290, #46343, #46349, #46368, #46370, #46384, #46385, #46386
- Failed merges:

arielb1 added a commit to arielb1/rust that referenced this pull request Nov 30, 2017

Rollup merge of rust-lang#46368 - michaelwoerister:incr-comp-type-deb…
…uginfo-spans, r=eddyb

incr.comp.: Remove an unnecessary HIR access which enables hashing spans for type definitions.

r? @nikomatsakis

arielb1 added a commit to arielb1/rust that referenced this pull request Nov 30, 2017

Rollup merge of rust-lang#46368 - michaelwoerister:incr-comp-type-deb…
…uginfo-spans, r=eddyb

incr.comp.: Remove an unnecessary HIR access which enables hashing spans for type definitions.

r? @nikomatsakis

bors added a commit that referenced this pull request Nov 30, 2017

Auto merge of #46404 - arielb1:rollup, r=arielb1
Rollup of 10 pull requests

- Successful merges: #45880, #46280, #46290, #46343, #46349, #46368, #46384, #46385, #46386, #46400
- Failed merges:

arielb1 added a commit to arielb1/rust that referenced this pull request Nov 30, 2017

Rollup merge of rust-lang#46368 - michaelwoerister:incr-comp-type-deb…
…uginfo-spans, r=eddyb

incr.comp.: Remove an unnecessary HIR access which enables hashing spans for type definitions.

r? @nikomatsakis

bors added a commit that referenced this pull request Nov 30, 2017

Auto merge of #46410 - arielb1:rollup, r=arielb1
Rollup of 12 pull requests

- Successful merges: #45880, #46280, #46290, #46343, #46349, #46368, #46370, #46384, #46385, #46386, #46392, #46400
- Failed merges:

bors added a commit that referenced this pull request Dec 1, 2017

Auto merge of #46410 - arielb1:rollup, r=arielb1
Rollup of 12 pull requests

- Successful merges: #45880, #46280, #46290, #46343, #46349, #46368, #46370, #46384, #46385, #46386, #46392, #46400
- Failed merges:
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 2, 2017

Contributor

⌛️ Testing commit 89dc8ae with merge 377decc...

Contributor

bors commented Dec 2, 2017

⌛️ Testing commit 89dc8ae with merge 377decc...

bors added a commit that referenced this pull request Dec 2, 2017

Auto merge of #46368 - michaelwoerister:incr-comp-type-debuginfo-span…
…s, r=eddyb

incr.comp.: Remove an unnecessary HIR access which enables hashing spans for type definitions.

r? @nikomatsakis
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 2, 2017

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 377decc to master...

Contributor

bors commented Dec 2, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 377decc to master...

@bors bors merged commit 89dc8ae into rust-lang:master Dec 2, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Mark-Simulacrum

This comment has been minimized.

Show comment
Hide comment
Member

Mark-Simulacrum commented Dec 3, 2017

@michaelwoerister

This comment has been minimized.

Show comment
Hide comment
@michaelwoerister

michaelwoerister Dec 4, 2017

Contributor

Thanks for the heads up, @Mark-Simulacrum. It's not entirely surprising, since we are hashing more and we detect more changes. Most of these newly detected changes are probably false positives of some kind.
It would be interesting though what exactly is going on here. It's probably that more codegen units get re-translated.

Contributor

michaelwoerister commented Dec 4, 2017

Thanks for the heads up, @Mark-Simulacrum. It's not entirely surprising, since we are hashing more and we detect more changes. Most of these newly detected changes are probably false positives of some kind.
It would be interesting though what exactly is going on here. It's probably that more codegen units get re-translated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment