Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incr.comp.: Remove an unnecessary HIR access which enables hashing spans for type definitions. #46368

Merged
merged 1 commit into from Dec 2, 2017

Conversation

Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
6 participants
@michaelwoerister @eddyb @bors @Mark-Simulacrum @kennytm @nikomatsakis
@michaelwoerister
Copy link
Contributor

michaelwoerister commented Nov 29, 2017

r? @nikomatsakis
@michaelwoerister
incr.comp.: Remove an unnecessary HIR access which enables hashing sp… 
…ans for type definitions.
Loading status checks…
89dc8ae

@rust-highfive rust-highfive assigned nikomatsakis Nov 29, 2017

@kennytm kennytm added the S-waiting-on-review label Nov 29, 2017

@eddyb

This comment has been minimized.

Sign in to view
Copy link
Member

eddyb commented Nov 30, 2017

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Nov 30, 2017

📌 Commit 89dc8ae has been approved by eddyb

arielb1 pushed a commit to arielb1/rust that referenced this pull request Nov 30, 2017

Ariel Ben-Yehuda
Rollup merge of rust-lang#46368 - michaelwoerister:incr-comp-type-deb… 
…uginfo-spans, r=eddyb

incr.comp.: Remove an unnecessary HIR access which enables hashing spans for type definitions.

r? @nikomatsakis
e5d4a7a

@arielb1 arielb1 referenced this pull request Nov 30, 2017

Closed

Rollup of 10 pull requests #46395

arielb1 pushed a commit to arielb1/rust that referenced this pull request Nov 30, 2017

Ariel Ben-Yehuda
Rollup merge of rust-lang#46368 - michaelwoerister:incr-comp-type-deb… 
…uginfo-spans, r=eddyb

incr.comp.: Remove an unnecessary HIR access which enables hashing spans for type definitions.

r? @nikomatsakis
aad68c0

@arielb1 arielb1 referenced this pull request Nov 30, 2017

Closed

Rollup of 11 pull requests #46399

bors added a commit that referenced this pull request Nov 30, 2017

@bors
Auto merge of #46399 - arielb1:rollup, r=arielb1 
Rollup of 11 pull requests

- Successful merges: #45880, #46256, #46280, #46290, #46343, #46349, #46368, #46370, #46384, #46385, #46386
- Failed merges:
Loading status checks…
8223d4b

arielb1 pushed a commit to arielb1/rust that referenced this pull request Nov 30, 2017

Ariel Ben-Yehuda
Rollup merge of rust-lang#46368 - michaelwoerister:incr-comp-type-deb… 
…uginfo-spans, r=eddyb

incr.comp.: Remove an unnecessary HIR access which enables hashing spans for type definitions.

r? @nikomatsakis
e3b27cd

arielb1 pushed a commit to arielb1/rust that referenced this pull request Nov 30, 2017

Ariel Ben-Yehuda
Rollup merge of rust-lang#46368 - michaelwoerister:incr-comp-type-deb… 
…uginfo-spans, r=eddyb

incr.comp.: Remove an unnecessary HIR access which enables hashing spans for type definitions.

r? @nikomatsakis
249e162

@arielb1 arielb1 referenced this pull request Nov 30, 2017

Closed

Rollup of 10 pull requests #46404

@kennytm kennytm added S-waiting-on-bors and removed S-waiting-on-review labels Nov 30, 2017

bors added a commit that referenced this pull request Nov 30, 2017

@bors
Auto merge of #46404 - arielb1:rollup, r=arielb1 
Rollup of 10 pull requests

- Successful merges: #45880, #46280, #46290, #46343, #46349, #46368, #46384, #46385, #46386, #46400
- Failed merges:
Loading status checks…
06490d1

arielb1 pushed a commit to arielb1/rust that referenced this pull request Nov 30, 2017

Ariel Ben-Yehuda
Rollup merge of rust-lang#46368 - michaelwoerister:incr-comp-type-deb… 
…uginfo-spans, r=eddyb

incr.comp.: Remove an unnecessary HIR access which enables hashing spans for type definitions.

r? @nikomatsakis
79d076a

@arielb1 arielb1 referenced this pull request Nov 30, 2017

Closed

Rollup of 12 pull requests #46410

bors added a commit that referenced this pull request Nov 30, 2017

@bors
Auto merge of #46410 - arielb1:rollup, r=arielb1 
Rollup of 12 pull requests

- Successful merges: #45880, #46280, #46290, #46343, #46349, #46368, #46370, #46384, #46385, #46386, #46392, #46400
- Failed merges:
Loading status checks…
738d418

bors added a commit that referenced this pull request Dec 1, 2017

@bors
Auto merge of #46410 - arielb1:rollup, r=arielb1 
Rollup of 12 pull requests

- Successful merges: #45880, #46280, #46290, #46343, #46349, #46368, #46370, #46384, #46385, #46386, #46392, #46400
- Failed merges:
Loading status checks…
5d5cf1a
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 2, 2017

⌛️ Testing commit 89dc8ae with merge 377decc...

bors added a commit that referenced this pull request Dec 2, 2017

@bors
Auto merge of #46368 - michaelwoerister:incr-comp-type-debuginfo-span… 
…s, r=eddyb

incr.comp.: Remove an unnecessary HIR access which enables hashing spans for type definitions.

r? @nikomatsakis
Loading status checks…
377decc
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 2, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 377decc to master...

@bors bors merged commit 89dc8ae into rust-lang:master Dec 2, 2017
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Mark-Simulacrum

This comment has been minimized.

Sign in to view
Copy link
Member

Mark-Simulacrum commented Dec 3, 2017

This appears to have regressed performance on perf.rlo (http://perf.rust-lang.org/compare.html?start=9053fdd411e81910a86b68f0a1c3b3ca084bff62&end=377decc352e58aa2bb0e2deb2eb66c3e7241a622&stat=wall-time): was that expected?
@michaelwoerister

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

michaelwoerister commented Dec 4, 2017

Thanks for the heads up, @Mark-Simulacrum. It's not entirely surprising, since we are hashing more and we detect more changes. Most of these newly detected changes are probably false positives of some kind.
It would be interesting though what exactly is going on here. It's probably that more codegen units get re-translated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.