New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incr.comp.: Remove ability to produce incr. comp. hashes during metadata export. #46370

Merged
merged 2 commits into from Dec 1, 2017

Conversation

Projects
None yet
6 participants
@michaelwoerister
Contributor

michaelwoerister commented Nov 29, 2017

This functionality has been superseded by on-import hashing, which can be less conservative and does not require extra infrastructure.

r? @nikomatsakis

@eddyb

This comment has been minimized.

Show comment
Hide comment
@eddyb
Member

eddyb commented Nov 30, 2017

@bors r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 30, 2017

Contributor

📌 Commit 7ebccbb has been approved by eddyb

Contributor

bors commented Nov 30, 2017

📌 Commit 7ebccbb has been approved by eddyb

@michaelwoerister

This comment has been minimized.

Show comment
Hide comment
@michaelwoerister

michaelwoerister Nov 30, 2017

Contributor

@bors p=1

Bumping priority because it's blocking incr. comp. and high bitrot risk.

Contributor

michaelwoerister commented Nov 30, 2017

@bors p=1

Bumping priority because it's blocking incr. comp. and high bitrot risk.

arielb1 added a commit to arielb1/rust that referenced this pull request Nov 30, 2017

Rollup merge of rust-lang#46370 - michaelwoerister:rm-metadata-hashin…
…g, r=eddyb

incr.comp.: Remove ability to produce incr. comp. hashes during metadata export.

This functionality has been superseded by on-import hashing, which can be less conservative and does not require extra infrastructure.

r? @nikomatsakis

bors added a commit that referenced this pull request Nov 30, 2017

Auto merge of #46399 - arielb1:rollup, r=arielb1
Rollup of 11 pull requests

- Successful merges: #45880, #46256, #46280, #46290, #46343, #46349, #46368, #46370, #46384, #46385, #46386
- Failed merges:
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 30, 2017

Contributor

⌛️ Testing commit 7ebccbb with merge d170379...

Contributor

bors commented Nov 30, 2017

⌛️ Testing commit 7ebccbb with merge d170379...

bors added a commit that referenced this pull request Nov 30, 2017

Auto merge of #46370 - michaelwoerister:rm-metadata-hashing, r=eddyb
incr.comp.: Remove ability to produce incr. comp. hashes during metadata export.

This functionality has been superseded by on-import hashing, which can be less conservative and does not require extra infrastructure.

r? @nikomatsakis
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 30, 2017

Contributor

💔 Test failed - status-appveyor

Contributor

bors commented Nov 30, 2017

💔 Test failed - status-appveyor

@arielb1

This comment has been minimized.

Show comment
Hide comment
@arielb1

arielb1 Nov 30, 2017

Contributor

Appveyor 3h timeout for some reason, looking at the time log seems like general slowness, and there appears to be a large amount of variance between commits.

@bors retry

Contributor

arielb1 commented Nov 30, 2017

Appveyor 3h timeout for some reason, looking at the time log seems like general slowness, and there appears to be a large amount of variance between commits.

@bors retry

arielb1 added a commit to arielb1/rust that referenced this pull request Nov 30, 2017

Rollup merge of rust-lang#46370 - michaelwoerister:rm-metadata-hashin…
…g, r=eddyb

incr.comp.: Remove ability to produce incr. comp. hashes during metadata export.

This functionality has been superseded by on-import hashing, which can be less conservative and does not require extra infrastructure.

r? @nikomatsakis

bors added a commit that referenced this pull request Nov 30, 2017

Auto merge of #46410 - arielb1:rollup, r=arielb1
Rollup of 12 pull requests

- Successful merges: #45880, #46280, #46290, #46343, #46349, #46368, #46370, #46384, #46385, #46386, #46392, #46400
- Failed merges:
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 1, 2017

Contributor

⌛️ Testing commit 7ebccbb with merge d8a60c9...

Contributor

bors commented Dec 1, 2017

⌛️ Testing commit 7ebccbb with merge d8a60c9...

bors added a commit that referenced this pull request Dec 1, 2017

Auto merge of #46370 - michaelwoerister:rm-metadata-hashing, r=eddyb
incr.comp.: Remove ability to produce incr. comp. hashes during metadata export.

This functionality has been superseded by on-import hashing, which can be less conservative and does not require extra infrastructure.

r? @nikomatsakis
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 1, 2017

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing d8a60c9 to master...

Contributor

bors commented Dec 1, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing d8a60c9 to master...

@bors bors merged commit 7ebccbb into rust-lang:master Dec 1, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

bors added a commit that referenced this pull request Dec 1, 2017

Auto merge of #46410 - arielb1:rollup, r=arielb1
Rollup of 12 pull requests

- Successful merges: #45880, #46280, #46290, #46343, #46349, #46368, #46370, #46384, #46385, #46386, #46392, #46400
- Failed merges:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment