Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incr.comp.: Make traits::VTable encodable and decodable. #46400

Merged
merged 1 commit into from Dec 2, 2017

Conversation

Reviewers

@eddyb eddyb

Assignees

@eddyb eddyb

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
4 participants
@michaelwoerister @eddyb @bors @kennytm
@michaelwoerister
Copy link
Contributor

michaelwoerister commented Nov 30, 2017

Make vtables encodable so we can cache the trans_fulfill_obligation query at some point.

r? @eddyb

@rust-highfive rust-highfive assigned eddyb Nov 30, 2017

@eddyb

eddyb reviewed Nov 30, 2017
View changes

src/librustc/traits/structural_impls.rs Outdated
const VTABLE_BUILTIN: u8 = 4;
const VTABLE_CLOSURE: u8 = 5;
const VTABLE_FN_POINTER: u8 = 6;
const VTABLE_GENERATOR: u8 = 7;

This comment has been minimized.

Sign in to view
Copy link
@eddyb

eddyb Nov 30, 2017 •
edited

Member

Wait, since when do we do this manually?!

@michaelwoerister michaelwoerister force-pushed the michaelwoerister:vtable-encodable branch from bdfe440 to 780f4ed Nov 30, 2017

@eddyb

eddyb approved these changes Nov 30, 2017
View changes

@eddyb

This comment has been minimized.

Sign in to view
Copy link
Member

eddyb commented Nov 30, 2017

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Nov 30, 2017

📌 Commit 780f4ed has been approved by eddyb

@kennytm kennytm added S-waiting-on-review S-waiting-on-bors and removed S-waiting-on-review labels Nov 30, 2017

arielb1 pushed a commit to arielb1/rust that referenced this pull request Nov 30, 2017

Ariel Ben-Yehuda
Rollup merge of rust-lang#46400 - michaelwoerister:vtable-encodable, … 
…r=eddyb

incr.comp.: Make traits::VTable encodable and decodable.

Make vtables encodable so we can cache the `trans_fulfill_obligation` query at some point.

r? @eddyb
062def4

arielb1 pushed a commit to arielb1/rust that referenced this pull request Nov 30, 2017

Ariel Ben-Yehuda
Rollup merge of rust-lang#46400 - michaelwoerister:vtable-encodable, … 
…r=eddyb

incr.comp.: Make traits::VTable encodable and decodable.

Make vtables encodable so we can cache the `trans_fulfill_obligation` query at some point.

r? @eddyb
c2b48c1

@arielb1 arielb1 referenced this pull request Nov 30, 2017

Closed

Rollup of 10 pull requests #46404

bors added a commit that referenced this pull request Nov 30, 2017

@bors
Auto merge of #46404 - arielb1:rollup, r=arielb1 
Rollup of 10 pull requests

- Successful merges: #45880, #46280, #46290, #46343, #46349, #46368, #46384, #46385, #46386, #46400
- Failed merges:
Loading status checks…
06490d1

@arielb1 arielb1 referenced this pull request Nov 30, 2017

Closed

Rollup of 12 pull requests #46410

arielb1 pushed a commit to arielb1/rust that referenced this pull request Nov 30, 2017

Ariel Ben-Yehuda
Rollup merge of rust-lang#46400 - michaelwoerister:vtable-encodable, … 
…r=eddyb

incr.comp.: Make traits::VTable encodable and decodable.

Make vtables encodable so we can cache the `trans_fulfill_obligation` query at some point.

r? @eddyb
5b06023

bors added a commit that referenced this pull request Nov 30, 2017

@bors
Auto merge of #46410 - arielb1:rollup, r=arielb1 
Rollup of 12 pull requests

- Successful merges: #45880, #46280, #46290, #46343, #46349, #46368, #46370, #46384, #46385, #46386, #46392, #46400
- Failed merges:
Loading status checks…
738d418

bors added a commit that referenced this pull request Dec 1, 2017

@bors
Auto merge of #46410 - arielb1:rollup, r=arielb1 
Rollup of 12 pull requests

- Successful merges: #45880, #46280, #46290, #46343, #46349, #46368, #46370, #46384, #46385, #46386, #46392, #46400
- Failed merges:
Loading status checks…
5d5cf1a

kennytm added a commit to kennytm/rust that referenced this pull request Dec 1, 2017

@kennytm
Rollup merge of rust-lang#46400 - michaelwoerister:vtable-encodable, … 
…r=eddyb

incr.comp.: Make traits::VTable encodable and decodable.

Make vtables encodable so we can cache the `trans_fulfill_obligation` query at some point.

r? @eddyb
b86a47f

@kennytm kennytm referenced this pull request Dec 1, 2017

Merged

Rollup of 13 pull requests #46430

bors added a commit that referenced this pull request Dec 1, 2017

@bors
Auto merge of #46430 - kennytm:rollup, r=kennytm 
Rollup of 13 pull requests

- Successful merges: #45880, #46280, #46373, #46376, #46385, #46386, #46387, #46392, #46400, #46401, #46405, #46412, #46421
- Failed merges:
Loading status checks…
7051754

@bors bors merged commit 780f4ed into rust-lang:master Dec 2, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.