Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upincr.comp.: Incorporate the stable commandline arg hash and SVHs of upstream crates into the SVH. #46427
Conversation
rust-highfive
assigned
nikomatsakis
Dec 1, 2017
kennytm
added
the
S-waiting-on-review
label
Dec 1, 2017
michaelwoerister
referenced this pull request
Dec 4, 2017
Open
Moving some code around results in linking error with incremental comp #46475
This comment has been minimized.
This comment has been minimized.
|
@bors r+ |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
@bors p=1 Important to get incremental tests passing. |
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Dec 4, 2017
This comment has been minimized.
This comment has been minimized.
|
|
bors
merged commit 8129c53
into
rust-lang:master
Dec 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
michaelwoerister commentedDec 1, 2017
So far the SVH detected changes in the HIR, which is already very sensitive, but in order for
eval_alwaysqueries to also be sensitive to changes in upstream crates, the SVH also needs to capture changes there.This PR fixes rust-icci/crossbeam, but I have not yet been able to come up with a minimal regression test.
r? @nikomatsakis