New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deduplication of items #46433

Merged
merged 1 commit into from Dec 3, 2017

Conversation

Projects
None yet
6 participants
@GuillaumeGomez
Member

GuillaumeGomez commented Dec 1, 2017

@QuietMisdreavus

This comment has been minimized.

Show comment
Hide comment
@QuietMisdreavus
Member

QuietMisdreavus commented Dec 1, 2017

@bors r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 1, 2017

Contributor

📌 Commit 30734c4 has been approved by QuietMisdreavus

Contributor

bors commented Dec 1, 2017

📌 Commit 30734c4 has been approved by QuietMisdreavus

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 3, 2017

Contributor

⌛️ Testing commit 30734c4 with merge d0ebb4d...

Contributor

bors commented Dec 3, 2017

⌛️ Testing commit 30734c4 with merge d0ebb4d...

bors added a commit that referenced this pull request Dec 3, 2017

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 3, 2017

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: QuietMisdreavus
Pushing d0ebb4d to master...

Contributor

bors commented Dec 3, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: QuietMisdreavus
Pushing d0ebb4d to master...

@bors bors merged commit 30734c4 into rust-lang:master Dec 3, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:dedup-items branch Dec 4, 2017

@durka

This comment has been minimized.

Show comment
Hide comment
@durka

durka Dec 12, 2017

Contributor

Backport?

Contributor

durka commented Dec 12, 2017

Backport?

bors added a commit that referenced this pull request Dec 23, 2017

Auto merge of #46886 - durka:doc-search-backports, r=GuillaumeGomez
[beta] Doc search backports

This is a backport of #46081, #46175, #46433, and #46672. They all merged cleanly but I haven't tried a build; let's see what Travis says.

These PRs fix pretty annoying issues with doc search and so I think it's important they don't slip to stable, but these PRs have *NOT* been `beta-accepted` yet.

cc @steveklabnik @GuillaumeGomez can you tag the docs team to talk about beta-acceptance?
@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Jan 10, 2018

Member

Looks like we forgot to backport this to 1.23.0 (sorry about that!) so removing beta tags

Member

alexcrichton commented Jan 10, 2018

Looks like we forgot to backport this to 1.23.0 (sorry about that!) so removing beta tags

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Jan 10, 2018

Member

Er sorry looks like this was backported in #46886

Member

alexcrichton commented Jan 10, 2018

Er sorry looks like this was backported in #46886

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment