New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[needs perf run] Try to improve LLVM pass ordering #46739

Merged
merged 2 commits into from Jan 5, 2018

Conversation

Projects
None yet
7 participants
@arielb1
Contributor

arielb1 commented Dec 15, 2017

Fixes #45466

@arielb1

This comment has been minimized.

Show comment
Hide comment
@arielb1

arielb1 Dec 15, 2017

Contributor

@bors try

Contributor

arielb1 commented Dec 15, 2017

@bors try

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Dec 15, 2017

Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

Collaborator

rust-highfive commented Dec 15, 2017

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 15, 2017

Contributor

⌛️ Trying commit c3763ed with merge 1e8a44a...

Contributor

bors commented Dec 15, 2017

⌛️ Trying commit c3763ed with merge 1e8a44a...

bors added a commit that referenced this pull request Dec 15, 2017

Auto merge of #46739 - arielb1:simple-loops, r=<try>
[needs perf run] Simplify CFG after IndVarSimplify

Fixes #45466
@arielb1

This comment has been minimized.

Show comment
Hide comment
@arielb1

arielb1 Dec 15, 2017

Contributor

Let's check the perf impact of this

Contributor

arielb1 commented Dec 15, 2017

Let's check the perf impact of this

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 15, 2017

Contributor

☀️ Test successful - status-travis
State: approved= try=True

Contributor

bors commented Dec 15, 2017

☀️ Test successful - status-travis
State: approved= try=True

@arielb1

This comment has been minimized.

Show comment
Hide comment
@arielb1

arielb1 Dec 15, 2017

Contributor

@Mark-Simulacrum

Could you do a perf run on this?

Contributor

arielb1 commented Dec 15, 2017

@Mark-Simulacrum

Could you do a perf run on this?

@Mark-Simulacrum

This comment has been minimized.

Show comment
Hide comment
@Mark-Simulacrum

Mark-Simulacrum Dec 15, 2017

Member

Not quite right now as I don't have a connection to the perf machine, I'm waiting on @alexcrichton for it... hopefully next week after all hands, though.

Member

Mark-Simulacrum commented Dec 15, 2017

Not quite right now as I don't have a connection to the perf machine, I'm waiting on @alexcrichton for it... hopefully next week after all hands, though.

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Dec 16, 2017

Member

Yes unfortunately the perf machine is offline right now, we'll have access to it again this coming Monday at the latest.

Member

alexcrichton commented Dec 16, 2017

Yes unfortunately the perf machine is offline right now, we'll have access to it again this coming Monday at the latest.

@kennytm

This comment has been minimized.

Show comment
Hide comment
@kennytm

kennytm Dec 20, 2017

Member

@Mark-Simulacrum @alexcrichton Is the perf machine ready now?

Member

kennytm commented Dec 20, 2017

@Mark-Simulacrum @alexcrichton Is the perf machine ready now?

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Dec 20, 2017

Member

Ah yes, it is indeed back online.

Member

alexcrichton commented Dec 20, 2017

Ah yes, it is indeed back online.

@Mark-Simulacrum

This comment has been minimized.

Show comment
Hide comment
@Mark-Simulacrum

Mark-Simulacrum Dec 20, 2017

Member

Perf run queued.

Member

Mark-Simulacrum commented Dec 20, 2017

Perf run queued.

@kennytm

This comment has been minimized.

Show comment
Hide comment
@arielb1

This comment has been minimized.

Show comment
Hide comment
@arielb1

arielb1 Dec 22, 2017

Contributor

@kennytm

I do see a clear 1-2% regression in compile-time for opt builds

Contributor

arielb1 commented Dec 22, 2017

@kennytm

I do see a clear 1-2% regression in compile-time for opt builds

@arielb1

This comment has been minimized.

Show comment
Hide comment
@arielb1

arielb1 Dec 23, 2017

Contributor

Now with a more aggressive try.

I think this needs a merge of my PR on rust-lang/llvm, and then I can try?

Contributor

arielb1 commented Dec 23, 2017

Now with a more aggressive try.

I think this needs a merge of my PR on rust-lang/llvm, and then I can try?

@arielb1

This comment has been minimized.

Show comment
Hide comment
@arielb1

arielb1 Dec 25, 2017

Contributor

@Mark-Simulacrum

Can I have a new perf run on this more aggressive pass ordering?

Contributor

arielb1 commented Dec 25, 2017

@Mark-Simulacrum

Can I have a new perf run on this more aggressive pass ordering?

@arielb1

This comment has been minimized.

Show comment
Hide comment
@arielb1

arielb1 Dec 25, 2017

Contributor

This also seems to fix #46542. Looks like the earlier IndVarSimplify is really helping with ranges.

Contributor

arielb1 commented Dec 25, 2017

This also seems to fix #46542. Looks like the earlier IndVarSimplify is really helping with ranges.

@arielb1 arielb1 changed the title from [needs perf run] Simplify CFG after IndVarSimplify to [needs perf run] Try to improve LLVM pass ordering Dec 25, 2017

@arielb1

This comment has been minimized.

Show comment
Hide comment
@arielb1

arielb1 Dec 25, 2017

Contributor

@bors try

Contributor

arielb1 commented Dec 25, 2017

@bors try

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 25, 2017

Contributor

⌛️ Trying commit 6163df4 with merge 8a453b2...

Contributor

bors commented Dec 25, 2017

⌛️ Trying commit 6163df4 with merge 8a453b2...

bors added a commit that referenced this pull request Dec 25, 2017

Auto merge of #46739 - arielb1:simple-loops, r=<try>
[needs perf run] Try to improve LLVM pass ordering

Fixes #45466
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 25, 2017

Contributor

☀️ Test successful - status-travis
State: approved= try=True

Contributor

bors commented Dec 25, 2017

☀️ Test successful - status-travis
State: approved= try=True

@Mark-Simulacrum

This comment has been minimized.

Show comment
Hide comment
@Mark-Simulacrum

Mark-Simulacrum Dec 26, 2017

Member

Perf queued.

Member

Mark-Simulacrum commented Dec 26, 2017

Perf queued.

@kennytm

This comment has been minimized.

Show comment
Hide comment
Member

kennytm commented Dec 27, 2017

@nikomatsakis

This comment has been minimized.

Show comment
Hide comment
@nikomatsakis

nikomatsakis Jan 3, 2018

Contributor

Nominating for discussion in the @rust-lang/compiler meeting. This causes a small regression in compile time, but enables us to optimize #45466 again. Should we land? I think yes.

Contributor

nikomatsakis commented Jan 3, 2018

Nominating for discussion in the @rust-lang/compiler meeting. This causes a small regression in compile time, but enables us to optimize #45466 again. Should we land? I think yes.

@nikomatsakis

This comment has been minimized.

Show comment
Hide comment
@nikomatsakis

nikomatsakis Jan 4, 2018

Contributor

@bors r+

After discussion in the compiler meeting we decided to go forward with this PR. However, there is a sense that we need to develop a more comprehensive runtime perf suite so that we can have a better idea of the overall impact of changes like this.

Contributor

nikomatsakis commented Jan 4, 2018

@bors r+

After discussion in the compiler meeting we decided to go forward with this PR. However, there is a sense that we need to develop a more comprehensive runtime perf suite so that we can have a better idea of the overall impact of changes like this.

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jan 4, 2018

Contributor

📌 Commit 6163df4 has been approved by nikomatsakis

Contributor

bors commented Jan 4, 2018

📌 Commit 6163df4 has been approved by nikomatsakis

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jan 4, 2018

Contributor

⌛️ Testing commit 6163df4 with merge 4fd62f2...

Contributor

bors commented Jan 4, 2018

⌛️ Testing commit 6163df4 with merge 4fd62f2...

bors added a commit that referenced this pull request Jan 4, 2018

Auto merge of #46739 - arielb1:simple-loops, r=nikomatsakis
[needs perf run] Try to improve LLVM pass ordering

Fixes #45466
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jan 4, 2018

Contributor

💔 Test failed - status-appveyor

Contributor

bors commented Jan 4, 2018

💔 Test failed - status-appveyor

@kennytm

This comment has been minimized.

Show comment
Hide comment
@kennytm

kennytm Jan 4, 2018

Member

@bors retry #46903 3 hour timeout

It is happening very frequently recently 😞

Member

kennytm commented Jan 4, 2018

@bors retry #46903 3 hour timeout

It is happening very frequently recently 😞

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jan 5, 2018

Contributor

⌛️ Testing commit 6163df4 with merge 5e66887...

Contributor

bors commented Jan 5, 2018

⌛️ Testing commit 6163df4 with merge 5e66887...

bors added a commit that referenced this pull request Jan 5, 2018

Auto merge of #46739 - arielb1:simple-loops, r=nikomatsakis
[needs perf run] Try to improve LLVM pass ordering

Fixes #45466
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jan 5, 2018

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 5e66887 to master...

Contributor

bors commented Jan 5, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 5e66887 to master...

@bors bors merged commit 6163df4 into rust-lang:master Jan 5, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment