New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure separate activations only occur for assignments to locals #46887

Merged
merged 1 commit into from Dec 21, 2017

Conversation

Projects
None yet
5 participants
@pnkfelix
Member

pnkfelix commented Dec 20, 2017

Ensure separate activations only occur for assignments to locals, not projections.

Fix #46746.

(I didn't make a regression test because we do not really have a good way to directly express the case that we are trying to catch, because we cannot write MIR directly.)

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Dec 20, 2017

Collaborator

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

Collaborator

rust-highfive commented Dec 20, 2017

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@arielb1

This comment has been minimized.

Show comment
Hide comment
@arielb1

arielb1 Dec 20, 2017

Contributor

I would say "please change the comment into something more descriptive", but what I really want is to write a spec and link to it.

@bors r+ rollup

Contributor

arielb1 commented Dec 20, 2017

I would say "please change the comment into something more descriptive", but what I really want is to write a spec and link to it.

@bors r+ rollup

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 20, 2017

Contributor

📌 Commit a0e1d50 has been approved by arielb1

Contributor

bors commented Dec 20, 2017

📌 Commit a0e1d50 has been approved by arielb1

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 21, 2017

Rollup merge of rust-lang#46887 - pnkfelix:ensure-activations-are-fro…
…m-assignments-to-locals, r=arielb1

Ensure separate activations only occur for assignments to locals

Ensure separate activations only occur for assignments to locals, not projections.

Fix rust-lang#46746.

(I didn't make a regression test because we do not really have a good way to directly express the case that we are trying to catch, because we cannot write MIR directly.)

bors added a commit that referenced this pull request Dec 21, 2017

Auto merge of #46904 - GuillaumeGomez:rollup, r=GuillaumeGomez
Rollup of 5 pull requests

- Successful merges: #46827, #46853, #46860, #46861, #46887
- Failed merges:

@bors bors merged commit a0e1d50 into rust-lang:master Dec 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment