New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: Set release mode cgus to 16 by default #46910

Merged
merged 1 commit into from Dec 25, 2017

Conversation

Projects
None yet
9 participants
@alexcrichton
Member

alexcrichton commented Dec 21, 2017

This commit is the next attempt to enable multiple codegen units by default in
release mode, getting some of those sweet, sweet parallelism wins by running
codegen in parallel. Performance should not be lost due to ThinLTO being on by
default as well.

Closes #45320

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Dec 21, 2017

Collaborator

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

Collaborator

rust-highfive commented Dec 21, 2017

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton
Member

alexcrichton commented Dec 21, 2017

@michaelwoerister

This comment has been minimized.

Show comment
Hide comment
@michaelwoerister

michaelwoerister Dec 21, 2017

Contributor

@bors r+

Let's try it. We can easily revert before the next release if there's a major problem.

Contributor

michaelwoerister commented Dec 21, 2017

@bors r+

Let's try it. We can easily revert before the next release if there's a major problem.

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 21, 2017

Contributor

📌 Commit 24834eb has been approved by michaelwoerister

Contributor

bors commented Dec 21, 2017

📌 Commit 24834eb has been approved by michaelwoerister

kennytm added a commit to kennytm/rust that referenced this pull request Dec 23, 2017

Rollup merge of rust-lang#46910 - alexcrichton:thinlto-default, r=mic…
…haelwoerister

rustc: Set release mode cgus to 16 by default

This commit is the next attempt to enable multiple codegen units by default in
release mode, getting some of those sweet, sweet parallelism wins by running
codegen in parallel. Performance should not be lost due to ThinLTO being on by
default as well.

Closes rust-lang#45320

bors added a commit that referenced this pull request Dec 23, 2017

Auto merge of #46965 - kennytm:rollup, r=kennytm
Rollup of 10 pull requests

- Successful merges: #46888, #46910, #46924, #46926, #46928, #46930, #46933, #46939, #46940, #46943
- Failed merges: #46954

bors added a commit that referenced this pull request Dec 23, 2017

Auto merge of #46965 - kennytm:rollup, r=kennytm
Rollup of 9 pull requests

- Successful merges: #46888, #46910, #46926, #46928, #46930, #46933, #46939, #46940, #46943
- Failed merges: #46924, #46954

kennytm added a commit to kennytm/rust that referenced this pull request Dec 23, 2017

Rollup merge of rust-lang#46910 - alexcrichton:thinlto-default, r=mic…
…haelwoerister

rustc: Set release mode cgus to 16 by default

This commit is the next attempt to enable multiple codegen units by default in
release mode, getting some of those sweet, sweet parallelism wins by running
codegen in parallel. Performance should not be lost due to ThinLTO being on by
default as well.

Closes rust-lang#45320

bors added a commit that referenced this pull request Dec 23, 2017

Auto merge of #46967 - kennytm:rollup, r=kennytm
Rollup of 10 pull requests

- Successful merges: #46888, #46894, #46910, #46928, #46930, #46933, #46937, #46939, #46940, #46943
- Failed merges: #46924, #46954
@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton
Member

alexcrichton commented Dec 23, 2017

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Dec 23, 2017

Member

I've opened an LLVM bug for that failure.

Member

alexcrichton commented Dec 23, 2017

I've opened an LLVM bug for that failure.

rustc: Set release mode cgus to 16 by default
This commit is the next attempt to enable multiple codegen units by default in
release mode, getting some of those sweet, sweet parallelism wins by running
codegen in parallel. Performance should not be lost due to ThinLTO being on by
default as well.

Closes #45320
@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Dec 24, 2017

Member

@bors: r=michaelwoerister

Member

alexcrichton commented Dec 24, 2017

@bors: r=michaelwoerister

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 24, 2017

Contributor

📌 Commit b5361d0 has been approved by michaelwoerister

Contributor

bors commented Dec 24, 2017

📌 Commit b5361d0 has been approved by michaelwoerister

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 25, 2017

Contributor

⌛️ Testing commit b5361d0 with merge ae65dcc...

Contributor

bors commented Dec 25, 2017

⌛️ Testing commit b5361d0 with merge ae65dcc...

bors added a commit that referenced this pull request Dec 25, 2017

Auto merge of #46910 - alexcrichton:thinlto-default, r=michaelwoerister
rustc: Set release mode cgus to 16 by default

This commit is the next attempt to enable multiple codegen units by default in
release mode, getting some of those sweet, sweet parallelism wins by running
codegen in parallel. Performance should not be lost due to ThinLTO being on by
default as well.

Closes #45320
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Dec 25, 2017

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: michaelwoerister
Pushing ae65dcc to master...

Contributor

bors commented Dec 25, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: michaelwoerister
Pushing ae65dcc to master...

@bors bors merged commit b5361d0 into rust-lang:master Dec 25, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@alexcrichton alexcrichton deleted the alexcrichton:thinlto-default branch Dec 25, 2017

@bluss bluss added the relnotes label Dec 25, 2017

@leonardo-m

This comment has been minimized.

Show comment
Hide comment
@leonardo-m

leonardo-m Dec 26, 2017

Probably because of this I am seeing nearly halved compilation times. (But I am seeing a problem I'll file soon, I don't know if it's the same LLVM failure reported above. Edit: it's #47015 ).

leonardo-m commented Dec 26, 2017

Probably because of this I am seeing nearly halved compilation times. (But I am seeing a problem I'll file soon, I don't know if it's the same LLVM failure reported above. Edit: it's #47015 ).

@Aowassoto

This comment has been minimized.

Show comment
Hide comment
@Aowassoto

Aowassoto commented Jun 17, 2018

Jsn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment