Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: Set release mode cgus to 16 by default #46910

Merged
merged 1 commit into from Dec 25, 2017

Conversation

Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-bors relnotes
Projects
None yet
Milestone
No milestone
9 participants
@alexcrichton @rust-highfive @michaelwoerister @bors @leonardo-m @Aowassoto @kennytm @estebank @bluss
@alexcrichton
Copy link
Member

alexcrichton commented Dec 21, 2017

This commit is the next attempt to enable multiple codegen units by default in
release mode, getting some of those sweet, sweet parallelism wins by running
codegen in parallel. Performance should not be lost due to ThinLTO being on by
default as well.

Closes #45320

@rust-highfive rust-highfive assigned estebank Dec 21, 2017

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Dec 21, 2017

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Dec 21, 2017

r? @michaelwoerister

@rust-highfive rust-highfive assigned michaelwoerister and unassigned estebank Dec 21, 2017

@michaelwoerister

This comment has been minimized.

Sign in to view
Copy link
Contributor

michaelwoerister commented Dec 21, 2017

@bors r+

Let's try it. We can easily revert before the next release if there's a major problem.
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 21, 2017

📌 Commit 24834eb has been approved by michaelwoerister

@kennytm kennytm added the S-waiting-on-bors label Dec 21, 2017

kennytm added a commit to kennytm/rust that referenced this pull request Dec 23, 2017

@kennytm
Rollup merge of rust-lang#46910 - alexcrichton:thinlto-default, r=mic… 
…haelwoerister

rustc: Set release mode cgus to 16 by default

This commit is the next attempt to enable multiple codegen units by default in
release mode, getting some of those sweet, sweet parallelism wins by running
codegen in parallel. Performance should not be lost due to ThinLTO being on by
default as well.

Closes rust-lang#45320
f196e9b

@kennytm kennytm referenced this pull request Dec 23, 2017

Closed

Rollup of 9 pull requests #46965

bors added a commit that referenced this pull request Dec 23, 2017

@bors
Auto merge of #46965 - kennytm:rollup, r=kennytm 
Rollup of 10 pull requests

- Successful merges: #46888, #46910, #46924, #46926, #46928, #46930, #46933, #46939, #46940, #46943
- Failed merges: #46954
Loading status checks…
94af9f9

bors added a commit that referenced this pull request Dec 23, 2017

@bors
Auto merge of #46965 - kennytm:rollup, r=kennytm 
Rollup of 9 pull requests

- Successful merges: #46888, #46910, #46926, #46928, #46930, #46933, #46939, #46940, #46943
- Failed merges: #46924, #46954
Loading status checks…
b9e5b04

kennytm added a commit to kennytm/rust that referenced this pull request Dec 23, 2017

@kennytm
Rollup merge of rust-lang#46910 - alexcrichton:thinlto-default, r=mic… 
…haelwoerister

rustc: Set release mode cgus to 16 by default

This commit is the next attempt to enable multiple codegen units by default in
release mode, getting some of those sweet, sweet parallelism wins by running
codegen in parallel. Performance should not be lost due to ThinLTO being on by
default as well.

Closes rust-lang#45320
271e291

@kennytm kennytm referenced this pull request Dec 23, 2017

Closed

Rollup of 10 pull requests #46967

bors added a commit that referenced this pull request Dec 23, 2017

@bors
Auto merge of #46967 - kennytm:rollup, r=kennytm 
Rollup of 10 pull requests

- Successful merges: #46888, #46894, #46910, #46928, #46930, #46933, #46937, #46939, #46940, #46943
- Failed merges: #46924, #46954
Loading status checks…
f1d2cc1
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Dec 23, 2017

@bors: r-

causes this failure

@alexcrichton alexcrichton force-pushed the alexcrichton:thinlto-default branch from 3230850 to 8e25bf3 Dec 23, 2017

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Dec 23, 2017

I've opened an LLVM bug for that failure.

@alexcrichton alexcrichton force-pushed the alexcrichton:thinlto-default branch from 8e25bf3 to 93e5fac Dec 23, 2017

@alexcrichton
rustc: Set release mode cgus to 16 by default 
This commit is the next attempt to enable multiple codegen units by default in
release mode, getting some of those sweet, sweet parallelism wins by running
codegen in parallel. Performance should not be lost due to ThinLTO being on by
default as well.

Closes #45320
Loading status checks…
b5361d0

@alexcrichton alexcrichton force-pushed the alexcrichton:thinlto-default branch from 93e5fac to b5361d0 Dec 24, 2017

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Dec 24, 2017

@bors: r=michaelwoerister
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 24, 2017

📌 Commit b5361d0 has been approved by michaelwoerister
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 25, 2017

⌛️ Testing commit b5361d0 with merge ae65dcc...

bors added a commit that referenced this pull request Dec 25, 2017

@bors
Auto merge of #46910 - alexcrichton:thinlto-default, r=michaelwoerister 
rustc: Set release mode cgus to 16 by default

This commit is the next attempt to enable multiple codegen units by default in
release mode, getting some of those sweet, sweet parallelism wins by running
codegen in parallel. Performance should not be lost due to ThinLTO being on by
default as well.

Closes #45320
Loading status checks…
ae65dcc
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 25, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: michaelwoerister
Pushing ae65dcc to master...

@bors bors merged commit b5361d0 into rust-lang:master Dec 25, 2017
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@alexcrichton alexcrichton deleted the alexcrichton:thinlto-default branch Dec 25, 2017

@bluss bluss added the relnotes label Dec 25, 2017

@leonardo-m

This comment has been minimized.

Sign in to view
Copy link

leonardo-m commented Dec 26, 2017 •
edited

Probably because of this I am seeing nearly halved compilation times. (But I am seeing a problem I'll file soon, I don't know if it's the same LLVM failure reported above. Edit: it's #47015 ).

@frewsxcv frewsxcv referenced this pull request Dec 30, 2017

Open

compilation with sancov and multiple codegen units results in SIGSEGV: invalid memory reference; nightly-2017-12-26 regression #47071

@kennytm kennytm referenced this pull request Jan 6, 2018

Closed

Spurious appveyor 32-bit test timeouts #46903

@andjo403 andjo403 referenced this pull request Jan 9, 2018

Merged

Bump to 1.25.0 #47141

This was referenced Jan 11, 2018

Open
Closed

@jonhoo jonhoo referenced this pull request Jan 11, 2018

Closed

Segfault on latest nightly with codegen-units > 1 #47364

@matthiaskrgr matthiaskrgr referenced this pull request Feb 6, 2018

Closed

monolithic lto link time very slow when building with several codegen units #48025

@michaelwoerister michaelwoerister referenced this pull request Feb 19, 2018

Closed

Reproducible builds regression in nightly #47135

@Aowassoto

This comment has been minimized.

Sign in to view
Copy link

Aowassoto commented Jun 17, 2018

Jsn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.