Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upBounce out the layout refactor from beta #46925
Conversation
arielb1
added some commits
Dec 21, 2017
rust-highfive
assigned
michaelwoerister
Dec 21, 2017
This comment has been minimized.
This comment has been minimized.
|
|
arielb1
force-pushed the
arielb1:make-the-trains-run-on-time
branch
from
80280f1
to
2eaec8b
Dec 21, 2017
arielb1
changed the title
Bounce out trans-related PRs from beta
Bounce out the layout refactor from beta
Dec 21, 2017
This comment has been minimized.
This comment has been minimized.
|
I thought that @alexcrichton's PR #45905 conflicts with #45225, but it is not based on @eddyb's PR and landed in parallel with it, so it's probably a better idea to leave it in. |
This comment has been minimized.
This comment has been minimized.
|
r=me |
arielb1
force-pushed the
arielb1:make-the-trains-run-on-time
branch
from
2eaec8b
to
d6a5946
Dec 21, 2017
This comment has been minimized.
This comment has been minimized.
|
This is a big beta change @bors r+ p=10 |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Dec 22, 2017
This comment has been minimized.
This comment has been minimized.
|
|
bors
merged commit d6a5946
into
rust-lang:beta
Dec 22, 2017
This comment has been minimized.
This comment has been minimized.
|
Thanks, folks! |
This was referenced Dec 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
arielb1 commentedDec 21, 2017
@eddyb's #45225 was supposed to get into get into 1.24, but due to an ordering mistake, it had snuck into 1.23.
That wide-effect translation-changing PR had poked LLVM's weak corners and caused many regressions (3 of them have fixes I include here, but also #46897, #46845, #46449, #46371). I don't think it is a good idea to land it in the beta (1.23) because there are bound to be some regressions we didn't patch.
Therefore, I am reverting it in time for stable, along with its related regression fixes.
r? @michaelwoerister (I think)