New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Span::parent()' and 'Span::source()' to proc_macro API. #47099

Merged
merged 1 commit into from Jan 6, 2018

Conversation

Projects
None yet
6 participants
@SergioBenitez
Contributor

SergioBenitez commented Jan 1, 2018

As the title suggests: a couple of useful methods for proc_macro.

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Jan 1, 2018

Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

Collaborator

rust-highfive commented Jan 1, 2018

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton
Member

alexcrichton commented Jan 2, 2018

@SergioBenitez

This comment has been minimized.

Show comment
Hide comment
@SergioBenitez

SergioBenitez Jan 2, 2018

Contributor

Yes, of course. I'll add some ui-tests as well.

Contributor

SergioBenitez commented Jan 2, 2018

Yes, of course. I'll add some ui-tests as well.

@jseyfried

This comment has been minimized.

Show comment
Hide comment
@jseyfried

jseyfried Jan 2, 2018

Contributor

Great!
Alternative naming idea: parent -> source, source -> original_source. parent sounds a little strange to me w.r.t. spans. I don't have a super strong opinion though.

cc @nrc

Contributor

jseyfried commented Jan 2, 2018

Great!
Alternative naming idea: parent -> source, source -> original_source. parent sounds a little strange to me w.r.t. spans. I don't have a super strong opinion though.

cc @nrc

@SergioBenitez

This comment has been minimized.

Show comment
Hide comment
@SergioBenitez

SergioBenitez Jan 3, 2018

Contributor

Added tests and fixed up the definition. I don't have a strong opinion about naming. parent simply felt more natural to me as I'm "moving up the chain".

Contributor

SergioBenitez commented Jan 3, 2018

Added tests and fixed up the definition. I don't have a strong opinion about naming. parent simply felt more natural to me as I'm "moving up the chain".

@SergioBenitez

This comment has been minimized.

Show comment
Hide comment
@SergioBenitez

SergioBenitez Jan 5, 2018

Contributor

@jseyfried Look okay?

Contributor

SergioBenitez commented Jan 5, 2018

@jseyfried Look okay?

@jseyfried

This comment has been minimized.

Show comment
Hide comment
@jseyfried

jseyfried Jan 5, 2018

Contributor

Yeah, let's land. @bors r+

Contributor

jseyfried commented Jan 5, 2018

Yeah, let's land. @bors r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jan 5, 2018

Contributor

📌 Commit ab365be has been approved by jseyfried

Contributor

bors commented Jan 5, 2018

📌 Commit ab365be has been approved by jseyfried

@rust-lang rust-lang deleted a comment from bors Jan 5, 2018

@rust-lang rust-lang deleted a comment from bors Jan 5, 2018

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jan 6, 2018

Contributor

⌛️ Testing commit ab365be with merge a9a03d9...

Contributor

bors commented Jan 6, 2018

⌛️ Testing commit ab365be with merge a9a03d9...

bors added a commit that referenced this pull request Jan 6, 2018

Auto merge of #47099 - SergioBenitez:master, r=jseyfried
Add 'Span::parent()' and 'Span::source()' to proc_macro API.

As the title suggests: a couple of useful methods for `proc_macro`.
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jan 6, 2018

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: jseyfried
Pushing a9a03d9 to master...

Contributor

bors commented Jan 6, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: jseyfried
Pushing a9a03d9 to master...

@bors bors merged commit ab365be into rust-lang:master Jan 6, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment