New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force appropriate extension when converting from int to ptr #43291 #47147

Merged
merged 1 commit into from Jan 4, 2018

Conversation

Projects
None yet
6 participants
@projektir
Contributor

projektir commented Jan 3, 2018

Fixes #43291.

Looking for feedback if I've missed something and/or need to add more tests.

@eddyb @retep998 @nagisa @oli-obk

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Jan 3, 2018

Collaborator

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

Collaborator

rust-highfive commented Jan 3, 2018

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

Show outdated Hide outdated src/test/run-pass/issue-43291.rs Outdated
@projektir

This comment has been minimized.

Show comment
Hide comment
@projektir

projektir Jan 3, 2018

Contributor

I'll rebase when everything looks good.

Contributor

projektir commented Jan 3, 2018

I'll rebase when everything looks good.

@eddyb

This comment has been minimized.

Show comment
Hide comment
@eddyb

eddyb Jan 3, 2018

Member

@bors r+

Member

eddyb commented Jan 3, 2018

@bors r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jan 3, 2018

Contributor

📌 Commit 6536d36 has been approved by eddyb

Contributor

bors commented Jan 3, 2018

📌 Commit 6536d36 has been approved by eddyb

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jan 4, 2018

Contributor

⌛️ Testing commit 6536d36 with merge 4cd918c...

Contributor

bors commented Jan 4, 2018

⌛️ Testing commit 6536d36 with merge 4cd918c...

bors added a commit that referenced this pull request Jan 4, 2018

Auto merge of #47147 - projektir:to_ptr_cast, r=eddyb
Force appropriate extension when converting from int to ptr #43291

Fixes #43291.

Looking for feedback if I've missed something and/or need to add more tests.

@eddyb @retep998 @nagisa @oli-obk
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jan 4, 2018

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 4cd918c to master...

Contributor

bors commented Jan 4, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 4cd918c to master...

@bors bors merged commit 6536d36 into rust-lang:master Jan 4, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@projektir projektir deleted the projektir:to_ptr_cast branch Jan 4, 2018

@nodakai nodakai referenced this pull request Jun 18, 2018

Closed

Document 43291 #189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment