New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the book to promote second edition #48404
Merged
bors
merged 1 commit into
rust-lang:master
from
steveklabnik:second-edition-is-the-best-edition
Feb 25, 2018
Merged
Update the book to promote second edition #48404
bors
merged 1 commit into
rust-lang:master
from
steveklabnik:second-edition-is-the-best-edition
Feb 25, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the book repository, but mostly to include rust-lang/book#1180 TL;DR: the second edition is close enough to done that we should universally recommend it over the first edition.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
r=me pending travis |
|
@bors r+ |
|
|
|
@bors rollup |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 24, 2018
…best-edition, r=QuietMisdreavus Update the book to promote second edition This updates the book repository, but mostly to include rust-lang/book#1180 TL;DR: the second edition is close enough to done that we should universally recommend it over the first edition.
bors
added a commit
that referenced
this pull request
Feb 24, 2018
bors
added a commit
that referenced
this pull request
Feb 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
relnotes
Marks issues that should be documented in the release notes of the next release.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This updates the book repository, but mostly to include
rust-lang/book#1180
TL;DR: the second edition is close enough to done that we should
universally recommend it over the first edition.