New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FreeBSD struct returning ABI. #48560

Merged
merged 2 commits into from Feb 28, 2018

Conversation

Projects
None yet
6 participants
@bdrewery
Contributor

bdrewery commented Feb 26, 2018

FreeBSD has had a patch similar to this for a while. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223047.

This reworks 6774e7a to be more specific about what compute_abi_info is checking for per target.

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Feb 26, 2018

Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Collaborator

rust-highfive commented Feb 26, 2018

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@bdrewery

This comment has been minimized.

Show comment
Hide comment
@bdrewery
Contributor

bdrewery commented Feb 26, 2018

bdrewery referenced this pull request Feb 26, 2018

OpenBSD under x86 has particular ABI for returning a struct.
It is like OSX or Windows: small structs are returned as integers.
@estebank

This comment has been minimized.

Show comment
Hide comment
@estebank

estebank Feb 27, 2018

Contributor

@bors r+

Contributor

estebank commented Feb 27, 2018

@bors r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Feb 27, 2018

Contributor

📌 Commit 279e5b0 has been approved by estebank

Contributor

bors commented Feb 27, 2018

📌 Commit 279e5b0 has been approved by estebank

kennytm added a commit to kennytm/rust that referenced this pull request Feb 27, 2018

Rollup merge of rust-lang#48560 - bdrewery:freebsd-struct-abi, r=este…
…bank

Fix FreeBSD struct returning ABI.

FreeBSD has had a patch similar to this for a while. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223047.

This reworks 6774e7a to be more specific about what `compute_abi_info` is checking for per target.
@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton
Member

alexcrichton commented Feb 27, 2018

@bors: rollup

bors added a commit that referenced this pull request Feb 27, 2018

Auto merge of #48577 - kennytm:rollup, r=kennytm
Rollup of 12 pull requests

- Successful merges: #48266, #48321, #48450, #48473, #48484, #48488, #48497, #48541, #48555, #48558, #48560, #48565
- Failed merges:

kennytm added a commit to kennytm/rust that referenced this pull request Feb 27, 2018

Rollup merge of rust-lang#48560 - bdrewery:freebsd-struct-abi, r=este…
…bank

Fix FreeBSD struct returning ABI.

FreeBSD has had a patch similar to this for a while. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223047.

This reworks 6774e7a to be more specific about what `compute_abi_info` is checking for per target.

bors added a commit that referenced this pull request Feb 27, 2018

Auto merge of #48577 - kennytm:rollup, r=kennytm
Rollup of 13 pull requests

- Successful merges: #48266, #48321, #48450, #48473, #48484, #48488, #48497, #48541, #48558, #48560, #48565, #48381, #48548
- Failed merges:

kennytm added a commit to kennytm/rust that referenced this pull request Feb 28, 2018

Rollup merge of rust-lang#48560 - bdrewery:freebsd-struct-abi, r=este…
…bank

Fix FreeBSD struct returning ABI.

FreeBSD has had a patch similar to this for a while. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223047.

This reworks 6774e7a to be more specific about what `compute_abi_info` is checking for per target.

bors added a commit that referenced this pull request Feb 28, 2018

Auto merge of #48608 - kennytm:rollup, r=kennytm
Rollup of 15 pull requests

- Successful merges: #48266, #48321, #48365, #48381, #48450, #48473, #48479, #48484, #48488, #48497, #48541, #48548, #48558, #48560, #48565
- Failed merges:

@bors bors merged commit 279e5b0 into rust-lang:master Feb 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment