New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin, Unpin, PinBox #49058

Merged
merged 9 commits into from Mar 20, 2018

Conversation

Projects
None yet
6 participants
@withoutboats
Contributor

withoutboats commented Mar 15, 2018

Implementing rust-lang/rfcs#2349 (do not merge until RFC is merged)

@bors r? @cramertj

withoutboats added some commits Mar 14, 2018

@cramertj

This comment has been minimized.

Member

cramertj commented Mar 15, 2018

This looks great to me! s/issue = "0"/issue = "<tracking issue #>" once a tracking issue is opened, but r=me otherwise.

withoutboats added some commits Mar 15, 2018

@withoutboats withoutboats referenced this pull request Mar 18, 2018

Open

Tracking issue for Pin APIs (RFC 2349) #49150

1 of 3 tasks complete
@withoutboats

This comment has been minimized.

Contributor

withoutboats commented Mar 18, 2018

@bors r=@cramertj p=100

@bors

This comment has been minimized.

Contributor

bors commented Mar 18, 2018

📌 Commit 2797aac has been approved by @cramertj

@bors bors added S-waiting-on-bors and removed S-blocked labels Mar 18, 2018

@bors

This comment has been minimized.

Contributor

bors commented Mar 18, 2018

⌛️ Testing commit 2797aac with merge f8224c2...

bors added a commit that referenced this pull request Mar 18, 2018

Auto merge of #49058 - withoutboats:pin, r=@cramertj
Pin, Unpin, PinBox

Implementing rust-lang/rfcs#2349 (do not merge until RFC is merged)

@bors r? @cramertj
@bors

This comment has been minimized.

Contributor

bors commented Mar 19, 2018

💔 Test failed - status-travis

@withoutboats

This comment has been minimized.

Contributor

withoutboats commented Mar 19, 2018

htmldoc failure, no idea how it could be related to this change

@kennytm

This comment has been minimized.

Member

kennytm commented Mar 19, 2018

Blocked by #49123.

@withoutboats

This comment has been minimized.

Contributor

withoutboats commented Mar 19, 2018

I can change the order of the bounds and it should pass?

@withoutboats

This comment has been minimized.

Contributor

withoutboats commented Mar 19, 2018

@kennytm also p=100 was because futures 0.2 is blocked on this landing in nightly (i assume thats what your confused face was about)

@kennytm

This comment has been minimized.

Member

kennytm commented Mar 19, 2018

@withoutboats if you need to change the test I suggest you // ignore it, because changing the order may break future PRs instead.

I'd like to let #49091 get merged first, since it fixes a very commonly encountered ICE.

@bors

This comment has been minimized.

Contributor

bors commented Mar 19, 2018

⌛️ Testing commit 2797aac with merge a1439aa...

bors added a commit that referenced this pull request Mar 19, 2018

Auto merge of #49058 - withoutboats:pin, r=@cramertj
Pin, Unpin, PinBox

Implementing rust-lang/rfcs#2349 (do not merge until RFC is merged)

@bors r? @cramertj
@alexcrichton

This comment has been minimized.

Member

alexcrichton commented Mar 19, 2018

@bors: retry

sorry bors, this already failed

@alexcrichton

This comment has been minimized.

Member

alexcrichton commented Mar 19, 2018

@bors: retry r-

@bors bors added S-waiting-on-author and removed S-blocked labels Mar 19, 2018

@bors

This comment has been minimized.

Contributor

bors commented Mar 19, 2018

💔 Test failed - status-travis

withoutboats added some commits Mar 19, 2018

@kennytm

This comment has been minimized.

Member

kennytm commented Mar 19, 2018

@bors r=cramertj

@bors

This comment has been minimized.

Contributor

bors commented Mar 19, 2018

📌 Commit e4d0d66 has been approved by cramertj

@withoutboats

This comment has been minimized.

Contributor

withoutboats commented Mar 19, 2018

@bors r-

withoutboats added some commits Mar 19, 2018

@withoutboats

This comment has been minimized.

Contributor

withoutboats commented Mar 19, 2018

@bors r=cramertj

@bors

This comment has been minimized.

Contributor

bors commented Mar 19, 2018

📌 Commit 540021f has been approved by cramertj

@bors

This comment has been minimized.

Contributor

bors commented Mar 19, 2018

⌛️ Testing commit 540021f with merge 6bfa7d0...

bors added a commit that referenced this pull request Mar 19, 2018

Auto merge of #49058 - withoutboats:pin, r=cramertj
Pin, Unpin, PinBox

Implementing rust-lang/rfcs#2349 (do not merge until RFC is merged)

@bors r? @cramertj
@bors

This comment has been minimized.

Contributor

bors commented Mar 20, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: cramertj
Pushing 6bfa7d0 to master...

@bors bors merged commit 540021f into rust-lang:master Mar 20, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment