New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin, Unpin, PinBox #49058
Pin, Unpin, PinBox #49058
Conversation
This looks great to me! s/ |
|
Pin, Unpin, PinBox Implementing rust-lang/rfcs#2349 (do not merge until RFC is merged) @bors r? @cramertj
|
htmldoc failure, no idea how it could be related to this change |
Blocked by #49123. |
I can change the order of the bounds and it should pass? |
@kennytm also p=100 was because futures 0.2 is blocked on this landing in nightly (i assume thats what your confused face was about) |
@withoutboats if you need to change the test I suggest you I'd like to let #49091 get merged first, since it fixes a very commonly encountered ICE. |
Pin, Unpin, PinBox Implementing rust-lang/rfcs#2349 (do not merge until RFC is merged) @bors r? @cramertj
@bors: retry sorry bors, this already failed |
@bors: retry r- |
|
@bors r=cramertj |
|
@bors r- |
@bors r=cramertj |
|
Pin, Unpin, PinBox Implementing rust-lang/rfcs#2349 (do not merge until RFC is merged) @bors r? @cramertj
|
Implementing rust-lang/rfcs#2349 (do not merge until RFC is merged)
@bors r? @cramertj