Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin, Unpin, PinBox #49058

Merged
merged 9 commits into from Mar 20, 2018

Conversation

Reviewers
No reviews
Assignees

@cramertj cramertj

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
6 participants
@withoutboats @cramertj @bors @kennytm @alexcrichton @rust-highfive
@withoutboats
Copy link
Contributor

withoutboats commented Mar 15, 2018

Implementing rust-lang/rfcs#2349 (do not merge until RFC is merged)

@bors r? @cramertj

withoutboats added some commits Mar 14, 2018

@withoutboats
Pin and Unpin in libcore.
Verified
This commit was signed with a verified signature.
@withoutboats withoutboats boats
GPG key ID: 92537B21110A684B Learn about signing commits
918ef67
@withoutboats
Add liballoc APIs.
Verified
This commit was signed with a verified signature.
@withoutboats withoutboats boats
GPG key ID: 92537B21110A684B Learn about signing commits
Loading status checks…
e3c5f69

@rust-highfive rust-highfive assigned cramertj Mar 15, 2018

@rust-highfive rust-highfive added the S-waiting-on-review label Mar 15, 2018

@cramertj

This comment has been minimized.

Sign in to view
Copy link
Member

cramertj commented Mar 15, 2018

This looks great to me! s/issue = "0"/issue = "<tracking issue #>" once a tracking issue is opened, but r=me otherwise.

@kennytm kennytm added S-blocked and removed S-waiting-on-review labels Mar 15, 2018

withoutboats added some commits Mar 15, 2018

@withoutboats
CoerceUnsized for PinBox
Verified
This commit was signed with a verified signature.
@withoutboats withoutboats boats
GPG key ID: 92537B21110A684B Learn about signing commits
Loading status checks…
2f1c24a
@withoutboats
Pin and PinBox are fundamental.
Verified
This commit was signed with a verified signature.
@withoutboats withoutboats boats
GPG key ID: 92537B21110A684B Learn about signing commits
Loading status checks…
81d0ece

@withoutboats withoutboats referenced this pull request Mar 18, 2018

Closed

Tracking issue for Pin APIs (RFC 2349) #49150

1 of 3 tasks complete
@withoutboats
Update tracking issue.
Verified
This commit was signed with a verified signature.
@withoutboats withoutboats boats
GPG key ID: 92537B21110A684B Learn about signing commits
Loading status checks…
2797aac
@withoutboats

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

withoutboats commented Mar 18, 2018

@bors r=@cramertj p=100
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 18, 2018

📌 Commit 2797aac has been approved by @cramertj

@bors bors added S-waiting-on-bors and removed S-blocked labels Mar 18, 2018

@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 18, 2018

⌛️ Testing commit 2797aac with merge f8224c2...

bors added a commit that referenced this pull request Mar 18, 2018

@bors
Auto merge of #49058 - withoutboats:pin, r=@cramertj 
Pin, Unpin, PinBox

Implementing rust-lang/rfcs#2349 (do not merge until RFC is merged)

@bors r? @cramertj
Loading status checks…
f8224c2
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 19, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review and removed S-waiting-on-bors labels Mar 19, 2018

@kennytm kennytm added S-blocked and removed S-waiting-on-review labels Mar 19, 2018

@withoutboats

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

withoutboats commented Mar 19, 2018

htmldoc failure, no idea how it could be related to this change
@kennytm

This comment has been minimized.

Sign in to view
Copy link
Member

kennytm commented Mar 19, 2018

Blocked by #49123.
@withoutboats

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

withoutboats commented Mar 19, 2018

I can change the order of the bounds and it should pass?
@withoutboats

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

withoutboats commented Mar 19, 2018

@kennytm also p=100 was because futures 0.2 is blocked on this landing in nightly (i assume thats what your confused face was about)
@kennytm

This comment has been minimized.

Sign in to view
Copy link
Member

kennytm commented Mar 19, 2018

@withoutboats if you need to change the test I suggest you // ignore it, because changing the order may break future PRs instead.

I'd like to let #49091 get merged first, since it fixes a very commonly encountered ICE.
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 19, 2018

⌛️ Testing commit 2797aac with merge a1439aa...

bors added a commit that referenced this pull request Mar 19, 2018

@bors
Auto merge of #49058 - withoutboats:pin, r=@cramertj 
Pin, Unpin, PinBox

Implementing rust-lang/rfcs#2349 (do not merge until RFC is merged)

@bors r? @cramertj
Loading status checks…
a1439aa
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Mar 19, 2018

@bors: retry

sorry bors, this already failed
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Mar 19, 2018

@bors: retry r-

@bors bors added S-waiting-on-author and removed S-blocked labels Mar 19, 2018

@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 19, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review and removed S-waiting-on-author labels Mar 19, 2018

withoutboats added some commits Mar 19, 2018

@withoutboats
Comment out flakey test.
Verified
This commit was signed with a verified signature.
@withoutboats withoutboats boats
GPG key ID: 92537B21110A684B Learn about signing commits
Loading status checks…
f8fb9f1
@withoutboats
Ignore properly.
Verified
This commit was signed with a verified signature.
@withoutboats withoutboats boats
GPG key ID: 92537B21110A684B Learn about signing commits
Loading status checks…
e4d0d66
@kennytm

This comment has been minimized.

Sign in to view
Copy link
Member

kennytm commented Mar 19, 2018

@bors r=cramertj
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 19, 2018

📌 Commit e4d0d66 has been approved by cramertj

@bors bors added S-waiting-on-bors and removed S-waiting-on-review labels Mar 19, 2018

@kennytm kennytm referenced this pull request Mar 19, 2018

Closed

Rustdoc: where bounds order in synthetic impls is not deterministic #49123

@withoutboats

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

withoutboats commented Mar 19, 2018

@bors r-

@bors bors added S-waiting-on-author and removed S-waiting-on-bors labels Mar 19, 2018

withoutboats added some commits Mar 19, 2018

@withoutboats
Comment out entire test.
Verified
This commit was signed with a verified signature.
@withoutboats withoutboats boats
GPG key ID: 92537B21110A684B Learn about signing commits
Loading status checks…
c68885b
@withoutboats
Okay this is the right way.
Verified
This commit was signed with a verified signature.
@withoutboats withoutboats boats
GPG key ID: 92537B21110A684B Learn about signing commits
Loading status checks…
540021f
@withoutboats

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

withoutboats commented Mar 19, 2018

@bors r=cramertj
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 19, 2018

📌 Commit 540021f has been approved by cramertj

@bors bors added S-waiting-on-bors and removed S-waiting-on-author labels Mar 19, 2018

@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 19, 2018

⌛️ Testing commit 540021f with merge 6bfa7d0...

bors added a commit that referenced this pull request Mar 19, 2018

@bors
Auto merge of #49058 - withoutboats:pin, r=cramertj 
Pin, Unpin, PinBox

Implementing rust-lang/rfcs#2349 (do not merge until RFC is merged)

@bors r? @cramertj
Loading status checks…
6bfa7d0
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 20, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: cramertj
Pushing 6bfa7d0 to master...

@bors bors merged commit 540021f into rust-lang:master Mar 20, 2018
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@SimonSapin SimonSapin referenced this pull request Mar 21, 2018

Merged

replace `convert::Infallible` with `!` #49038

@cramertj cramertj referenced this pull request Mar 23, 2018

Open

Tracking issue for `impl Trait` (RFC 1522, RFC 1951, RFC 2071) #34511

19 of 29 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.