Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated unstable alloc::heap::EMPTY constant #49082

Merged
merged 1 commit into from Mar 17, 2018

Conversation

Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
4 participants
@SimonSapin @rust-highfive @alexcrichton @bors
@SimonSapin
Copy link
Contributor

SimonSapin commented Mar 16, 2018

No description provided.

@rust-highfive rust-highfive assigned alexcrichton Mar 16, 2018

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Mar 16, 2018

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review label Mar 16, 2018

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Mar 16, 2018

@bors: r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 16, 2018

📌 Commit f0ad533 has been approved by alexcrichton

@bors bors added S-waiting-on-bors and removed S-waiting-on-review labels Mar 16, 2018

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Mar 16, 2018

@bors: rollup

kennytm added a commit to kennytm/rust that referenced this pull request Mar 17, 2018

@kennytm
Rollup merge of rust-lang#49082 - SimonSapin:mu, r=alexcrichton 
Remove deprecated unstable alloc::heap::EMPTY constant
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
7638c9f

@kennytm kennytm referenced this pull request Mar 17, 2018

Merged

Rollup of 8 pull requests #49106

bors added a commit that referenced this pull request Mar 17, 2018

@bors
Auto merge of #49106 - kennytm:rollup, r=kennytm 
Rollup of 8 pull requests

- Successful merges: #48943, #48960, #48983, #49055, #49057, #49077, #49082, #49083
- Failed merges:
Loading status checks…
61b6bf5

@bors bors merged commit f0ad533 into rust-lang:master Mar 17, 2018
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@SimonSapin SimonSapin deleted the SimonSapin:mu branch Mar 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.