Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or hide deprecated unstable SipHasher{13,24} #49108

Merged
merged 2 commits into from Mar 19, 2018

Conversation

Reviewers
No reviews
Assignees

@TimNN TimNN

Labels
S-waiting-on-bors T-libs relnotes
Projects
None yet
Milestone
No milestone
5 participants
@SimonSapin @rust-highfive @TimNN @bors @Centril
@SimonSapin
Copy link
Contributor

SimonSapin commented Mar 17, 2018

Deprecated since Rust 1.13.0.
@SimonSapin
Make the deprecated unstable SipHasher24 type private. 
It is still used by the deprecated *stable* `SipHasher` type.
c5f020a

@rust-highfive rust-highfive assigned TimNN Mar 17, 2018

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Mar 17, 2018

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @TimNN (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review label Mar 17, 2018

@SimonSapin SimonSapin force-pushed the SimonSapin:sip branch 2 times, most recently from ed27227 to 7159f2e Mar 17, 2018

@SimonSapin
Mark deprecated unstable SipHasher13 as a doc-hidden impl detail of H… 
…ashMap.

It stays in libcore rather than being private in HashMap’s module
because it shares code with the deprecated *stable* `SipHasher` type.
Loading status checks…
89ecb0d

@SimonSapin SimonSapin force-pushed the SimonSapin:sip branch from 7159f2e to 89ecb0d Mar 17, 2018

@Centril Centril added the relnotes label Mar 18, 2018

@TimNN

This comment has been minimized.

Sign in to view
Copy link
Contributor

TimNN commented Mar 18, 2018

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 18, 2018

📌 Commit 89ecb0d has been approved by TimNN

@bors bors added S-waiting-on-bors and removed S-waiting-on-review labels Mar 18, 2018

@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 19, 2018

⌛️ Testing commit 89ecb0d with merge aafe7d8...

bors added a commit that referenced this pull request Mar 19, 2018

@bors
Auto merge of #49108 - SimonSapin:sip, r=TimNN 
Remove or hide deprecated unstable SipHasher{13,24}

Deprecated since Rust 1.13.0.
Loading status checks…
aafe7d8

@SimonSapin SimonSapin added the T-libs label Mar 19, 2018

@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 19, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: TimNN
Pushing aafe7d8 to master...

@bors bors merged commit 89ecb0d into rust-lang:master Mar 19, 2018
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@SimonSapin SimonSapin deleted the SimonSapin:sip branch Mar 30, 2018

@SimonSapin SimonSapin referenced this pull request Mar 31, 2018

Closed

Tracking issue for SipHash13/SipHash24 #34767

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.