Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize impl Trait #49255

Merged
merged 2 commits into from Mar 26, 2018
Merged

Stabilize impl Trait #49255

merged 2 commits into from Mar 26, 2018

Conversation

cramertj
Copy link
Member

@cramertj cramertj commented Mar 22, 2018 •
edited

Blocked on:

I have not yet done any docs work for this-- I probably won't get to it until this weekend (might be a project for the flight to the all-hands).

@cramertj cramertj changed the title Stable impl trait Stabilize impl trait Mar 22, 2018
@rust-highfive
Copy link
Collaborator

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 22, 2018
@cramertj cramertj changed the title Stabilize impl trait Stabilize impl Trait Mar 22, 2018
@cramertj
Copy link
Member Author

r? @nikomatsakis

@cramertj
Copy link
Member Author

Also-- miri and clippy both used conservative_impl_trait internally. I removed those locally, but I'm not sure of the right way to update those submodules atomically w/ the feature removal.

@nikomatsakis
Copy link
Contributor

With respect to docs, @steveklabnik plans to file an RFC changing process there somewhat in any case.

nikomatsakis
nikomatsakis reviewed Mar 22, 2018
View reviewed changes
src/libsyntax/feature_gate.rs Outdated
// Allows `impl Trait` in function arguments.
(accepted, universal_impl_trait, "1.26.0", Some(34511), None),
// Allows `impl Trait` in function return types.
(accepted, conservative_impl_trait, "1.26.0", Some(34511), None),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wowoow... finally.

@nikomatsakis
Copy link
Contributor

@bors r+

The FCP is not yet complete, but it's hard to imagine what would cause us to reverse course here, and in any case we can always backport a patch to beta reversing course or fixing things up.

@bors
Copy link
Contributor

bors commented Mar 22, 2018

📌 Commit d818194 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 22, 2018
@nikomatsakis
Copy link
Contributor

nikomatsakis commented Mar 22, 2018 •
edited

(cc @Manishearth and @oli-obk for clippy/miri respectively)

@Manishearth
Copy link
Member

@cramertj we'll just update, thanks.

The best way to do it is to throw us a PR. even better is to update rustc to point to the commit in the PR so we don't need to come back and do that. But you don't have to.

@kennytm kennytm added the relnotes Marks issues that should be documented in the release notes of the next release. label Mar 22, 2018
@kennytm
Copy link
Member

kennytm commented Mar 22, 2018

Stabilize ALL The Things!

@mark-i-m
Copy link
Member

1.26 is going to be a really exciting release. We already have i128 and ..= in there...

@cramertj
Copy link
Member Author

@mark-i-m And !-type, and probably dyn and match_default_bindings, slice patterns...

@mark-i-m
Copy link
Member

Woah what really!? 🎉

@kennytm
Copy link
Member

kennytm commented Mar 23, 2018 •
edited

Confirmed stabilized:

  • Option<&mut T>::cloned()
  • LocalKey::try_with (for thread-local storage)
  • slice pattern (match x { &[y, z] => w, ... })
  • [T]::rotate_left and [T]::rotate_right
  • The Book 2nd edition
  • --remap-path-prefix
  • <*T>::add, <*T>::copy_nonoverlapping, etc
  • Box::leak
  • inclusive range (..=)
  • never type (!)
  • FusedIterator
  • format!("{:02x?}", [0x41, 0x42, 0x43])
  • closures will derive Copy and Clone

Scheduled to be stabilized:

  • i128 (likely can't make it 😞)
  • impl Trait

I'm not quite sure if dyn and match_default_bindings can make it, as 1.26 is going to enter beta on March 27th (Tuesday). We could keep 1.27 exciting??? 😄

@mark-i-m
Copy link
Member

Lol @nrc is this boring enough for you :)

@messense messense mentioned this pull request Mar 23, 2018
Closed
11 tasks
@sinkuu sinkuu mentioned this pull request Mar 23, 2018
Merged
@SimonSapin
Copy link
Contributor

Reviewers! Help me add to that list ;)

kennytm added a commit to kennytm/rust that referenced this pull request Mar 24, 2018
@kennytm
Rollup merge of rust-lang#49255 - cramertj:stable-impl-trait, r=nikom…
6560452 
…atsakis

Stabilize impl Trait

Blocked on:

- [x] rust-lang#49041 and
- [ ] completion of FCP in rust-lang#34511 (comment) (3 days from now).

I have not yet done any docs work for this-- I probably won't get to it until this weekend (might be a project for the flight to the all-hands).
@kennytm kennytm mentioned this pull request Mar 24, 2018
Closed
@bors
Copy link
Contributor

bors commented Mar 24, 2018

☔ The latest upstream changes (presumably #49251) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2018
@cramertj
Copy link
Member Author

cramertj commented Mar 26, 2018 •
edited

@bors r-

need to update lockfile first, perhaps? will test locally

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 26, 2018
@cramertj
Copy link
Member Author

@bors r=nikomatsakis p=100

@bors
Copy link
Contributor

bors commented Mar 26, 2018

📌 Commit c3e2961 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 26, 2018
@cramertj
Copy link
Member Author

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 26, 2018
@cramertj
Copy link
Member Author

@bors r=nikomatsakis p=100

@bors
Copy link
Contributor

bors commented Mar 26, 2018

📌 Commit 0f5b52e has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 26, 2018
@bors
Copy link
Contributor

bors commented Mar 26, 2018

⌛ Testing commit 0f5b52e with merge 5e4603f...

bors added a commit that referenced this pull request Mar 26, 2018
@bors
Auto merge of #49255 - cramertj:stable-impl-trait, r=nikomatsakis
5e4603f 
Stabilize impl Trait

Blocked on:

- [x] #49041 and
- [ ] completion of FCP in #34511 (comment) (3 days from now).

I have not yet done any docs work for this-- I probably won't get to it until this weekend (might be a project for the flight to the all-hands).
@bors
Copy link
Contributor

bors commented Mar 26, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 5e4603f to master...

@bors bors merged commit 0f5b52e into rust-lang:master Mar 26, 2018
This was referenced Mar 26, 2018
Merged
Merged
Closed
@cramertj cramertj deleted the stable-impl-trait branch March 26, 2018 11:58
@sunchao sunchao mentioned this pull request May 11, 2018
Open
5 tasks
@FranklinChen FranklinChen mentioned this pull request Jun 3, 2018
Open
@rodrimati1992 rodrimati1992 mentioned this pull request Nov 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis left review comments

@00imvj00 00imvj00 00imvj00 left review comments

Assignees

@nikomatsakis nikomatsakis

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet