Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update books for next release #49318

Merged
merged 1 commit into from Mar 24, 2018

Conversation

Projects
None yet
6 participants
@steveklabnik
Copy link
Member

steveklabnik commented Mar 23, 2018

No description provided.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Mar 23, 2018

r? @GuillaumeGomez

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Mar 23, 2018

warning Warning warning

  • These commits modify submodules.
@petrochenkov

This comment has been minimized.

Copy link
Contributor

petrochenkov commented Mar 23, 2018

@steveklabnik
#48516 got into the next release, but rust-lang-nursery/reference#259 is still not merged.

@kennytm

This comment has been minimized.

Copy link
Member

kennytm commented Mar 24, 2018

Lots of broken links.

[01:20:47] reference/special-types-and-traits.html:143: broken link fragment `#associated-functions-and-methods` pointing to `reference/items/traits.html`
[01:20:47] reference/lifetime-elision.html:137: broken link fragment `#function-pointers` pointing to `reference/types.html`
[01:20:47] reference/lifetime-elision.html:240: broken link fragment `#constant-items` pointing to `reference/items.html`
[01:20:47] reference/lifetime-elision.html:240: broken link fragment `#static-items` pointing to `reference/items.html`
[01:20:47] reference/types.html:631: broken link fragment `#elision-and-defaults-in-trait-objects` pointing to `reference/lifetime-elision.html`
[01:20:47] reference/items/constant-items.html:147: broken link - reference/items/lifetime-elision.html
[01:20:47] reference/expressions/operator-expr.html:138: broken link fragment `#the--operator` pointing to `reference/expressions/operator-expr.html`
[01:20:47] reference/expressions/match-expr.html:257: broken link - reference/range-expr.html
[01:20:47] reference/macros-by-example.html:154: broken link - reference/keyword.html
[01:20:47] reference/print.html:1059: broken link - reference/keyword.html
[01:20:47] reference/print.html:1921: broken link - reference/items/lifetime-elision.html
[01:20:47] reference/print.html:3641: broken link fragment `#the--operator` pointing to `reference/print.html`
[01:20:47] reference/print.html:5043: broken link - reference/range-expr.html
[01:20:47] reference/print.html:5586: broken link fragment `#elision-and-defaults-in-trait-objects` pointing to `reference/lifetime-elision.html`
[01:20:47] reference/print.html:6202: broken link fragment `#function-pointers` pointing to `reference/types.html`
[01:20:47] reference/print.html:6305: broken link fragment `#constant-items` pointing to `reference/items.html`
[01:20:47] reference/print.html:6305: broken link fragment `#static-items` pointing to `reference/items.html`
[01:20:47] reference/print.html:6351: broken link fragment `#associated-functions-and-methods` pointing to `reference/items/traits.html`
[01:20:49] thread 'main' panicked at 'found some broken links', tools/linkchecker/main.rs:49:9
[01:20:49] note: Run with `RUST_BACKTRACE=1` for a backtrace.
@steveklabnik

This comment has been minimized.

Copy link
Member Author

steveklabnik commented Mar 24, 2018

@steveklabnik steveklabnik force-pushed the steveklabnik:update-books branch from dbace28 to 36322d0 Mar 24, 2018

@steveklabnik

This comment has been minimized.

Copy link
Member Author

steveklabnik commented Mar 24, 2018

Locally, this claims to have built. Let's see what travis says.

@kennytm

This comment has been minimized.

Copy link
Member

kennytm commented Mar 24, 2018

@bors r+ rollup

Travis passed.

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Mar 24, 2018

📌 Commit 36322d0 has been approved by kennytm

kennytm added a commit to kennytm/rust that referenced this pull request Mar 24, 2018

bors added a commit that referenced this pull request Mar 24, 2018

@bors bors merged commit 36322d0 into rust-lang:master Mar 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@steveklabnik steveklabnik deleted the steveklabnik:update-books branch Mar 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.