Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upRevert "Add TryFrom and TryInto to the prelude" #49518
Conversation
This comment has been minimized.
This comment has been minimized.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
This comment has been minimized.
This comment has been minimized.
|
@bors: p=10 This fixes breakage on Nightly and needs to be in 1.26. |
This comment has been minimized.
This comment has been minimized.
|
@bors: r+ |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
Revert "Add TryFrom and TryInto to the prelude" This reverts commit 09008cc. This addition landed in #49305 and turned out to break crates that had their own copy of `TryFrom` in order to use it on the Stable channel :( We’ll explore the possibility of the 2018 edition having a different prelude that includes this traits. However per the editions RFC this requires implementing a warning in the 2015 edition for code that *would* break.
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
ZoeyR
commented
Apr 2, 2018
|
Where would we track the backport of this into beta? |
This comment has been minimized.
This comment has been minimized.
|
@dgriffen oh beta just branched so this should already be included in beta |
SimonSapin commentedMar 30, 2018
•
edited
This reverts commit 09008cc.
This addition landed in #49305 and turned out to break many crates :( Those had other traits with methods named
try_fromandtry_into, and calls became ambiguous. For example: #49305 (comment). Most of them copied theTryFromorTryIntotrait into a library in order to use it on the Stable channel while the standard library ones were unstable.We’ll explore the possibility of the 2018 edition having a different prelude that includes this traits. However per the editions RFC this requires implementing a warning in the 2015 edition for code that would break.