Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add TryFrom and TryInto to the prelude" #49518

Merged
merged 1 commit into from Mar 30, 2018

Conversation

Reviewers
No reviews
Assignees

@aturon aturon

Labels
S-waiting-on-bors T-libs
Projects
None yet
Milestone
No milestone
6 participants
@SimonSapin @rust-highfive @alexcrichton @bors @dgriffen @aturon
@SimonSapin
Copy link
Contributor

SimonSapin commented Mar 30, 2018

This reverts commit 09008cc.

This addition landed in #49305 and turned out to break crates that had their own copy of TryFrom in order to use it on the Stable channel :(

We’ll explore the possibility of the 2018 edition having a different prelude that includes this traits. However per the editions RFC this requires implementing a warning in the 2015 edition for code that would break.
@SimonSapin
Revert "Add TryFrom and TryInto to the prelude" 
This reverts commit 09008cc.
Loading status checks…
ba4f310

@SimonSapin SimonSapin added the T-libs label Mar 30, 2018

@rust-highfive rust-highfive assigned aturon Mar 30, 2018

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Mar 30, 2018

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review label Mar 30, 2018

@SimonSapin

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

SimonSapin commented Mar 30, 2018 •
edited

@bors: p=10

This fixes breakage on Nightly and needs to be in 1.26.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Mar 30, 2018

@bors: r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 30, 2018

📌 Commit ba4f310 has been approved by alexcrichton

@bors bors added S-waiting-on-bors and removed S-waiting-on-review labels Mar 30, 2018

@frewsxcv frewsxcv referenced this pull request Mar 30, 2018

Merged

Stabilize TryFrom / TryInto, and tweak impls for integers #49305

@tirkarthi tirkarthi referenced this pull request Mar 30, 2018

Closed

Compilation on nightly fails #175

@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 30, 2018

⌛️ Testing commit ba4f310 with merge f1c21b0...

bors added a commit that referenced this pull request Mar 30, 2018

@bors
Auto merge of #49518 - SimonSapin:prelude, r=alexcrichton 
Revert "Add TryFrom and TryInto to the prelude"

This reverts commit 09008cc.

This addition landed in #49305 and turned out to break crates that had their own copy of `TryFrom` in order to use it on the Stable channel :(

We’ll explore the possibility of the 2018 edition having a different prelude that includes this traits. However per the editions RFC this requires implementing a warning in the 2015 edition for code that *would* break.
Loading status checks…
f1c21b0
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 30, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing f1c21b0 to master...

@bors bors merged commit ba4f310 into rust-lang:master Mar 30, 2018
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@rleungx rleungx referenced this pull request Mar 31, 2018

Closed

Cargo build failed with rustc 1.26.0-nightly #12

This was referenced Mar 31, 2018

Closed
Closed
Closed
Closed

@sunchao sunchao referenced this pull request Mar 31, 2018

Merged

change CI back to use nightly #72

@koute koute referenced this pull request Apr 1, 2018

Closed

Cargo install fails on Linux #88

This was referenced Apr 2, 2018

Open
Open
@dgriffen

This comment has been minimized.

Sign in to view
Copy link

dgriffen commented Apr 2, 2018

Where would we track the backport of this into beta?
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Apr 2, 2018

@dgriffen oh beta just branched so this should already be included in beta

@davidalber davidalber referenced this pull request Apr 5, 2018

Closed

Gracefully handle rustaceans.org going down #126

@tirkarthi tirkarthi referenced this pull request Apr 5, 2018

Open

Nightly `TryInto` and `TryFrom` trait support #6

@SimonSapin SimonSapin deleted the SimonSapin:prelude branch May 16, 2018

@SimonSapin SimonSapin referenced this pull request Jun 7, 2018

Closed

Tracking issue for the 2018 edition’s prelude #51418

@SimonSapin SimonSapin referenced this pull request Jun 23, 2018

Open

Conversions: `FromLossy` and `TryFromLossy` traits #2484

@jeekobu jeekobu referenced this pull request Nov 13, 2018

Open

Tracking issue for TryFrom/TryInto traits #33417

1 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.