Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add TryFrom and TryInto to the prelude" #49518

Merged
merged 1 commit into from Mar 30, 2018

Conversation

@SimonSapin
Copy link
Contributor

SimonSapin commented Mar 30, 2018

This reverts commit 09008cc.

This addition landed in #49305 and turned out to break many crates :( Those had other traits with methods named try_from and try_into, and calls became ambiguous. For example: #49305 (comment). Most of them copied the TryFrom or TryInto trait into a library in order to use it on the Stable channel while the standard library ones were unstable.

We’ll explore the possibility of the 2018 edition having a different prelude that includes this traits. However per the editions RFC this requires implementing a warning in the 2015 edition for code that would break.

This reverts commit 09008cc.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Mar 30, 2018

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@SimonSapin

This comment has been minimized.

Copy link
Contributor Author

SimonSapin commented Mar 30, 2018

@bors: p=10

This fixes breakage on Nightly and needs to be in 1.26.

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Mar 30, 2018

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Mar 30, 2018

📌 Commit ba4f310 has been approved by alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Mar 30, 2018

⌛️ Testing commit ba4f310 with merge f1c21b0...

bors added a commit that referenced this pull request Mar 30, 2018
Revert "Add TryFrom and TryInto to the prelude"

This reverts commit 09008cc.

This addition landed in #49305 and turned out to break crates that had their own copy of `TryFrom` in order to use it on the Stable channel :(

We’ll explore the possibility of the 2018 edition having a different prelude that includes this traits. However per the editions RFC this requires implementing a warning in the 2015 edition for code that *would* break.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Mar 30, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing f1c21b0 to master...

@bors bors merged commit ba4f310 into rust-lang:master Mar 30, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@koute koute mentioned this pull request Apr 1, 2018
@ZoeyR

This comment has been minimized.

Copy link

ZoeyR commented Apr 2, 2018

Where would we track the backport of this into beta?

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Apr 2, 2018

@dgriffen oh beta just branched so this should already be included in beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.