Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd some groundwork for cross-language LTO. #50000
Conversation
rust-highfive
assigned
alexcrichton
Apr 16, 2018
rust-highfive
added
the
S-waiting-on-review
label
Apr 16, 2018
This comment was marked as outdated.
This comment was marked as outdated.
|
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
michaelwoerister
force-pushed the
michaelwoerister:cross-lang-lto
branch
from
d83758e
to
0869f7b
Apr 16, 2018
This comment has been minimized.
This comment has been minimized.
|
@bors: r+ Looks great! |
This comment has been minimized.
This comment has been minimized.
|
|
bors
added
S-waiting-on-bors
and removed
S-waiting-on-review
labels
Apr 16, 2018
This comment was marked as outdated.
This comment was marked as outdated.
|
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This comment has been minimized.
This comment has been minimized.
|
@bors r- (travis failing) |
bors
added
S-waiting-on-author
and removed
S-waiting-on-bors
labels
Apr 16, 2018
This comment has been minimized.
This comment has been minimized.
|
@rust-lang/infra, |
This comment has been minimized.
This comment has been minimized.
|
I think that |
This comment has been minimized.
This comment has been minimized.
|
I can find |
This comment has been minimized.
This comment has been minimized.
|
I'm calling it like this:
So it should not need to be in |
This comment has been minimized.
This comment has been minimized.
|
Oh, but maybe we are not building LLVM ourselves in all cases? |
This comment was marked as outdated.
This comment was marked as outdated.
|
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This comment was marked as outdated.
This comment was marked as outdated.
|
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
michaelwoerister
force-pushed the
michaelwoerister:cross-lang-lto
branch
from
8dc6599
to
56df629
Apr 17, 2018
This comment has been minimized.
This comment has been minimized.
|
@bors r=alexcrichton |
This comment has been minimized.
This comment has been minimized.
|
|
bors
added
S-waiting-on-bors
and removed
S-waiting-on-author
labels
Apr 17, 2018
This comment has been minimized.
This comment has been minimized.
|
|
bors
added
S-waiting-on-author
and removed
S-waiting-on-bors
labels
Apr 18, 2018
michaelwoerister
force-pushed the
michaelwoerister:cross-lang-lto
branch
from
56df629
to
34d58d7
Apr 19, 2018
This comment has been minimized.
This comment has been minimized.
|
Rebased. @bors r=alexcrichton |
This comment has been minimized.
This comment has been minimized.
|
|
bors
added
the
S-waiting-on-review
label
May 4, 2018
This comment has been minimized.
This comment has been minimized.
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This comment has been minimized.
This comment has been minimized.
|
That's a blatantly spurious error. |
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-bors
and removed
S-waiting-on-review
labels
May 4, 2018
This comment has been minimized.
This comment has been minimized.
added a commit
that referenced
this pull request
May 4, 2018
This comment has been minimized.
This comment has been minimized.
|
|
bors
added
S-waiting-on-review
and removed
S-waiting-on-bors
labels
May 4, 2018
This comment has been minimized.
This comment has been minimized.
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
kennytm
added
S-waiting-on-author
and removed
S-waiting-on-review
labels
May 5, 2018
This comment has been minimized.
This comment has been minimized.
|
Seems like @bors r=alexcrichton |
This comment has been minimized.
This comment has been minimized.
|
|
bors
added
S-waiting-on-bors
and removed
S-waiting-on-author
labels
May 7, 2018
This comment has been minimized.
This comment has been minimized.
added a commit
that referenced
this pull request
May 7, 2018
This comment has been minimized.
This comment has been minimized.
|
|
bors
merged commit 0bf26bf
into
rust-lang:master
May 7, 2018
bors
referenced this pull request
May 7, 2018
Merged
compiletest: Run revisions as independent tests. #50400
This comment has been minimized.
This comment has been minimized.
|
|
michaelwoerister commentedApr 16, 2018
Implements part of #49879:
-Z cross-lang-ltoflag to rustcThis should already allow for using cross language LTO for staticlibs (where one has to invoke the linker manually anyway). However,
rustcwill not try to enable LTO for its own linker invocations yet.r? @alexcrichton